mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-27 13:13:31 +00:00
107 lines
2.6 KiB
PHP
107 lines
2.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Rector\CodeQuality\Rector\Ternary;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\ArrayDimFetch;
|
|
use PhpParser\Node\Expr\BinaryOp\Coalesce;
|
|
use PhpParser\Node\Expr\FuncCall;
|
|
use PhpParser\Node\Expr\Ternary;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
|
|
/**
|
|
* @see https://3v4l.org/f7itn
|
|
*
|
|
* @see \Rector\Tests\CodeQuality\Rector\Ternary\ArrayKeyExistsTernaryThenValueToCoalescingRector\ArrayKeyExistsTernaryThenValueToCoalescingRectorTest
|
|
*/
|
|
final class ArrayKeyExistsTernaryThenValueToCoalescingRector extends AbstractRector
|
|
{
|
|
public function getRuleDefinition(): RuleDefinition
|
|
{
|
|
return new RuleDefinition(
|
|
'Change array_key_exists() ternary to coalesing',
|
|
[
|
|
new CodeSample(
|
|
<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run($values, $keyToMatch)
|
|
{
|
|
$result = array_key_exists($keyToMatch, $values) ? $values[$keyToMatch] : null;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
,
|
|
<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run($values, $keyToMatch)
|
|
{
|
|
$result = $values[$keyToMatch] ?? null;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
),
|
|
]
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes(): array
|
|
{
|
|
return [Ternary::class];
|
|
}
|
|
|
|
/**
|
|
* @param Ternary $node
|
|
*/
|
|
public function refactor(Node $node): ?Node
|
|
{
|
|
if (! $node->cond instanceof FuncCall) {
|
|
return null;
|
|
}
|
|
|
|
if (! $this->isName($node->cond, 'array_key_exists')) {
|
|
return null;
|
|
}
|
|
|
|
if (! $node->if instanceof ArrayDimFetch) {
|
|
return null;
|
|
}
|
|
|
|
if (! $this->areArrayKeysExistsArgsMatchingDimFetch($node->cond, $node->if)) {
|
|
return null;
|
|
}
|
|
|
|
if (! $this->valueResolver->isNull($node->else)) {
|
|
return null;
|
|
}
|
|
|
|
return new Coalesce($node->if, $node->else);
|
|
}
|
|
|
|
/**
|
|
* Equals if:
|
|
*
|
|
* array_key_exists($key, $values);
|
|
* =
|
|
* $values[$key]
|
|
*/
|
|
private function areArrayKeysExistsArgsMatchingDimFetch(FuncCall $funcCall, ArrayDimFetch $arrayDimFetch): bool
|
|
{
|
|
$keyExpr = $funcCall->args[0]->value;
|
|
$valuesExpr = $funcCall->args[1]->value;
|
|
|
|
if (! $this->nodeComparator->areNodesEqual($arrayDimFetch->var, $valuesExpr)) {
|
|
return false;
|
|
}
|
|
return $this->nodeComparator->areNodesEqual($arrayDimFetch->dim, $keyExpr);
|
|
}
|
|
}
|