mirror of https://github.com/rectorphp/rector.git
215 lines
7.8 KiB
PHP
215 lines
7.8 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\DowngradePhp72\Rector\ClassMethod;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Param;
|
|
use PhpParser\Node\Stmt\ClassLike;
|
|
use PhpParser\Node\Stmt\ClassMethod;
|
|
use PHPStan\Reflection\ClassReflection;
|
|
use Rector\Core\Contract\Rector\AllowEmptyConfigurableRectorInterface;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\Core\Reflection\ReflectionResolver;
|
|
use Rector\DowngradePhp72\NodeAnalyzer\BuiltInMethodAnalyzer;
|
|
use Rector\DowngradePhp72\NodeAnalyzer\OverrideFromAnonymousClassMethodAnalyzer;
|
|
use Rector\DowngradePhp72\NodeAnalyzer\SealedClassAnalyzer;
|
|
use Rector\DowngradePhp72\PhpDoc\NativeParamToPhpDocDecorator;
|
|
use Rector\TypeDeclaration\NodeAnalyzer\AutowiredClassMethodOrPropertyAnalyzer;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
use RectorPrefix202209\Webmozart\Assert\Assert;
|
|
/**
|
|
* @changelog https://www.php.net/manual/en/migration72.new-features.php#migration72.new-features.param-type-widening
|
|
* @changelog https://3v4l.org/fOgSE
|
|
*
|
|
* @see \Rector\Tests\DowngradePhp72\Rector\ClassMethod\DowngradeParameterTypeWideningRector\DowngradeParameterTypeWideningRectorTest
|
|
*/
|
|
final class DowngradeParameterTypeWideningRector extends AbstractRector implements AllowEmptyConfigurableRectorInterface
|
|
{
|
|
/**
|
|
* @var array<string, string[]>
|
|
*/
|
|
private $unsafeTypesToMethods = [];
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\DowngradePhp72\PhpDoc\NativeParamToPhpDocDecorator
|
|
*/
|
|
private $nativeParamToPhpDocDecorator;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\Core\Reflection\ReflectionResolver
|
|
*/
|
|
private $reflectionResolver;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\TypeDeclaration\NodeAnalyzer\AutowiredClassMethodOrPropertyAnalyzer
|
|
*/
|
|
private $autowiredClassMethodOrPropertyAnalyzer;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\DowngradePhp72\NodeAnalyzer\BuiltInMethodAnalyzer
|
|
*/
|
|
private $builtInMethodAnalyzer;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\DowngradePhp72\NodeAnalyzer\OverrideFromAnonymousClassMethodAnalyzer
|
|
*/
|
|
private $overrideFromAnonymousClassMethodAnalyzer;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\DowngradePhp72\NodeAnalyzer\SealedClassAnalyzer
|
|
*/
|
|
private $sealedClassAnalyzer;
|
|
public function __construct(NativeParamToPhpDocDecorator $nativeParamToPhpDocDecorator, ReflectionResolver $reflectionResolver, AutowiredClassMethodOrPropertyAnalyzer $autowiredClassMethodOrPropertyAnalyzer, BuiltInMethodAnalyzer $builtInMethodAnalyzer, OverrideFromAnonymousClassMethodAnalyzer $overrideFromAnonymousClassMethodAnalyzer, SealedClassAnalyzer $sealedClassAnalyzer)
|
|
{
|
|
$this->nativeParamToPhpDocDecorator = $nativeParamToPhpDocDecorator;
|
|
$this->reflectionResolver = $reflectionResolver;
|
|
$this->autowiredClassMethodOrPropertyAnalyzer = $autowiredClassMethodOrPropertyAnalyzer;
|
|
$this->builtInMethodAnalyzer = $builtInMethodAnalyzer;
|
|
$this->overrideFromAnonymousClassMethodAnalyzer = $overrideFromAnonymousClassMethodAnalyzer;
|
|
$this->sealedClassAnalyzer = $sealedClassAnalyzer;
|
|
}
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Change param type to match the lowest type in whole family tree', [new ConfiguredCodeSample(<<<'CODE_SAMPLE'
|
|
interface SomeInterface
|
|
{
|
|
public function test(array $input);
|
|
}
|
|
final class SomeClass implements SomeInterface
|
|
{
|
|
public function test($input)
|
|
{
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
interface SomeInterface
|
|
{
|
|
/**
|
|
* @param mixed[] $input
|
|
*/
|
|
public function test($input);
|
|
}
|
|
final class SomeClass implements SomeInterface
|
|
{
|
|
public function test($input)
|
|
{
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, ['ContainerInterface' => ['set', 'get', 'has', 'initialized'], 'SomeContainerInterface' => ['set', 'has']])]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [ClassMethod::class];
|
|
}
|
|
/**
|
|
* @param ClassMethod $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
$classLike = $this->betterNodeFinder->findParentType($node, ClassLike::class);
|
|
if (!$classLike instanceof ClassLike) {
|
|
return null;
|
|
}
|
|
$ancestorOverridableAnonymousClass = $this->overrideFromAnonymousClassMethodAnalyzer->matchAncestorClassReflectionOverrideable($classLike, $node);
|
|
if ($ancestorOverridableAnonymousClass instanceof ClassReflection) {
|
|
return $this->processRemoveParamTypeFromMethod($ancestorOverridableAnonymousClass, $node);
|
|
}
|
|
$classReflection = $this->reflectionResolver->resolveClassAndAnonymousClass($classLike);
|
|
return $this->processRemoveParamTypeFromMethod($classReflection, $node);
|
|
}
|
|
/**
|
|
* @param mixed[] $configuration
|
|
*/
|
|
public function configure(array $configuration) : void
|
|
{
|
|
$unsafeTypesToMethods = $configuration;
|
|
foreach ($unsafeTypesToMethods as $key => $value) {
|
|
Assert::string($key);
|
|
Assert::allString($value);
|
|
}
|
|
$this->unsafeTypesToMethods = $unsafeTypesToMethods;
|
|
}
|
|
private function shouldSkip(ClassReflection $classReflection, ClassMethod $classMethod) : bool
|
|
{
|
|
if ($classMethod->params === []) {
|
|
return \true;
|
|
}
|
|
if ($classMethod->isPrivate()) {
|
|
return \true;
|
|
}
|
|
if ($classMethod->isMagic()) {
|
|
return \true;
|
|
}
|
|
if ($this->sealedClassAnalyzer->isSealedClass($classReflection)) {
|
|
return \true;
|
|
}
|
|
if ($this->autowiredClassMethodOrPropertyAnalyzer->detect($classMethod)) {
|
|
return \true;
|
|
}
|
|
if ($this->hasParamAlreadyNonTyped($classMethod)) {
|
|
return \true;
|
|
}
|
|
return $this->isSafeType($classReflection, $classMethod);
|
|
}
|
|
private function processRemoveParamTypeFromMethod(ClassReflection $classReflection, ClassMethod $classMethod) : ?ClassMethod
|
|
{
|
|
if ($this->shouldSkip($classReflection, $classMethod)) {
|
|
return null;
|
|
}
|
|
if ($this->builtInMethodAnalyzer->isImplementsBuiltInInterface($classReflection, $classMethod)) {
|
|
return null;
|
|
}
|
|
// Downgrade every scalar parameter, just to be sure
|
|
foreach (\array_keys($classMethod->params) as $paramPosition) {
|
|
$this->removeParamTypeFromMethod($classMethod, $paramPosition);
|
|
}
|
|
return $classMethod;
|
|
}
|
|
private function removeParamTypeFromMethod(ClassMethod $classMethod, int $paramPosition) : void
|
|
{
|
|
$param = $classMethod->params[$paramPosition] ?? null;
|
|
if (!$param instanceof Param) {
|
|
return;
|
|
}
|
|
// Add the current type in the PHPDoc
|
|
$this->nativeParamToPhpDocDecorator->decorate($classMethod, $param);
|
|
$param->type = null;
|
|
}
|
|
private function hasParamAlreadyNonTyped(ClassMethod $classMethod) : bool
|
|
{
|
|
foreach ($classMethod->params as $param) {
|
|
if ($param->type !== null) {
|
|
return \false;
|
|
}
|
|
}
|
|
return \true;
|
|
}
|
|
private function isSafeType(ClassReflection $classReflection, ClassMethod $classMethod) : bool
|
|
{
|
|
if ($this->unsafeTypesToMethods === []) {
|
|
return \false;
|
|
}
|
|
$classReflectionName = $classReflection->getName();
|
|
foreach ($this->unsafeTypesToMethods as $unsafeType => $unsafeMethods) {
|
|
if (!$this->isNames($classMethod, $unsafeMethods)) {
|
|
continue;
|
|
}
|
|
if ($classReflection->isSubclassOf($unsafeType)) {
|
|
return \false;
|
|
}
|
|
// skip self too
|
|
if ($classReflectionName === $unsafeType) {
|
|
return \false;
|
|
}
|
|
}
|
|
return \true;
|
|
}
|
|
}
|