rector/vendor/rector/rector-downgrade-php/rules/DowngradePhp74/Rector/ClassMethod/DowngradeCovariantReturnTypeRector.php
Tomas Votruba 28c719d1fb Updated Rector to commit 8961d20f56fa4b39bb21feec1f24422398f13dba
8961d20f56 [DX] Localize multi instance checker and privates accessor from Symplify + bump to PHPStan 1.8.3 (#2883)
2022-09-01 19:30:48 +00:00

215 lines
8.0 KiB
PHP

<?php
declare (strict_types=1);
namespace Rector\DowngradePhp74\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\ComplexType;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name;
use PhpParser\Node\NullableType;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\UnionType;
use PHPStan\Reflection\ClassMemberAccessAnswerer;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Reflection\Php\PhpMethodReflection;
use PHPStan\Type\MixedType;
use PHPStan\Type\StaticType;
use PHPStan\Type\ThisType;
use PHPStan\Type\Type;
use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger;
use Rector\Core\Rector\AbstractRector;
use Rector\Core\Reflection\ReflectionResolver;
use Rector\Core\Util\Reflection\PrivatesAccessor;
use Rector\DeadCode\PhpDoc\TagRemover\ReturnTagRemover;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
use Rector\StaticTypeMapper\ValueObject\Type\ParentStaticType;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://www.php.net/manual/en/migration74.new-features.php#migration74.new-features.core.type-variance
*
* @see \Rector\Tests\DowngradePhp74\Rector\ClassMethod\DowngradeCovariantReturnTypeRector\DowngradeCovariantReturnTypeRectorTest
*/
final class DowngradeCovariantReturnTypeRector extends AbstractRector
{
/**
* @readonly
* @var \Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger
*/
private $phpDocTypeChanger;
/**
* @readonly
* @var \Rector\DeadCode\PhpDoc\TagRemover\ReturnTagRemover
*/
private $returnTagRemover;
/**
* @readonly
* @var \Rector\Core\Reflection\ReflectionResolver
*/
private $reflectionResolver;
/**
* @readonly
* @var \Rector\Core\Util\Reflection\PrivatesAccessor
*/
private $privatesAccessor;
public function __construct(PhpDocTypeChanger $phpDocTypeChanger, ReturnTagRemover $returnTagRemover, ReflectionResolver $reflectionResolver, PrivatesAccessor $privatesAccessor)
{
$this->phpDocTypeChanger = $phpDocTypeChanger;
$this->returnTagRemover = $returnTagRemover;
$this->reflectionResolver = $reflectionResolver;
$this->privatesAccessor = $privatesAccessor;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Make method return same type as parent', [new CodeSample(<<<'CODE_SAMPLE'
class ParentType {}
class ChildType extends ParentType {}
class A
{
public function covariantReturnTypes(): ParentType
{
}
}
class B extends A
{
public function covariantReturnTypes(): ChildType
{
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class ParentType {}
class ChildType extends ParentType {}
class A
{
public function covariantReturnTypes(): ParentType
{
}
}
class B extends A
{
/**
* @return ChildType
*/
public function covariantReturnTypes(): ParentType
{
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [ClassMethod::class];
}
/**
* @param ClassMethod $node
*/
public function refactor(Node $node) : ?Node
{
if ($node->returnType === null) {
return null;
}
$parentReturnType = $this->resolveDifferentAncestorReturnType($node, $node->returnType);
if ($parentReturnType instanceof MixedType) {
return null;
}
// The return type name could either be a classname, without the leading "\",
// or one among the reserved identifiers ("static", "self", "iterable", etc)
// To find out which is the case, check if this name exists as a class
$parentReturnTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($parentReturnType, TypeKind::RETURN);
if (!$parentReturnTypeNode instanceof Node) {
return null;
}
// Make it nullable?
if ($node->returnType instanceof NullableType && !$parentReturnTypeNode instanceof ComplexType) {
$parentReturnTypeNode = new NullableType($parentReturnTypeNode);
}
// skip if type is already set
if ($this->nodeComparator->areNodesEqual($parentReturnTypeNode, $node->returnType)) {
return null;
}
if ($parentReturnType instanceof ThisType) {
return null;
}
// Add the docblock before changing the type
$this->addDocBlockReturn($node);
$node->returnType = $parentReturnTypeNode;
return $node;
}
/**
* @param \PhpParser\Node\UnionType|\PhpParser\Node\NullableType|\PhpParser\Node\Name|\PhpParser\Node\Identifier|\PhpParser\Node\ComplexType $returnTypeNode
*/
private function resolveDifferentAncestorReturnType(ClassMethod $classMethod, $returnTypeNode) : Type
{
$classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);
if (!$classReflection instanceof ClassReflection) {
return new MixedType();
}
if ($returnTypeNode instanceof UnionType) {
return new MixedType();
}
$bareReturnType = $returnTypeNode instanceof NullableType ? $returnTypeNode->type : $returnTypeNode;
$returnType = $this->staticTypeMapper->mapPhpParserNodePHPStanType($bareReturnType);
$methodName = $this->getName($classMethod);
/** @var ClassReflection[] $parentClassesAndInterfaces */
$parentClassesAndInterfaces = \array_merge($classReflection->getParents(), $classReflection->getInterfaces());
return $this->resolveMatchingReturnType($parentClassesAndInterfaces, $methodName, $classMethod, $returnType);
}
private function addDocBlockReturn(ClassMethod $classMethod) : void
{
$phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($classMethod);
// keep return type if already set one
if (!$phpDocInfo->getReturnType() instanceof MixedType) {
return;
}
/** @var Node $returnType */
$returnType = $classMethod->returnType;
$type = $this->staticTypeMapper->mapPhpParserNodePHPStanType($returnType);
$this->phpDocTypeChanger->changeReturnType($phpDocInfo, $type);
$this->returnTagRemover->removeReturnTagIfUseless($phpDocInfo, $classMethod);
}
/**
* @param ClassReflection[] $parentClassesAndInterfaces
*/
private function resolveMatchingReturnType(array $parentClassesAndInterfaces, string $methodName, ClassMethod $classMethod, Type $returnType) : Type
{
foreach ($parentClassesAndInterfaces as $parentClassAndInterface) {
$parentClassAndInterfaceHasMethod = $parentClassAndInterface->hasMethod($methodName);
if (!$parentClassAndInterfaceHasMethod) {
continue;
}
$classMethodScope = $classMethod->getAttribute(AttributeKey::SCOPE);
/** @var ClassMemberAccessAnswerer $classMethodScope */
$parameterMethodReflection = $parentClassAndInterface->getMethod($methodName, $classMethodScope);
if (!$parameterMethodReflection instanceof PhpMethodReflection) {
continue;
}
/** @var Type $parentReturnType */
$parentReturnType = $this->privatesAccessor->callPrivateMethod($parameterMethodReflection, 'getReturnType', []);
// skip "parent" reference if correct
if ($returnType instanceof ParentStaticType && $parentReturnType->accepts($returnType, \true)->yes()) {
continue;
}
if ($parentReturnType instanceof StaticType && $returnType->accepts($parentReturnType, \true)->yes()) {
continue;
}
if ($parentReturnType->equals($returnType)) {
continue;
}
// This is an ancestor class with a different return type
return $parentReturnType;
}
return new MixedType();
}
}