mirror of
https://github.com/rectorphp/rector.git
synced 2024-05-28 23:10:51 +00:00
28c719d1fb
8961d20f56
[DX] Localize multi instance checker and privates accessor from Symplify + bump to PHPStan 1.8.3 (#2883)
137 lines
4.6 KiB
PHP
137 lines
4.6 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Laravel\Rector\PropertyFetch;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Arg;
|
|
use PhpParser\Node\Expr;
|
|
use PhpParser\Node\Expr\Array_;
|
|
use PhpParser\Node\Expr\ClassConstFetch;
|
|
use PhpParser\Node\Expr\ConstFetch;
|
|
use PhpParser\Node\Expr\FuncCall;
|
|
use PhpParser\Node\Expr\MethodCall;
|
|
use PhpParser\Node\Expr\NullsafeMethodCall;
|
|
use PhpParser\Node\Expr\NullsafePropertyFetch;
|
|
use PhpParser\Node\Expr\PropertyFetch;
|
|
use PhpParser\Node\Scalar;
|
|
use Rector\Core\Contract\Rector\AllowEmptyConfigurableRectorInterface;
|
|
use Rector\Core\NodeAnalyzer\ArgsAnalyzer;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\Core\Util\MultiInstanceofChecker;
|
|
use Rector\Core\ValueObject\PhpVersion;
|
|
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
use RectorPrefix202209\Webmozart\Assert\Assert;
|
|
/**
|
|
* @changelog https://github.com/laravel/laravel/pull/5670
|
|
* @changelog https://github.com/laravel/framework/pull/38868
|
|
* @changelog https://wiki.php.net/rfc/nullsafe_operator
|
|
*
|
|
* @see \Rector\Laravel\Tests\Rector\PropertyFetch\OptionalToNullsafeOperatorRector\OptionalToNullsafeOperatorRectorTest
|
|
*/
|
|
final class OptionalToNullsafeOperatorRector extends AbstractRector implements MinPhpVersionInterface, AllowEmptyConfigurableRectorInterface
|
|
{
|
|
/**
|
|
* @var string
|
|
*/
|
|
public const EXCLUDE_METHODS = 'exclude_methods';
|
|
/**
|
|
* @var array<class-string<Expr>>
|
|
*/
|
|
private const SKIP_VALUE_TYPES = [ConstFetch::class, Scalar::class, Array_::class, ClassConstFetch::class];
|
|
/**
|
|
* @var string[]
|
|
*/
|
|
private $excludeMethods = [];
|
|
/**
|
|
* @var \Rector\Core\Util\MultiInstanceofChecker
|
|
*/
|
|
private $multiInstanceofChecker;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\Core\NodeAnalyzer\ArgsAnalyzer
|
|
*/
|
|
private $argsAnalyzer;
|
|
public function __construct(MultiInstanceofChecker $multiInstanceofChecker, ArgsAnalyzer $argsAnalyzer)
|
|
{
|
|
$this->multiInstanceofChecker = $multiInstanceofChecker;
|
|
$this->argsAnalyzer = $argsAnalyzer;
|
|
}
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Convert simple calls to optional helper to use the nullsafe operator', [new ConfiguredCodeSample(<<<'CODE_SAMPLE'
|
|
optional($user)->getKey();
|
|
optional($user)->id;
|
|
// macro methods
|
|
optional($user)->present()->getKey();
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
$user?->getKey();
|
|
$user?->id;
|
|
// macro methods
|
|
optional($user)->present()->getKey();
|
|
CODE_SAMPLE
|
|
, [self::EXCLUDE_METHODS => ['present']])]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [PropertyFetch::class, MethodCall::class];
|
|
}
|
|
/**
|
|
* @param MethodCall|PropertyFetch $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
if (!$node->var instanceof FuncCall) {
|
|
return null;
|
|
}
|
|
if (!$this->isName($node->var->name, 'optional')) {
|
|
return null;
|
|
}
|
|
// exclude macro methods
|
|
if ($node instanceof MethodCall && $this->isNames($node->name, $this->excludeMethods)) {
|
|
return null;
|
|
}
|
|
if (!$this->argsAnalyzer->isArgInstanceInArgsPosition($node->var->args, 0)) {
|
|
return null;
|
|
}
|
|
// skip if the second arg exists and not null
|
|
if ($this->hasCallback($node->var)) {
|
|
return null;
|
|
}
|
|
/** @var Arg $firstArg */
|
|
$firstArg = $node->var->args[0];
|
|
// skip if the first arg cannot be used as variable directly
|
|
if ($this->multiInstanceofChecker->isInstanceOf($firstArg->value, self::SKIP_VALUE_TYPES)) {
|
|
return null;
|
|
}
|
|
if ($node instanceof PropertyFetch) {
|
|
return new NullsafePropertyFetch($firstArg->value, $node->name);
|
|
}
|
|
return new NullsafeMethodCall($firstArg->value, $node->name, $node->args);
|
|
}
|
|
public function provideMinPhpVersion() : int
|
|
{
|
|
return PhpVersion::PHP_80;
|
|
}
|
|
/**
|
|
* @param mixed[] $configuration
|
|
*/
|
|
public function configure(array $configuration) : void
|
|
{
|
|
$excludeMethods = $configuration[self::EXCLUDE_METHODS] ?? $configuration;
|
|
Assert::isArray($excludeMethods);
|
|
Assert::allString($excludeMethods);
|
|
$this->excludeMethods = $excludeMethods;
|
|
}
|
|
private function hasCallback(FuncCall $funcCall) : bool
|
|
{
|
|
return isset($funcCall->args[1]) && $funcCall->args[1] instanceof Arg && !$this->valueResolver->isNull($funcCall->args[1]->value);
|
|
}
|
|
}
|