mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-07 20:00:50 +00:00
4be1f2aee7
* [DowngradePhp80] Allow Truthy with Ternary on DowngradeThrowExprRector * Trigger notification * update test fixture to trigger test * update test fixture to trigger test
161 lines
4.2 KiB
PHP
161 lines
4.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Rector\DowngradePhp80\Rector\Expression;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr;
|
|
use PhpParser\Node\Expr\Assign;
|
|
use PhpParser\Node\Expr\BinaryOp\Coalesce;
|
|
use PhpParser\Node\Expr\BooleanNot;
|
|
use PhpParser\Node\Expr\Isset_;
|
|
use PhpParser\Node\Expr\Ternary;
|
|
use PhpParser\Node\Expr\Throw_;
|
|
use PhpParser\Node\Stmt\Expression;
|
|
use PhpParser\Node\Stmt\If_;
|
|
use Rector\Core\NodeAnalyzer\CoalesceAnalyzer;
|
|
use Rector\Core\NodeManipulator\BinaryOpManipulator;
|
|
use Rector\Core\NodeManipulator\IfManipulator;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
|
|
/**
|
|
* @changelog https://wiki.php.net/rfc/throw_expression
|
|
*
|
|
* @see \Rector\Tests\DowngradePhp80\Rector\Expression\DowngradeThrowExprRector\DowngradeThrowExprRectorTest
|
|
*/
|
|
final class DowngradeThrowExprRector extends AbstractRector
|
|
{
|
|
public function __construct(
|
|
private IfManipulator $ifManipulator,
|
|
private CoalesceAnalyzer $coalesceAnalyzer,
|
|
private BinaryOpManipulator $binaryOpManipulator
|
|
) {
|
|
}
|
|
|
|
public function getRuleDefinition(): RuleDefinition
|
|
{
|
|
return new RuleDefinition('Downgrade throw as expr', [
|
|
new CodeSample(
|
|
<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
$id = $somethingNonexistent ?? throw new RuntimeException();
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
|
|
,
|
|
<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
if (!isset($somethingNonexistent)) {
|
|
throw new RuntimeException();
|
|
}
|
|
$id = $somethingNonexistent;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
),
|
|
]);
|
|
}
|
|
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes(): array
|
|
{
|
|
return [Expression::class];
|
|
}
|
|
|
|
/**
|
|
* @param Expression $node
|
|
*/
|
|
public function refactor(Node $node): ?Node
|
|
{
|
|
if ($node->expr instanceof Throw_) {
|
|
return null;
|
|
}
|
|
|
|
if ($node->expr instanceof Assign) {
|
|
return $this->processAssign($node, $node->expr);
|
|
}
|
|
|
|
return $node;
|
|
}
|
|
|
|
private function processAssign(Expression $expression, Assign $assign): If_ | Expression | null
|
|
{
|
|
if (! $this->hasThrowInAssignExpr($assign)) {
|
|
return null;
|
|
}
|
|
|
|
if ($assign->expr instanceof Coalesce) {
|
|
return $this->processCoalesce($assign, $assign->expr);
|
|
}
|
|
|
|
if ($assign->expr instanceof Throw_) {
|
|
return new Expression(($assign->expr));
|
|
}
|
|
|
|
if ($assign->expr instanceof Ternary) {
|
|
return $this->processTernary($assign, $assign->expr);
|
|
}
|
|
|
|
return $expression;
|
|
}
|
|
|
|
private function processTernary(Assign $assign, Ternary $ternary): ?If_
|
|
{
|
|
if (! $ternary->else instanceof Throw_) {
|
|
return null;
|
|
}
|
|
|
|
$inversedTernaryCond = $this->binaryOpManipulator->inverseNode($ternary->cond);
|
|
if (! $inversedTernaryCond instanceof Expr) {
|
|
return null;
|
|
}
|
|
|
|
$if = $this->ifManipulator->createIfExpr($inversedTernaryCond, new Expression($ternary->else));
|
|
$assign->expr = $ternary->if === null
|
|
? $ternary->cond
|
|
: $ternary->if;
|
|
|
|
$this->addNodeAfterNode(new Expression($assign), $if);
|
|
return $if;
|
|
}
|
|
|
|
private function processCoalesce(Assign $assign, Coalesce $coalesce): ?If_
|
|
{
|
|
if (! $coalesce->right instanceof Throw_) {
|
|
return null;
|
|
}
|
|
|
|
if (! $this->coalesceAnalyzer->hasIssetableLeft($coalesce)) {
|
|
return null;
|
|
}
|
|
|
|
$booleanNot = new BooleanNot(new Isset_([$coalesce->left]));
|
|
$assign->expr = $coalesce->left;
|
|
|
|
$if = $this->ifManipulator->createIfExpr($booleanNot, new Expression($coalesce->right));
|
|
|
|
$this->addNodeAfterNode(new Expression($assign), $if);
|
|
return $if;
|
|
}
|
|
|
|
private function hasThrowInAssignExpr(Assign $assign): bool
|
|
{
|
|
return (bool) $this->betterNodeFinder->findFirst(
|
|
$assign->expr,
|
|
fn (Node $node): bool => $node instanceof Throw_
|
|
);
|
|
}
|
|
}
|