mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-12 14:12:23 +00:00
68e1f45251
4d01db5c10
[DX] Improve direct return of Stmt arrays in Rector rules, remove NodesToAddCollector from AbstractRector (#2623)
143 lines
4.6 KiB
PHP
143 lines
4.6 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Nette\Rector\MethodCall;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\ArrayDimFetch;
|
|
use PhpParser\Node\Expr\Assign;
|
|
use PhpParser\Node\Expr\MethodCall;
|
|
use PhpParser\Node\Expr\New_;
|
|
use PhpParser\Node\Expr\Variable;
|
|
use PhpParser\Node\Name\FullyQualified;
|
|
use PhpParser\Node\Scalar\String_;
|
|
use PHPStan\Type\ObjectType;
|
|
use Rector\Core\Exception\ShouldNotHappenException;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
|
use Rector\PostRector\Collector\NodesToAddCollector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Nette\Tests\Rector\MethodCall\AddNextrasDatePickerToDateControlRector\AddNextrasDatePickerToDateControlRectorTest
|
|
*/
|
|
final class AddNextrasDatePickerToDateControlRector extends AbstractRector
|
|
{
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\PostRector\Collector\NodesToAddCollector
|
|
*/
|
|
private $nodesToAddCollector;
|
|
public function __construct(NodesToAddCollector $nodesToAddCollector)
|
|
{
|
|
$this->nodesToAddCollector = $nodesToAddCollector;
|
|
}
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Nextras/Form upgrade of addDatePicker method call to DateControl assign', [new CodeSample(<<<'CODE_SAMPLE'
|
|
use Nette\Application\UI\Form;
|
|
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
$form = new Form();
|
|
$form->addDatePicker('key', 'Label');
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
use Nette\Application\UI\Form;
|
|
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
$form = new Form();
|
|
$form['key'] = new \Nextras\FormComponents\Controls\DateControl('Label');
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [MethodCall::class];
|
|
}
|
|
/**
|
|
* @param MethodCall $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
// 1. chain call
|
|
if ($node->var instanceof MethodCall) {
|
|
if (!$this->isObjectType($node->var->var, new ObjectType('Nette\\Application\\UI\\Form'))) {
|
|
return null;
|
|
}
|
|
if (!$this->isName($node->var->name, 'addDatePicker')) {
|
|
return null;
|
|
}
|
|
$assign = $this->createAssign($node->var);
|
|
if (!$assign instanceof Node) {
|
|
return null;
|
|
}
|
|
$controlName = $this->resolveControlName($node->var);
|
|
$node->var = new Variable($controlName);
|
|
// this fixes printing indent
|
|
$node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
|
|
$this->nodesToAddCollector->addNodeBeforeNode($assign, $node);
|
|
return $node;
|
|
}
|
|
// 2. assign call
|
|
if (!$this->isObjectType($node->var, new ObjectType('Nette\\Application\\UI\\Form'))) {
|
|
return null;
|
|
}
|
|
if (!$this->isName($node->name, 'addDatePicker')) {
|
|
return null;
|
|
}
|
|
return $this->createAssign($node);
|
|
}
|
|
private function createAssign(MethodCall $methodCall) : ?Node
|
|
{
|
|
$key = $methodCall->args[0]->value;
|
|
if (!$key instanceof String_) {
|
|
return null;
|
|
}
|
|
$new = $this->createDateTimeControlNew($methodCall);
|
|
$parent = $methodCall->getAttribute(AttributeKey::PARENT_NODE);
|
|
if ($parent instanceof Assign) {
|
|
return $new;
|
|
}
|
|
$arrayDimFetch = new ArrayDimFetch($methodCall->var, $key);
|
|
$formAssign = new Assign($arrayDimFetch, $new);
|
|
if ($parent instanceof Node) {
|
|
$methodCalls = $this->betterNodeFinder->findInstanceOf($parent, MethodCall::class);
|
|
if (\count($methodCalls) > 1) {
|
|
$controlName = $this->resolveControlName($methodCall);
|
|
return new Assign(new Variable($controlName), $formAssign);
|
|
}
|
|
}
|
|
return $formAssign;
|
|
}
|
|
private function resolveControlName(MethodCall $methodCall) : string
|
|
{
|
|
$controlName = $methodCall->args[0]->value;
|
|
if (!$controlName instanceof String_) {
|
|
throw new ShouldNotHappenException();
|
|
}
|
|
return $controlName->value . 'DateControl';
|
|
}
|
|
private function createDateTimeControlNew(MethodCall $methodCall) : New_
|
|
{
|
|
$fullyQualified = new FullyQualified('Nextras\\FormComponents\\Controls\\DateControl');
|
|
$new = new New_($fullyQualified);
|
|
if (isset($methodCall->args[1])) {
|
|
$new->args[] = $methodCall->args[1];
|
|
}
|
|
return $new;
|
|
}
|
|
}
|