mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-28 21:53:31 +00:00
74a2d071eb
3da22b0231
[Php81] Skip ArrayDimFetch from ArrayObject in Assign var on ReadOnlyPropertyRector (#2363)
159 lines
6.0 KiB
PHP
159 lines
6.0 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Transform\Rector\Class_;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Name\FullyQualified;
|
|
use PhpParser\Node\Stmt\Class_;
|
|
use PHPStan\Reflection\ReflectionProvider;
|
|
use Rector\Core\Contract\Rector\AllowEmptyConfigurableRectorInterface;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\Core\ValueObject\MethodName;
|
|
use Rector\Core\ValueObject\PhpVersionFeature;
|
|
use Rector\FamilyTree\Reflection\FamilyRelationsAnalyzer;
|
|
use Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer;
|
|
use Rector\PhpAttribute\Printer\PhpAttributeGroupFactory;
|
|
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
use RectorPrefix20220526\Webmozart\Assert\Assert;
|
|
/**
|
|
* @changelog https://wiki.php.net/rfc/deprecate_dynamic_properties
|
|
*
|
|
* @see \Rector\Tests\Transform\Rector\Class_\AddAllowDynamicPropertiesAttributeRector\AddAllowDynamicPropertiesAttributeRectorTest
|
|
*/
|
|
final class AddAllowDynamicPropertiesAttributeRector extends \Rector\Core\Rector\AbstractRector implements \Rector\Core\Contract\Rector\AllowEmptyConfigurableRectorInterface, \Rector\VersionBonding\Contract\MinPhpVersionInterface
|
|
{
|
|
/**
|
|
* @var string
|
|
*/
|
|
private const ATTRIBUTE = 'AllowDynamicProperties';
|
|
/**
|
|
* @var array<array-key, string>
|
|
*/
|
|
private $transformOnNamespaces = [];
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\FamilyTree\Reflection\FamilyRelationsAnalyzer
|
|
*/
|
|
private $familyRelationsAnalyzer;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer
|
|
*/
|
|
private $phpAttributeAnalyzer;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\PhpAttribute\Printer\PhpAttributeGroupFactory
|
|
*/
|
|
private $phpAttributeGroupFactory;
|
|
/**
|
|
* @readonly
|
|
* @var \PHPStan\Reflection\ReflectionProvider
|
|
*/
|
|
private $reflectionProvider;
|
|
public function __construct(\Rector\FamilyTree\Reflection\FamilyRelationsAnalyzer $familyRelationsAnalyzer, \Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer $phpAttributeAnalyzer, \Rector\PhpAttribute\Printer\PhpAttributeGroupFactory $phpAttributeGroupFactory, \PHPStan\Reflection\ReflectionProvider $reflectionProvider)
|
|
{
|
|
$this->familyRelationsAnalyzer = $familyRelationsAnalyzer;
|
|
$this->phpAttributeAnalyzer = $phpAttributeAnalyzer;
|
|
$this->phpAttributeGroupFactory = $phpAttributeGroupFactory;
|
|
$this->reflectionProvider = $reflectionProvider;
|
|
}
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Add the `AllowDynamicProperties` attribute to all classes', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample(<<<'CODE_SAMPLE'
|
|
namespace Example\Domain;
|
|
|
|
class SomeObject {
|
|
public string $someProperty = 'hello world';
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
namespace Example\Domain;
|
|
|
|
#[AllowDynamicProperties]
|
|
class SomeObject {
|
|
public string $someProperty = 'hello world';
|
|
}
|
|
CODE_SAMPLE
|
|
, ['Example\\*'])]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Stmt\Class_::class];
|
|
}
|
|
public function configure(array $configuration) : void
|
|
{
|
|
$transformOnNamespaces = $configuration;
|
|
\RectorPrefix20220526\Webmozart\Assert\Assert::allString($transformOnNamespaces);
|
|
$this->transformOnNamespaces = $transformOnNamespaces;
|
|
}
|
|
/**
|
|
* @param Class_ $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
if ($this->shouldSkip($node)) {
|
|
return null;
|
|
}
|
|
return $this->addAllowDynamicPropertiesAttribute($node);
|
|
}
|
|
public function provideMinPhpVersion() : int
|
|
{
|
|
return \Rector\Core\ValueObject\PhpVersionFeature::DEPRECATE_DYNAMIC_PROPERTIES;
|
|
}
|
|
private function isDescendantOfStdclass(\PhpParser\Node\Stmt\Class_ $class) : bool
|
|
{
|
|
if (!$class->extends instanceof \PhpParser\Node\Name\FullyQualified) {
|
|
return \false;
|
|
}
|
|
$ancestorClassNames = $this->familyRelationsAnalyzer->getClassLikeAncestorNames($class);
|
|
return \in_array('stdClass', $ancestorClassNames, \true);
|
|
}
|
|
private function hasNeededAttributeAlready(\PhpParser\Node\Stmt\Class_ $class) : bool
|
|
{
|
|
$nodeHasAttribute = $this->phpAttributeAnalyzer->hasPhpAttribute($class, self::ATTRIBUTE);
|
|
if ($nodeHasAttribute) {
|
|
return \true;
|
|
}
|
|
if (!$class->extends instanceof \PhpParser\Node\Name\FullyQualified) {
|
|
return \false;
|
|
}
|
|
return $this->phpAttributeAnalyzer->hasInheritedPhpAttribute($class, self::ATTRIBUTE);
|
|
}
|
|
private function addAllowDynamicPropertiesAttribute(\PhpParser\Node\Stmt\Class_ $class) : \PhpParser\Node\Stmt\Class_
|
|
{
|
|
$attributeGroup = $this->phpAttributeGroupFactory->createFromClass(self::ATTRIBUTE);
|
|
$class->attrGroups[] = $attributeGroup;
|
|
return $class;
|
|
}
|
|
private function shouldSkip(\PhpParser\Node\Stmt\Class_ $class) : bool
|
|
{
|
|
if ($this->transformOnNamespaces !== []) {
|
|
$className = (string) $this->nodeNameResolver->getName($class);
|
|
foreach ($this->transformOnNamespaces as $transformOnNamespace) {
|
|
if (!$this->nodeNameResolver->isStringName($className, $transformOnNamespace)) {
|
|
return \true;
|
|
}
|
|
}
|
|
}
|
|
if ($this->isDescendantOfStdclass($class)) {
|
|
return \true;
|
|
}
|
|
if ($this->hasNeededAttributeAlready($class)) {
|
|
return \true;
|
|
}
|
|
return $this->hasMagicSetMethod($class);
|
|
}
|
|
private function hasMagicSetMethod(\PhpParser\Node\Stmt\Class_ $class) : bool
|
|
{
|
|
$className = (string) $this->getName($class);
|
|
$classReflection = $this->reflectionProvider->getClass($className);
|
|
return $classReflection->hasMethod(\Rector\Core\ValueObject\MethodName::__SET);
|
|
}
|
|
}
|