mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-25 20:32:35 +00:00
* Add failing test fixture for RemoveUnusedVariableInCatchRector # Failing Test for RemoveUnusedVariableInCatchRector Based on https://getrector.org/demo/194e0c75-cb30-4f02-a0de-70d32fbe152c * Closes #6213 Co-authored-by: Ruud Kamphuis <ruudk@users.noreply.github.com>
104 lines
2.4 KiB
PHP
104 lines
2.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Rector\Php80\Rector\Catch_;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\Variable;
|
|
use PhpParser\Node\Stmt\Catch_;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
|
|
/**
|
|
* @changelog https://wiki.php.net/rfc/non-capturing_catches
|
|
*
|
|
* @see \Rector\Tests\Php80\Rector\Catch_\RemoveUnusedVariableInCatchRector\RemoveUnusedVariableInCatchRectorTest
|
|
*/
|
|
final class RemoveUnusedVariableInCatchRector extends AbstractRector
|
|
{
|
|
public function getRuleDefinition(): RuleDefinition
|
|
{
|
|
return new RuleDefinition('Remove unused variable in catch()', [
|
|
new CodeSample(
|
|
<<<'CODE_SAMPLE'
|
|
final class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
try {
|
|
} catch (Throwable $notUsedThrowable) {
|
|
}
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
,
|
|
<<<'CODE_SAMPLE'
|
|
final class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
try {
|
|
} catch (Throwable) {
|
|
}
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
),
|
|
]);
|
|
}
|
|
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes(): array
|
|
{
|
|
return [Catch_::class];
|
|
}
|
|
|
|
/**
|
|
* @param Catch_ $node
|
|
*/
|
|
public function refactor(Node $node): ?Node
|
|
{
|
|
$caughtVar = $node->var;
|
|
if (! $caughtVar instanceof Variable) {
|
|
return null;
|
|
}
|
|
|
|
if ($this->isVariableUsedInStmts($node->stmts, $caughtVar)) {
|
|
return null;
|
|
}
|
|
|
|
if ($this->isVariableUsedNext($node, $caughtVar)) {
|
|
return null;
|
|
}
|
|
|
|
$node->var = null;
|
|
|
|
return $node;
|
|
}
|
|
|
|
/**
|
|
* @param Node[] $nodes
|
|
*/
|
|
private function isVariableUsedInStmts(array $nodes, Variable $variable): bool
|
|
{
|
|
return (bool) $this->betterNodeFinder->findFirst($nodes, function (Node $node) use ($variable): bool {
|
|
if (! $node instanceof Variable) {
|
|
return false;
|
|
}
|
|
|
|
return $this->nodeComparator->areNodesEqual($node, $variable);
|
|
});
|
|
}
|
|
|
|
private function isVariableUsedNext(Catch_ $catch, Variable $variable): bool
|
|
{
|
|
return (bool) $this->betterNodeFinder->findFirstNext($catch, function (Node $node) use ($variable): bool {
|
|
return $this->nodeComparator->areNodesEqual($node, $variable);
|
|
});
|
|
}
|
|
}
|