rector/rules/CodeQuality/Rector/FuncCall/SetTypeToCastRector.php
2021-04-10 18:47:17 +00:00

130 lines
3.3 KiB
PHP

<?php
declare(strict_types=1);
namespace Rector\CodeQuality\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\Cast;
use PhpParser\Node\Expr\Cast\Array_;
use PhpParser\Node\Expr\Cast\Bool_;
use PhpParser\Node\Expr\Cast\Double;
use PhpParser\Node\Expr\Cast\Int_;
use PhpParser\Node\Expr\Cast\Object_;
use PhpParser\Node\Expr\Cast\String_;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Stmt\Expression;
use Rector\Core\Rector\AbstractRector;
use Rector\Core\Util\StaticNodeInstanceOf;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://stackoverflow.com/questions/5577003/using-settype-in-php-instead-of-typecasting-using-brackets-what-is-the-differen/5577068#5577068
*
* @see \Rector\Tests\CodeQuality\Rector\FuncCall\SetTypeToCastRector\SetTypeToCastRectorTest
*/
final class SetTypeToCastRector extends AbstractRector
{
/**
* @var array<string, class-string<Cast>>
*/
private const TYPE_TO_CAST = [
'array' => Array_::class,
'bool' => Bool_::class,
'boolean' => Bool_::class,
'double' => Double::class,
'float' => Double::class,
'int' => Int_::class,
'integer' => Int_::class,
'object' => Object_::class,
'string' => String_::class,
];
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Changes settype() to (type) where possible', [
new CodeSample(
<<<'CODE_SAMPLE'
class SomeClass
{
public function run($foo)
{
settype($foo, 'string');
return settype($foo, 'integer');
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class SomeClass
{
public function run(array $items)
{
$foo = (string) $foo;
return (int) $foo;
}
}
CODE_SAMPLE
),
]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
*/
public function refactor(Node $node): ?Node
{
if (! $this->isName($node, 'settype')) {
return null;
}
$typeNode = $this->valueResolver->getValue($node->args[1]->value);
if ($typeNode === null) {
return null;
}
$typeNode = strtolower($typeNode);
$varNode = $node->args[0]->value;
$parentNode = $node->getAttribute(AttributeKey::PARENT_NODE);
// result of function or probably used
if (StaticNodeInstanceOf::isOneOf($parentNode, [Expr::class, Arg::class])) {
return null;
}
if (isset(self::TYPE_TO_CAST[$typeNode])) {
$castClass = self::TYPE_TO_CAST[$typeNode];
$castNode = new $castClass($varNode);
if ($parentNode instanceof Expression) {
// bare expression? → assign
return new Assign($varNode, $castNode);
}
return $castNode;
}
if ($typeNode === 'null') {
return new Assign($varNode, $this->nodeFactory->createNull());
}
return $node;
}
}