mirror of https://github.com/rectorphp/rector.git
96 lines
2.7 KiB
PHP
96 lines
2.7 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\CodeQuality\Rector\Identical;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\BinaryOp\Identical;
|
|
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
|
|
use PhpParser\Node\Expr\BooleanNot;
|
|
use Rector\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @changelog https://3v4l.org/GoEPq
|
|
* @see \Rector\Tests\CodeQuality\Rector\Identical\BooleanNotIdenticalToNotIdenticalRector\BooleanNotIdenticalToNotIdenticalRectorTest
|
|
*/
|
|
final class BooleanNotIdenticalToNotIdenticalRector extends AbstractRector
|
|
{
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Negated identical boolean compare to not identical compare (does not apply to non-bool values)', [new CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
$a = true;
|
|
$b = false;
|
|
|
|
var_dump(! $a === $b); // true
|
|
var_dump(! ($a === $b)); // true
|
|
var_dump($a !== $b); // true
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
$a = true;
|
|
$b = false;
|
|
|
|
var_dump($a !== $b); // true
|
|
var_dump($a !== $b); // true
|
|
var_dump($a !== $b); // true
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [Identical::class, BooleanNot::class];
|
|
}
|
|
/**
|
|
* @param Identical|BooleanNot $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
if ($node instanceof Identical) {
|
|
return $this->processIdentical($node);
|
|
}
|
|
if ($node->expr instanceof Identical) {
|
|
$identical = $node->expr;
|
|
$leftType = $this->getType($identical->left);
|
|
if (!$leftType->isBoolean()->yes()) {
|
|
return null;
|
|
}
|
|
$rightType = $this->getType($identical->right);
|
|
if (!$rightType->isBoolean()->yes()) {
|
|
return null;
|
|
}
|
|
return new NotIdentical($identical->left, $identical->right);
|
|
}
|
|
return null;
|
|
}
|
|
private function processIdentical(Identical $identical) : ?NotIdentical
|
|
{
|
|
$leftType = $this->getType($identical->left);
|
|
if (!$leftType->isBoolean()->yes()) {
|
|
return null;
|
|
}
|
|
$rightType = $this->getType($identical->right);
|
|
if (!$rightType->isBoolean()->yes()) {
|
|
return null;
|
|
}
|
|
if ($identical->left instanceof BooleanNot) {
|
|
return new NotIdentical($identical->left->expr, $identical->right);
|
|
}
|
|
return null;
|
|
}
|
|
}
|