mirror of https://github.com/rectorphp/rector.git
99 lines
2.6 KiB
PHP
99 lines
2.6 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\CodeQuality\Rector\If_;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Stmt\Else_;
|
|
use PhpParser\Node\Stmt\ElseIf_;
|
|
use PhpParser\Node\Stmt\If_;
|
|
use PhpParser\Node\Stmt\Nop;
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
|
use Rector\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Tests\CodeQuality\Rector\If_\ShortenElseIfRector\ShortenElseIfRectorTest
|
|
*/
|
|
final class ShortenElseIfRector extends AbstractRector
|
|
{
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Shortens else/if to elseif', [new CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
if ($cond1) {
|
|
return $action1;
|
|
} else {
|
|
if ($cond2) {
|
|
return $action2;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
if ($cond1) {
|
|
return $action1;
|
|
} elseif ($cond2) {
|
|
return $action2;
|
|
}
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [If_::class];
|
|
}
|
|
/**
|
|
* @param If_ $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
return $this->shortenElseIf($node);
|
|
}
|
|
private function shortenElseIf(If_ $node) : ?If_
|
|
{
|
|
if (!$node->else instanceof Else_) {
|
|
return null;
|
|
}
|
|
$else = $node->else;
|
|
if (\count($else->stmts) !== 1) {
|
|
return null;
|
|
}
|
|
$if = $else->stmts[0];
|
|
if (!$if instanceof If_) {
|
|
return null;
|
|
}
|
|
// Try to shorten the nested if before transforming it to elseif
|
|
$refactored = $this->shortenElseIf($if);
|
|
if ($refactored instanceof If_) {
|
|
$if = $refactored;
|
|
}
|
|
if ($if->stmts === []) {
|
|
$nop = new Nop();
|
|
$nop->setAttribute(AttributeKey::COMMENTS, $if->getComments());
|
|
$if->stmts[] = $nop;
|
|
} else {
|
|
$currentStmt = \current($if->stmts);
|
|
$mergedComments = \array_merge($if->getComments(), $currentStmt->getComments());
|
|
$currentStmt->setAttribute(AttributeKey::COMMENTS, $mergedComments);
|
|
}
|
|
$node->elseifs[] = new ElseIf_($if->cond, $if->stmts);
|
|
$node->else = $if->else;
|
|
$node->elseifs = \array_merge($node->elseifs, $if->elseifs);
|
|
return $node;
|
|
}
|
|
}
|