mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-17 16:42:25 +00:00
a2178d82dc
9e9a314b23
[NodeTypeResolver] Remove unused AttributeKey::INSIDE_ARRAY_ITEM on ContextNodeVisitor (#4496)
119 lines
5.0 KiB
PHP
119 lines
5.0 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\PHPUnit\CodeQuality\Rector\MethodCall;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Arg;
|
|
use PhpParser\Node\Expr\FuncCall;
|
|
use PhpParser\Node\Expr\MethodCall;
|
|
use PhpParser\Node\Expr\StaticCall;
|
|
use PhpParser\Node\Identifier;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
|
|
use Rector\PHPUnit\ValueObject\FunctionNameWithAssertMethods;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertCompareToSpecificMethodRector\AssertCompareToSpecificMethodRectorTest
|
|
*/
|
|
final class AssertCompareToSpecificMethodRector extends AbstractRector
|
|
{
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer
|
|
*/
|
|
private $testsNodeAnalyzer;
|
|
/**
|
|
* @var string
|
|
*/
|
|
private const ASSERT_COUNT = 'assertCount';
|
|
/**
|
|
* @var string
|
|
*/
|
|
private const ASSERT_NOT_COUNT = 'assertNotCount';
|
|
/**
|
|
* @var FunctionNameWithAssertMethods[]
|
|
*/
|
|
private $functionNamesWithAssertMethods = [];
|
|
public function __construct(TestsNodeAnalyzer $testsNodeAnalyzer)
|
|
{
|
|
$this->testsNodeAnalyzer = $testsNodeAnalyzer;
|
|
$this->functionNamesWithAssertMethods = [new FunctionNameWithAssertMethods('count', self::ASSERT_COUNT, self::ASSERT_NOT_COUNT), new FunctionNameWithAssertMethods('sizeof', self::ASSERT_COUNT, self::ASSERT_NOT_COUNT), new FunctionNameWithAssertMethods('iterator_count', self::ASSERT_COUNT, self::ASSERT_NOT_COUNT), new FunctionNameWithAssertMethods('gettype', 'assertInternalType', 'assertNotInternalType'), new FunctionNameWithAssertMethods('get_class', 'assertInstanceOf', 'assertNotInstanceOf')];
|
|
}
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Turns vague php-only method in PHPUnit TestCase to more specific', [new CodeSample('$this->assertSame(10, count($anything), "message");', '$this->assertCount(10, $anything, "message");'), new CodeSample('$this->assertNotEquals(get_class($value), SomeInstance::class);', '$this->assertNotInstanceOf(SomeInstance::class, $value);')]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [MethodCall::class, StaticCall::class];
|
|
}
|
|
/**
|
|
* @param MethodCall|StaticCall $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
if (!$this->testsNodeAnalyzer->isPHPUnitMethodCallNames($node, ['assertSame', 'assertNotSame', 'assertEquals', 'assertNotEquals'])) {
|
|
return null;
|
|
}
|
|
if ($node->isFirstClassCallable()) {
|
|
return null;
|
|
}
|
|
// we need 2 args
|
|
if (!isset($node->args[1])) {
|
|
return null;
|
|
}
|
|
$firstArgument = $node->getArgs()[0];
|
|
$secondArgument = $node->getArgs()[1];
|
|
$firstArgumentValue = $firstArgument->value;
|
|
$secondArgumentValue = $secondArgument->value;
|
|
if ($secondArgumentValue instanceof FuncCall) {
|
|
return $this->processFuncCallArgumentValue($node, $secondArgumentValue, $firstArgument);
|
|
}
|
|
if ($firstArgumentValue instanceof FuncCall) {
|
|
return $this->processFuncCallArgumentValue($node, $firstArgumentValue, $secondArgument);
|
|
}
|
|
return null;
|
|
}
|
|
/**
|
|
* @return MethodCall|StaticCall|null
|
|
* @param \PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall $node
|
|
*/
|
|
private function processFuncCallArgumentValue($node, FuncCall $funcCall, Arg $requiredArg) : ?Node
|
|
{
|
|
foreach ($this->functionNamesWithAssertMethods as $functionNameWithAssertMethod) {
|
|
if (!$this->isName($funcCall, $functionNameWithAssertMethod->getFunctionName())) {
|
|
continue;
|
|
}
|
|
$this->renameMethod($node, $functionNameWithAssertMethod);
|
|
$this->moveFunctionArgumentsUp($node, $funcCall, $requiredArg);
|
|
return $node;
|
|
}
|
|
return null;
|
|
}
|
|
/**
|
|
* @param \PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall $node
|
|
*/
|
|
private function renameMethod($node, FunctionNameWithAssertMethods $functionNameWithAssertMethods) : void
|
|
{
|
|
if ($this->isNames($node->name, ['assertSame', 'assertEquals'])) {
|
|
$node->name = new Identifier($functionNameWithAssertMethods->getAssetMethodName());
|
|
} elseif ($this->isNames($node->name, ['assertNotSame', 'assertNotEquals'])) {
|
|
$node->name = new Identifier($functionNameWithAssertMethods->getNotAssertMethodName());
|
|
}
|
|
}
|
|
/**
|
|
* Handles custom error messages to not be overwrite by function with multiple args.
|
|
* @param \PhpParser\Node\Expr\StaticCall|\PhpParser\Node\Expr\MethodCall $node
|
|
*/
|
|
private function moveFunctionArgumentsUp($node, FuncCall $funcCall, Arg $requiredArg) : void
|
|
{
|
|
$node->args[1] = $funcCall->getArgs()[0];
|
|
$node->args[0] = $requiredArg;
|
|
}
|
|
}
|