rector/vendor/rector/rector-phpunit/rules/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector.php
Tomas Votruba a2178d82dc Updated Rector to commit 9e9a314b23fa9f217c236412591c4cb9ad94edf5
9e9a314b23 [NodeTypeResolver] Remove unused AttributeKey::INSIDE_ARRAY_ITEM on ContextNodeVisitor (#4496)
2023-07-12 22:16:31 +00:00

125 lines
5.4 KiB
PHP

<?php
declare (strict_types=1);
namespace Rector\PHPUnit\CodeQuality\Rector\MethodCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\BinaryOp;
use PhpParser\Node\Expr\BinaryOp\Equal;
use PhpParser\Node\Expr\BinaryOp\Greater;
use PhpParser\Node\Expr\BinaryOp\GreaterOrEqual;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BinaryOp\NotEqual;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PhpParser\Node\Expr\BinaryOp\Smaller;
use PhpParser\Node\Expr\BinaryOp\SmallerOrEqual;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PHPStan\Type\Constant\ConstantArrayType;
use PHPStan\Type\ConstantScalarType;
use Rector\Core\Rector\AbstractRector;
use Rector\PHPUnit\NodeAnalyzer\IdentifierManipulator;
use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
use Rector\PHPUnit\ValueObject\BinaryOpWithAssertMethod;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\AssertComparisonToSpecificMethodRectorTest
*/
final class AssertComparisonToSpecificMethodRector extends AbstractRector
{
/**
* @readonly
* @var \Rector\PHPUnit\NodeAnalyzer\IdentifierManipulator
*/
private $identifierManipulator;
/**
* @readonly
* @var \Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer
*/
private $testsNodeAnalyzer;
/**
* @var BinaryOpWithAssertMethod[]
*/
private $binaryOpWithAssertMethods = [];
public function __construct(IdentifierManipulator $identifierManipulator, TestsNodeAnalyzer $testsNodeAnalyzer)
{
$this->identifierManipulator = $identifierManipulator;
$this->testsNodeAnalyzer = $testsNodeAnalyzer;
$this->binaryOpWithAssertMethods = [new BinaryOpWithAssertMethod(Identical::class, 'assertSame', 'assertNotSame'), new BinaryOpWithAssertMethod(NotIdentical::class, 'assertNotSame', 'assertSame'), new BinaryOpWithAssertMethod(Equal::class, 'assertEquals', 'assertNotEquals'), new BinaryOpWithAssertMethod(NotEqual::class, 'assertNotEquals', 'assertEquals'), new BinaryOpWithAssertMethod(Greater::class, 'assertGreaterThan', 'assertLessThan'), new BinaryOpWithAssertMethod(Smaller::class, 'assertLessThan', 'assertGreaterThan'), new BinaryOpWithAssertMethod(GreaterOrEqual::class, 'assertGreaterThanOrEqual', 'assertLessThanOrEqual'), new BinaryOpWithAssertMethod(SmallerOrEqual::class, 'assertLessThanOrEqual', 'assertGreaterThanOrEqual')];
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Turns comparison operations to their method name alternatives in PHPUnit TestCase', [new CodeSample('$this->assertTrue($foo === $bar, "message");', '$this->assertSame($bar, $foo, "message");'), new CodeSample('$this->assertFalse($foo >= $bar, "message");', '$this->assertLessThanOrEqual($bar, $foo, "message");')]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [MethodCall::class, StaticCall::class];
}
/**
* @param MethodCall|StaticCall $node
*/
public function refactor(Node $node) : ?Node
{
if (!$this->testsNodeAnalyzer->isPHPUnitMethodCallNames($node, ['assertTrue', 'assertFalse'])) {
return null;
}
if ($node->isFirstClassCallable()) {
return null;
}
$firstArgumentValue = $node->getArgs()[0]->value;
if (!$firstArgumentValue instanceof BinaryOp) {
return null;
}
return $this->processCallWithBinaryOp($node, $firstArgumentValue);
}
/**
* @param \PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall $node
*/
private function processCallWithBinaryOp($node, BinaryOp $binaryOp) : ?Node
{
$binaryOpClass = \get_class($binaryOp);
foreach ($this->binaryOpWithAssertMethods as $binaryOpWithAssertMethod) {
if ($binaryOpClass !== $binaryOpWithAssertMethod->getBinaryOpClass()) {
continue;
}
$this->identifierManipulator->renameNodeWithMap($node, ['assertTrue' => $binaryOpWithAssertMethod->getAssetMethodName(), 'assertFalse' => $binaryOpWithAssertMethod->getNotAssertMethodName()]);
$this->changeArgumentsOrder($node);
return $node;
}
return null;
}
/**
* @param \PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall $node
*/
private function changeArgumentsOrder($node) : void
{
$oldArguments = $node->getArgs();
/** @var BinaryOp $expression */
$expression = $oldArguments[0]->value;
if ($this->isConstantValue($expression->left)) {
$firstArgument = new Arg($expression->left);
$secondArgument = new Arg($expression->right);
} else {
$firstArgument = new Arg($expression->right);
$secondArgument = new Arg($expression->left);
}
unset($oldArguments[0]);
$newArgs = [$firstArgument, $secondArgument];
$node->args = $this->appendArgs($newArgs, $oldArguments);
}
private function isConstantValue(Expr $expr) : bool
{
$staticType = $this->nodeTypeResolver->getType($expr);
if ($staticType instanceof ConstantScalarType) {
return \true;
}
return $staticType instanceof ConstantArrayType;
}
}