rector/vendor/rector/rector-phpunit/rules/CodeQuality/Rector/MethodCall/RemoveExpectAnyFromMockRector.php
Tomas Votruba a2178d82dc Updated Rector to commit 9e9a314b23fa9f217c236412591c4cb9ad94edf5
9e9a314b23 [NodeTypeResolver] Remove unused AttributeKey::INSIDE_ARRAY_ITEM on ContextNodeVisitor (#4496)
2023-07-12 22:16:31 +00:00

100 lines
2.8 KiB
PHP

<?php
declare (strict_types=1);
namespace Rector\PHPUnit\CodeQuality\Rector\MethodCall;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\MethodCall;
use Rector\Core\Rector\AbstractRector;
use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://github.com/symfony/symfony/pull/30813/files#r270879504
* @see \Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\RemoveExpectAnyFromMockRector\RemoveExpectAnyFromMockRectorTest
*/
final class RemoveExpectAnyFromMockRector extends AbstractRector
{
/**
* @readonly
* @var \Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer
*/
private $testsNodeAnalyzer;
public function __construct(TestsNodeAnalyzer $testsNodeAnalyzer)
{
$this->testsNodeAnalyzer = $testsNodeAnalyzer;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Remove `expect($this->any())` from mocks as it has no added value', [new CodeSample(<<<'CODE_SAMPLE'
use PHPUnit\Framework\TestCase;
class SomeClass extends TestCase
{
public function test()
{
$translator = $this->getMock('SomeClass');
$translator->expects($this->any())
->method('trans')
->willReturn('translated max {{ max }}!');
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
use PHPUnit\Framework\TestCase;
class SomeClass extends TestCase
{
public function test()
{
$translator = $this->getMock('SomeClass');
$translator->method('trans')
->willReturn('translated max {{ max }}!');
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [MethodCall::class];
}
/**
* @param MethodCall $node
*/
public function refactor(Node $node) : ?Node
{
if (!$this->testsNodeAnalyzer->isInTestClass($node)) {
return null;
}
if (!$this->isName($node->name, 'expects')) {
return null;
}
if ($node->isFirstClassCallable()) {
return null;
}
if (\count($node->args) !== 1) {
return null;
}
$onlyArgument = $node->getArgs()[0]->value;
if (!$this->isMethodCallOnVariableNamed($onlyArgument, 'this', 'any')) {
return null;
}
return $node->var;
}
private function isMethodCallOnVariableNamed(Expr $expr, string $variableName, string $methodName) : bool
{
if (!$expr instanceof MethodCall) {
return \false;
}
if (!$this->isName($expr->var, $variableName)) {
return \false;
}
return $this->isName($expr->name, $methodName);
}
}