mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-01 17:00:51 +00:00
aa0465d388
975fdf113f
[DX] Add StmtsAwareInterface to catch node by type (#2269)
134 lines
4.4 KiB
PHP
134 lines
4.4 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\DeadCode\Rector\Stmt;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\Exit_;
|
|
use PhpParser\Node\Stmt;
|
|
use PhpParser\Node\Stmt\Break_;
|
|
use PhpParser\Node\Stmt\Continue_;
|
|
use PhpParser\Node\Stmt\Expression;
|
|
use PhpParser\Node\Stmt\Finally_;
|
|
use PhpParser\Node\Stmt\Goto_;
|
|
use PhpParser\Node\Stmt\InlineHTML;
|
|
use PhpParser\Node\Stmt\Label;
|
|
use PhpParser\Node\Stmt\Nop;
|
|
use PhpParser\Node\Stmt\Return_;
|
|
use PhpParser\Node\Stmt\Throw_;
|
|
use PhpParser\Node\Stmt\TryCatch;
|
|
use Rector\Core\Contract\PhpParser\Node\StmtsAwareInterface;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @changelog https://github.com/phpstan/phpstan/blob/83078fe308a383c618b8c1caec299e5765d9ac82/src/Node/UnreachableStatementNode.php
|
|
*
|
|
* @see \Rector\Tests\DeadCode\Rector\Stmt\RemoveUnreachableStatementRector\RemoveUnreachableStatementRectorTest
|
|
*/
|
|
final class RemoveUnreachableStatementRector extends \Rector\Core\Rector\AbstractRector
|
|
{
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Remove unreachable statements', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
return 5;
|
|
|
|
$removeMe = 10;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
return 5;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\Rector\Core\Contract\PhpParser\Node\StmtsAwareInterface::class];
|
|
}
|
|
/**
|
|
* @param StmtsAwareInterface $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
if ($node->stmts === null) {
|
|
return null;
|
|
}
|
|
$originalStmts = $node->stmts;
|
|
$cleanedStmts = $this->processCleanUpUnreachabelStmts($node->stmts);
|
|
if ($cleanedStmts === $originalStmts) {
|
|
return null;
|
|
}
|
|
$node->stmts = $cleanedStmts;
|
|
return $node;
|
|
}
|
|
/**
|
|
* @param Stmt[] $stmts
|
|
* @return Stmt[]
|
|
*/
|
|
private function processCleanUpUnreachabelStmts(array $stmts) : array
|
|
{
|
|
foreach ($stmts as $key => $stmt) {
|
|
if (!isset($stmts[$key - 1])) {
|
|
continue;
|
|
}
|
|
if ($stmt instanceof \PhpParser\Node\Stmt\Nop) {
|
|
continue;
|
|
}
|
|
$previousStmt = $stmts[$key - 1];
|
|
if ($this->shouldRemove($previousStmt, $stmt)) {
|
|
\array_splice($stmts, $key);
|
|
return $stmts;
|
|
}
|
|
}
|
|
return $stmts;
|
|
}
|
|
private function shouldRemove(\PhpParser\Node\Stmt $previousStmt, \PhpParser\Node\Stmt $currentStmt) : bool
|
|
{
|
|
if ($currentStmt instanceof \PhpParser\Node\Stmt\InlineHTML) {
|
|
return \false;
|
|
}
|
|
if ($previousStmt instanceof \PhpParser\Node\Stmt\Throw_) {
|
|
return \true;
|
|
}
|
|
if ($previousStmt instanceof \PhpParser\Node\Stmt\Expression && $previousStmt->expr instanceof \PhpParser\Node\Expr\Exit_) {
|
|
return \true;
|
|
}
|
|
if ($previousStmt instanceof \PhpParser\Node\Stmt\Goto_ && $currentStmt instanceof \PhpParser\Node\Stmt\Label) {
|
|
return \false;
|
|
}
|
|
if (\in_array(\get_class($previousStmt), [\PhpParser\Node\Stmt\Return_::class, \PhpParser\Node\Stmt\Break_::class, \PhpParser\Node\Stmt\Continue_::class, \PhpParser\Node\Stmt\Goto_::class], \true)) {
|
|
return \true;
|
|
}
|
|
if (!$previousStmt instanceof \PhpParser\Node\Stmt\TryCatch) {
|
|
return \false;
|
|
}
|
|
$isUnreachable = $currentStmt->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::IS_UNREACHABLE);
|
|
return $isUnreachable === \true && $previousStmt->finally instanceof \PhpParser\Node\Stmt\Finally_ && $this->cleanNop($previousStmt->finally->stmts) !== [];
|
|
}
|
|
/**
|
|
* @param Stmt[] $stmts
|
|
* @return Stmt[]
|
|
*/
|
|
private function cleanNop(array $stmts) : array
|
|
{
|
|
return \array_filter($stmts, function (\PhpParser\Node\Stmt $stmt) : bool {
|
|
return !$stmt instanceof \PhpParser\Node\Stmt\Nop;
|
|
});
|
|
}
|
|
}
|