mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-05 02:40:50 +00:00
8b20f236c0
2ec55701f2
[Performance] Fix filter cache on SkippedClassResolver (#5460)
93 lines
2.4 KiB
PHP
93 lines
2.4 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\CodeQuality\Rector\Switch_;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr;
|
|
use PhpParser\Node\Expr\BinaryOp\Identical;
|
|
use PhpParser\Node\Stmt;
|
|
use PhpParser\Node\Stmt\Break_;
|
|
use PhpParser\Node\Stmt\If_;
|
|
use PhpParser\Node\Stmt\Switch_;
|
|
use Rector\Rector\AbstractRector;
|
|
use Rector\Renaming\NodeManipulator\SwitchManipulator;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Tests\CodeQuality\Rector\Switch_\SingularSwitchToIfRector\SingularSwitchToIfRectorTest
|
|
*/
|
|
final class SingularSwitchToIfRector extends AbstractRector
|
|
{
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\Renaming\NodeManipulator\SwitchManipulator
|
|
*/
|
|
private $switchManipulator;
|
|
public function __construct(SwitchManipulator $switchManipulator)
|
|
{
|
|
$this->switchManipulator = $switchManipulator;
|
|
}
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Change switch with only 1 check to if', [new CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeObject
|
|
{
|
|
public function run($value)
|
|
{
|
|
$result = 1;
|
|
switch ($value) {
|
|
case 100:
|
|
$result = 1000;
|
|
}
|
|
|
|
return $result;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeObject
|
|
{
|
|
public function run($value)
|
|
{
|
|
$result = 1;
|
|
if ($value === 100) {
|
|
$result = 1000;
|
|
}
|
|
|
|
return $result;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [Switch_::class];
|
|
}
|
|
/**
|
|
* @param Switch_ $node
|
|
* @return Node\Stmt[]|If_|null
|
|
*/
|
|
public function refactor(Node $node)
|
|
{
|
|
if (\count($node->cases) !== 1) {
|
|
return null;
|
|
}
|
|
$onlyCase = $node->cases[0];
|
|
// only default → basically unwrap
|
|
if (!$onlyCase->cond instanceof Expr) {
|
|
// remove default clause because it cause syntax error
|
|
return \array_filter($onlyCase->stmts, static function (Stmt $stmt) : bool {
|
|
return !$stmt instanceof Break_;
|
|
});
|
|
}
|
|
$if = new If_(new Identical($node->cond, $onlyCase->cond));
|
|
$if->stmts = $this->switchManipulator->removeBreakNodes($onlyCase->stmts);
|
|
return $if;
|
|
}
|
|
}
|