rector/rules/Php80/NodeManipulator/ResourceReturnToObject.php
Tomas Votruba c726969380 Updated Rector to commit fc10fce13d
fc10fce13d [Rectify] [Php81] Enable Rectify on Readonly Property only (#1384)
2021-12-04 12:47:17 +00:00

207 lines
8.8 KiB
PHP

<?php
declare (strict_types=1);
namespace Rector\Php80\NodeManipulator;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\BinaryOp;
use PhpParser\Node\Expr\BinaryOp\BooleanOr;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\Instanceof_;
use PhpParser\Node\Name\FullyQualified;
use PHPStan\Type\Type;
use Rector\Core\PhpParser\Comparing\NodeComparator;
use Rector\Core\PhpParser\Node\BetterNodeFinder;
use Rector\NodeNameResolver\NodeNameResolver;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\NodeTypeResolver\NodeTypeResolver;
use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType;
final class ResourceReturnToObject
{
/**
* @readonly
* @var \Rector\NodeNameResolver\NodeNameResolver
*/
private $nodeNameResolver;
/**
* @readonly
* @var \Rector\NodeTypeResolver\NodeTypeResolver
*/
private $nodeTypeResolver;
/**
* @readonly
* @var \Rector\Core\PhpParser\Node\BetterNodeFinder
*/
private $betterNodeFinder;
/**
* @readonly
* @var \Rector\Core\PhpParser\Comparing\NodeComparator
*/
private $nodeComparator;
public function __construct(\Rector\NodeNameResolver\NodeNameResolver $nodeNameResolver, \Rector\NodeTypeResolver\NodeTypeResolver $nodeTypeResolver, \Rector\Core\PhpParser\Node\BetterNodeFinder $betterNodeFinder, \Rector\Core\PhpParser\Comparing\NodeComparator $nodeComparator)
{
$this->nodeNameResolver = $nodeNameResolver;
$this->nodeTypeResolver = $nodeTypeResolver;
$this->betterNodeFinder = $betterNodeFinder;
$this->nodeComparator = $nodeComparator;
}
/**
* @param array<string, string> $collectionFunctionToReturnObject
* @param \PhpParser\Node\Expr\BinaryOp\BooleanOr|\PhpParser\Node\Expr\FuncCall $node
* @return \PhpParser\Node\Expr\BinaryOp\BooleanOr|\PhpParser\Node\Expr\FuncCall|\PhpParser\Node\Expr\Instanceof_|null
*/
public function refactor($node, array $collectionFunctionToReturnObject)
{
if ($node instanceof \PhpParser\Node\Expr\FuncCall) {
return $this->processFuncCall($node, $collectionFunctionToReturnObject);
}
return $this->processBooleanOr($node, $collectionFunctionToReturnObject);
}
/**
* @param array<string, string> $collectionFunctionToReturnObject
*/
private function processFuncCall(\PhpParser\Node\Expr\FuncCall $funcCall, array $collectionFunctionToReturnObject) : ?\PhpParser\Node\Expr\Instanceof_
{
$parent = $funcCall->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::PARENT_NODE);
if ($parent instanceof \PhpParser\Node\Expr\BinaryOp && !$parent instanceof \PhpParser\Node\Expr\BinaryOp\BooleanOr) {
return null;
}
if ($this->shouldSkip($funcCall)) {
return null;
}
$objectInstanceCheck = $this->resolveObjectInstanceCheck($funcCall, $collectionFunctionToReturnObject);
if ($objectInstanceCheck === null) {
return null;
}
/** @var Expr $argResourceValue */
$argResourceValue = $funcCall->args[0]->value;
return new \PhpParser\Node\Expr\Instanceof_($argResourceValue, new \PhpParser\Node\Name\FullyQualified($objectInstanceCheck));
}
/**
* @param array<string, string> $collectionFunctionToReturnObject
*/
private function resolveArgValueType(\PhpParser\Node\Expr\FuncCall $funcCall, array $collectionFunctionToReturnObject) : ?\PHPStan\Type\Type
{
/** @var Expr $argResourceValue */
$argResourceValue = $funcCall->args[0]->value;
$argValueType = $this->nodeTypeResolver->getType($argResourceValue);
// if detected type is not FullyQualifiedObjectType, it still can be a resource to object, when:
// - in the right position of BooleanOr, it be NeverType
// - the object changed after init
if (!$argValueType instanceof \Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType) {
$argValueType = $this->resolveArgValueTypeFromPreviousAssign($funcCall, $argResourceValue, $collectionFunctionToReturnObject);
}
return $argValueType;
}
/**
* @param array<string, string> $collectionFunctionToReturnObject
*/
private function resolveObjectInstanceCheck(\PhpParser\Node\Expr\FuncCall $funcCall, array $collectionFunctionToReturnObject) : ?string
{
$argValueType = $this->resolveArgValueType($funcCall, $collectionFunctionToReturnObject);
if (!$argValueType instanceof \Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType) {
return null;
}
$className = $argValueType->getClassName();
foreach ($collectionFunctionToReturnObject as $singleCollectionFunctionToReturnObject) {
if ($className === $singleCollectionFunctionToReturnObject) {
return $singleCollectionFunctionToReturnObject;
}
}
return null;
}
/**
* @param array<string, string> $collectionFunctionToReturnObject
*/
private function resolveArgValueTypeFromPreviousAssign(\PhpParser\Node\Expr\FuncCall $funcCall, \PhpParser\Node\Expr $expr, array $collectionFunctionToReturnObject) : ?\Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType
{
$objectInstanceCheck = null;
$assign = $this->betterNodeFinder->findFirstPreviousOfNode($funcCall, function (\PhpParser\Node $subNode) use(&$objectInstanceCheck, $expr, $collectionFunctionToReturnObject) : bool {
if (!$this->isAssignWithFuncCallExpr($subNode)) {
return \false;
}
/** @var Assign $subNode */
if (!$this->nodeComparator->areNodesEqual($subNode->var, $expr)) {
return \false;
}
foreach ($collectionFunctionToReturnObject as $key => $value) {
if ($this->nodeNameResolver->isName($subNode->expr, $key)) {
$objectInstanceCheck = $value;
return \true;
}
}
return \false;
});
if (!$assign instanceof \PhpParser\Node\Expr\Assign) {
return null;
}
/** @var string $objectInstanceCheck */
return new \Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType($objectInstanceCheck);
}
private function isAssignWithFuncCallExpr(\PhpParser\Node $node) : bool
{
if (!$node instanceof \PhpParser\Node\Expr\Assign) {
return \false;
}
return $node->expr instanceof \PhpParser\Node\Expr\FuncCall;
}
/**
* @param array<string, string> $collectionFunctionToReturnObject
*/
private function processBooleanOr(\PhpParser\Node\Expr\BinaryOp\BooleanOr $booleanOr, array $collectionFunctionToReturnObject) : ?\PhpParser\Node\Expr\Instanceof_
{
$left = $booleanOr->left;
$right = $booleanOr->right;
$funCall = null;
$instanceof = null;
if ($left instanceof \PhpParser\Node\Expr\FuncCall && $right instanceof \PhpParser\Node\Expr\Instanceof_) {
$funCall = $left;
$instanceof = $right;
} elseif ($left instanceof \PhpParser\Node\Expr\Instanceof_ && $right instanceof \PhpParser\Node\Expr\FuncCall) {
$funCall = $right;
$instanceof = $left;
} else {
return null;
}
/** @var FuncCall $funCall */
if ($this->shouldSkip($funCall)) {
return null;
}
$objectInstanceCheck = $this->resolveObjectInstanceCheck($funCall, $collectionFunctionToReturnObject);
if ($objectInstanceCheck === null) {
return null;
}
/** @var Expr $argResourceValue */
$argResourceValue = $funCall->args[0]->value;
/** @var Instanceof_ $instanceof */
if (!$this->isInstanceOfObjectCheck($instanceof, $argResourceValue, $objectInstanceCheck)) {
return null;
}
return $instanceof;
}
private function isInstanceOfObjectCheck(\PhpParser\Node\Expr\Instanceof_ $instanceof, \PhpParser\Node\Expr $expr, string $objectInstanceCheck) : bool
{
if (!$instanceof->class instanceof \PhpParser\Node\Name\FullyQualified) {
return \false;
}
if (!$this->nodeComparator->areNodesEqual($expr, $instanceof->expr)) {
return \false;
}
return $this->nodeNameResolver->isName($instanceof->class, $objectInstanceCheck);
}
private function shouldSkip(\PhpParser\Node\Expr\FuncCall $funcCall) : bool
{
if (!$this->nodeNameResolver->isName($funcCall, 'is_resource')) {
return \true;
}
if (!isset($funcCall->args[0])) {
return \true;
}
$argResource = $funcCall->args[0];
return !$argResource instanceof \PhpParser\Node\Arg;
}
}