mirror of
https://github.com/rectorphp/rector.git
synced 2024-05-28 15:00:50 +00:00
35b646559b
914349ca92
[CodeQuality] Skip not autoloaded parent class on CompleteDynamicPropertiesRector (#5636)
197 lines
6.9 KiB
PHP
197 lines
6.9 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\CodeQuality\Rector\Class_;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Name\FullyQualified;
|
|
use PhpParser\Node\Stmt\Class_;
|
|
use PHPStan\Reflection\ClassReflection;
|
|
use PHPStan\Reflection\ReflectionProvider;
|
|
use PHPStan\Type\ObjectType;
|
|
use PHPStan\Type\Type;
|
|
use Rector\CodeQuality\NodeAnalyzer\ClassLikeAnalyzer;
|
|
use Rector\CodeQuality\NodeAnalyzer\LocalPropertyAnalyzer;
|
|
use Rector\CodeQuality\NodeFactory\MissingPropertiesFactory;
|
|
use Rector\NodeAnalyzer\ClassAnalyzer;
|
|
use Rector\NodeAnalyzer\PropertyPresenceChecker;
|
|
use Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer;
|
|
use Rector\PostRector\ValueObject\PropertyMetadata;
|
|
use Rector\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @changelog https://3v4l.org/GL6II
|
|
* @changelog https://3v4l.org/eTrhZ
|
|
* @changelog https://3v4l.org/C554W
|
|
*
|
|
* @see \Rector\Tests\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector\CompleteDynamicPropertiesRectorTest
|
|
*/
|
|
final class CompleteDynamicPropertiesRector extends AbstractRector
|
|
{
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\CodeQuality\NodeFactory\MissingPropertiesFactory
|
|
*/
|
|
private $missingPropertiesFactory;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\CodeQuality\NodeAnalyzer\LocalPropertyAnalyzer
|
|
*/
|
|
private $localPropertyAnalyzer;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\CodeQuality\NodeAnalyzer\ClassLikeAnalyzer
|
|
*/
|
|
private $classLikeAnalyzer;
|
|
/**
|
|
* @readonly
|
|
* @var \PHPStan\Reflection\ReflectionProvider
|
|
*/
|
|
private $reflectionProvider;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\NodeAnalyzer\ClassAnalyzer
|
|
*/
|
|
private $classAnalyzer;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\NodeAnalyzer\PropertyPresenceChecker
|
|
*/
|
|
private $propertyPresenceChecker;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer
|
|
*/
|
|
private $phpAttributeAnalyzer;
|
|
public function __construct(MissingPropertiesFactory $missingPropertiesFactory, LocalPropertyAnalyzer $localPropertyAnalyzer, ClassLikeAnalyzer $classLikeAnalyzer, ReflectionProvider $reflectionProvider, ClassAnalyzer $classAnalyzer, PropertyPresenceChecker $propertyPresenceChecker, PhpAttributeAnalyzer $phpAttributeAnalyzer)
|
|
{
|
|
$this->missingPropertiesFactory = $missingPropertiesFactory;
|
|
$this->localPropertyAnalyzer = $localPropertyAnalyzer;
|
|
$this->classLikeAnalyzer = $classLikeAnalyzer;
|
|
$this->reflectionProvider = $reflectionProvider;
|
|
$this->classAnalyzer = $classAnalyzer;
|
|
$this->propertyPresenceChecker = $propertyPresenceChecker;
|
|
$this->phpAttributeAnalyzer = $phpAttributeAnalyzer;
|
|
}
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Add missing dynamic properties', [new CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function set()
|
|
{
|
|
$this->value = 5;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
/**
|
|
* @var int
|
|
*/
|
|
public $value;
|
|
|
|
public function set()
|
|
{
|
|
$this->value = 5;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [Class_::class];
|
|
}
|
|
/**
|
|
* @param Class_ $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
if ($this->shouldSkipClass($node)) {
|
|
return null;
|
|
}
|
|
$className = $this->getName($node);
|
|
if ($className === null) {
|
|
return null;
|
|
}
|
|
if (!$this->reflectionProvider->hasClass($className)) {
|
|
return null;
|
|
}
|
|
$classReflection = $this->reflectionProvider->getClass($className);
|
|
// special case for Laravel Collection macro magic
|
|
$fetchedLocalPropertyNameToTypes = $this->localPropertyAnalyzer->resolveFetchedPropertiesToTypesFromClass($node);
|
|
$propertiesToComplete = $this->resolvePropertiesToComplete($node, $fetchedLocalPropertyNameToTypes);
|
|
if ($propertiesToComplete === []) {
|
|
return null;
|
|
}
|
|
$propertiesToComplete = $this->filterOutExistingProperties($node, $classReflection, $propertiesToComplete);
|
|
$newProperties = $this->missingPropertiesFactory->create($fetchedLocalPropertyNameToTypes, $propertiesToComplete);
|
|
if ($newProperties === []) {
|
|
return null;
|
|
}
|
|
$node->stmts = \array_merge($newProperties, $node->stmts);
|
|
return $node;
|
|
}
|
|
private function shouldSkipClass(Class_ $class) : bool
|
|
{
|
|
if ($this->classAnalyzer->isAnonymousClass($class)) {
|
|
return \true;
|
|
}
|
|
$className = (string) $this->nodeNameResolver->getName($class);
|
|
if (!$this->reflectionProvider->hasClass($className)) {
|
|
return \true;
|
|
}
|
|
if ($this->phpAttributeAnalyzer->hasPhpAttribute($class, 'AllowDynamicProperties')) {
|
|
return \true;
|
|
}
|
|
$classReflection = $this->reflectionProvider->getClass($className);
|
|
// properties are accessed via magic, nothing we can do
|
|
if ($classReflection->hasMethod('__set')) {
|
|
return \true;
|
|
}
|
|
if ($classReflection->hasMethod('__get')) {
|
|
return \true;
|
|
}
|
|
return $class->extends instanceof FullyQualified && !$this->reflectionProvider->hasClass($class->extends->toString());
|
|
}
|
|
/**
|
|
* @param array<string, Type> $fetchedLocalPropertyNameToTypes
|
|
* @return string[]
|
|
*/
|
|
private function resolvePropertiesToComplete(Class_ $class, array $fetchedLocalPropertyNameToTypes) : array
|
|
{
|
|
$propertyNames = $this->classLikeAnalyzer->resolvePropertyNames($class);
|
|
/** @var string[] $fetchedLocalPropertyNames */
|
|
$fetchedLocalPropertyNames = \array_keys($fetchedLocalPropertyNameToTypes);
|
|
return \array_diff($fetchedLocalPropertyNames, $propertyNames);
|
|
}
|
|
/**
|
|
* @param string[] $propertiesToComplete
|
|
* @return string[]
|
|
*/
|
|
private function filterOutExistingProperties(Class_ $class, ClassReflection $classReflection, array $propertiesToComplete) : array
|
|
{
|
|
$missingPropertyNames = [];
|
|
$className = $classReflection->getName();
|
|
// remove other properties that are accessible from this scope
|
|
foreach ($propertiesToComplete as $propertyToComplete) {
|
|
if ($classReflection->hasProperty($propertyToComplete)) {
|
|
continue;
|
|
}
|
|
$propertyMetadata = new PropertyMetadata($propertyToComplete, new ObjectType($className));
|
|
$hasClassContextProperty = $this->propertyPresenceChecker->hasClassContextProperty($class, $propertyMetadata);
|
|
if ($hasClassContextProperty) {
|
|
continue;
|
|
}
|
|
$missingPropertyNames[] = $propertyToComplete;
|
|
}
|
|
return $missingPropertyNames;
|
|
}
|
|
}
|