mirror of
https://github.com/rectorphp/rector.git
synced 2024-05-28 15:00:50 +00:00
d00ebb838c
56c2507715
Decouple AddClosureVoidReturnTypeWhereNoReturnRector to allow leveling by simple node first (#5562)
68 lines
1.9 KiB
PHP
68 lines
1.9 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\TypeDeclaration\Rector\Closure;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\Closure;
|
|
use PhpParser\Node\Identifier;
|
|
use Rector\Rector\AbstractRector;
|
|
use Rector\TypeDeclaration\TypeInferer\SilentVoidResolver;
|
|
use Rector\ValueObject\PhpVersionFeature;
|
|
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Tests\TypeDeclaration\Rector\Closure\AddClosureVoidReturnTypeWhereNoReturnRector\AddClosureVoidReturnTypeWhereNoReturnRectorTest
|
|
*/
|
|
final class AddClosureVoidReturnTypeWhereNoReturnRector extends AbstractRector implements MinPhpVersionInterface
|
|
{
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\TypeDeclaration\TypeInferer\SilentVoidResolver
|
|
*/
|
|
private $silentVoidResolver;
|
|
public function __construct(SilentVoidResolver $silentVoidResolver)
|
|
{
|
|
$this->silentVoidResolver = $silentVoidResolver;
|
|
}
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Add closure return type void if there is no return', [new CodeSample(<<<'CODE_SAMPLE'
|
|
function () {
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
function (): void {
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [Closure::class];
|
|
}
|
|
/**
|
|
* @param Closure $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
// already has return type → skip
|
|
if ($node->returnType instanceof Node) {
|
|
return null;
|
|
}
|
|
if (!$this->silentVoidResolver->hasExclusiveVoid($node)) {
|
|
return null;
|
|
}
|
|
$node->returnType = new Identifier('void');
|
|
return $node;
|
|
}
|
|
public function provideMinPhpVersion() : int
|
|
{
|
|
return PhpVersionFeature::VOID_TYPE;
|
|
}
|
|
}
|