mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-09 04:32:33 +00:00
3d95b4f79c
f78af10920
[EarlyReturn] Remove ReturnAfterToEarlyOnBreakRector as risky and turning around next/previous nodes (#2624)
84 lines
2.5 KiB
PHP
84 lines
2.5 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Laravel\Rector\Class_;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Name\FullyQualified;
|
|
use PhpParser\Node\Stmt\Class_;
|
|
use PhpParser\Node\Stmt\Property;
|
|
use PHPStan\Type\ObjectType;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @changelog https://laravel.com/docs/5.8/upgrade#deferred-service-providers
|
|
*
|
|
* @see \Rector\Laravel\Tests\Rector\Class_\PropertyDeferToDeferrableProviderToRector\PropertyDeferToDeferrableProviderToRectorTest
|
|
*/
|
|
final class PropertyDeferToDeferrableProviderToRector extends AbstractRector
|
|
{
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Change deprecated $defer = true; to Illuminate\\Contracts\\Support\\DeferrableProvider interface', [new CodeSample(<<<'CODE_SAMPLE'
|
|
use Illuminate\Support\ServiceProvider;
|
|
|
|
final class SomeServiceProvider extends ServiceProvider
|
|
{
|
|
/**
|
|
* @var bool
|
|
*/
|
|
protected $defer = true;
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
use Illuminate\Support\ServiceProvider;
|
|
use Illuminate\Contracts\Support\DeferrableProvider;
|
|
|
|
final class SomeServiceProvider extends ServiceProvider implements DeferrableProvider
|
|
{
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [Class_::class];
|
|
}
|
|
/**
|
|
* @param Class_ $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
if (!$this->isObjectType($node, new ObjectType('Illuminate\\Support\\ServiceProvider'))) {
|
|
return null;
|
|
}
|
|
$deferProperty = $this->matchDeferWithFalseProperty($node);
|
|
if (!$deferProperty instanceof Property) {
|
|
return null;
|
|
}
|
|
$this->removeNode($deferProperty);
|
|
$node->implements[] = new FullyQualified('Illuminate\\Contracts\\Support\\DeferrableProvider');
|
|
return $node;
|
|
}
|
|
private function matchDeferWithFalseProperty(Class_ $class) : ?Property
|
|
{
|
|
foreach ($class->getProperties() as $property) {
|
|
if (!$this->isName($property, 'defer')) {
|
|
continue;
|
|
}
|
|
$onlyProperty = $property->props[0];
|
|
if ($onlyProperty->default === null) {
|
|
return null;
|
|
}
|
|
if ($this->valueResolver->isTrue($onlyProperty->default)) {
|
|
return $property;
|
|
}
|
|
}
|
|
return null;
|
|
}
|
|
}
|