mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-01 17:00:51 +00:00
3d95b4f79c
f78af10920
[EarlyReturn] Remove ReturnAfterToEarlyOnBreakRector as risky and turning around next/previous nodes (#2624)
70 lines
2.0 KiB
PHP
70 lines
2.0 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Laravel\Rector\FuncCall;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Arg;
|
|
use PhpParser\Node\Expr\ClassConstFetch;
|
|
use PhpParser\Node\Expr\FuncCall;
|
|
use PhpParser\Node\Expr\StaticCall;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @changelog https://laravel.com/docs/7.x/database-testing#creating-models
|
|
* @changelog https://laravel.com/docs/8.x/database-testing#instantiating-models
|
|
*
|
|
* @see \Rector\Laravel\Tests\Rector\FuncCall\FactoryFuncCallToStaticCallRector\FactoryFuncCallToStaticCallRectorTest
|
|
*/
|
|
final class FactoryFuncCallToStaticCallRector extends AbstractRector
|
|
{
|
|
/**
|
|
* @var string
|
|
*/
|
|
private const FACTORY = 'factory';
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Use the static factory method instead of global factory function.', [new CodeSample(<<<'CODE_SAMPLE'
|
|
factory(User::class);
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
User::factory();
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [FuncCall::class];
|
|
}
|
|
/**
|
|
* @param Node\Expr\FuncCall $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
if (!$this->isName($node->name, self::FACTORY)) {
|
|
return null;
|
|
}
|
|
if (!isset($node->args[0])) {
|
|
return null;
|
|
}
|
|
if (!$node->args[0] instanceof Arg) {
|
|
return null;
|
|
}
|
|
$firstArgValue = $node->args[0]->value;
|
|
if (!$firstArgValue instanceof ClassConstFetch) {
|
|
return null;
|
|
}
|
|
$model = $firstArgValue->class;
|
|
// create model
|
|
if (!isset($node->args[1])) {
|
|
return new StaticCall($model, self::FACTORY);
|
|
}
|
|
// create models of a given type
|
|
return new StaticCall($model, self::FACTORY, [$node->args[1]]);
|
|
}
|
|
}
|