mirror of
https://github.com/rectorphp/rector.git
synced 2024-05-28 23:10:51 +00:00
1127b0c4e2
bc9d2d48d5
[DX] Add MissedRectorDueVersionChecker (#465)
175 lines
6.6 KiB
PHP
175 lines
6.6 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\CodeQuality\Rector\ClassMethod;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Arg;
|
|
use PhpParser\Node\Expr\Assign;
|
|
use PhpParser\Node\Expr\MethodCall;
|
|
use PhpParser\Node\Expr\Variable;
|
|
use PhpParser\Node\Name\FullyQualified;
|
|
use PhpParser\Node\NullableType;
|
|
use PhpParser\Node\Param;
|
|
use PhpParser\Node\Stmt\ClassMethod;
|
|
use PhpParser\Node\Stmt\Expression;
|
|
use PHPStan\Type\NullType;
|
|
use PHPStan\Type\ObjectType;
|
|
use PHPStan\Type\UnionType;
|
|
use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger;
|
|
use Rector\Core\Exception\ShouldNotHappenException;
|
|
use Rector\Core\NodeAnalyzer\ParamAnalyzer;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\Core\ValueObject\MethodName;
|
|
use Rector\Core\ValueObject\PhpVersionFeature;
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
|
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Tests\CodeQuality\Rector\ClassMethod\DateTimeToDateTimeInterfaceRector\DateTimeToDateTimeInterfaceRectorTest
|
|
*/
|
|
final class DateTimeToDateTimeInterfaceRector extends \Rector\Core\Rector\AbstractRector implements \Rector\VersionBonding\Contract\MinPhpVersionInterface
|
|
{
|
|
/**
|
|
* @var string[]
|
|
*/
|
|
private const METHODS_RETURNING_CLASS_INSTANCE_MAP = ['add', 'modify', \Rector\Core\ValueObject\MethodName::SET_STATE, 'setDate', 'setISODate', 'setTime', 'setTimestamp', 'setTimezone', 'sub'];
|
|
/**
|
|
* @var \Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger
|
|
*/
|
|
private $phpDocTypeChanger;
|
|
/**
|
|
* @var \Rector\Core\NodeAnalyzer\ParamAnalyzer
|
|
*/
|
|
private $paramAnalyzer;
|
|
public function __construct(\Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger $phpDocTypeChanger, \Rector\Core\NodeAnalyzer\ParamAnalyzer $paramAnalyzer)
|
|
{
|
|
$this->phpDocTypeChanger = $phpDocTypeChanger;
|
|
$this->paramAnalyzer = $paramAnalyzer;
|
|
}
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Changes DateTime type-hint to DateTimeInterface', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass {
|
|
public function methodWithDateTime(\DateTime $dateTime)
|
|
{
|
|
return true;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass {
|
|
/**
|
|
* @param \DateTime|\DateTimeImmutable $dateTime
|
|
*/
|
|
public function methodWithDateTime(\DateTimeInterface $dateTime)
|
|
{
|
|
return true;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Stmt\ClassMethod::class];
|
|
}
|
|
/**
|
|
* @param ClassMethod $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
$isModifiedNode = \false;
|
|
foreach ($node->getParams() as $param) {
|
|
if (!$this->isObjectType($param, new \PHPStan\Type\ObjectType('DateTime'))) {
|
|
continue;
|
|
}
|
|
$this->refactorParamTypeHint($param);
|
|
$this->refactorParamDocBlock($param, $node);
|
|
$this->refactorMethodCalls($param, $node);
|
|
$isModifiedNode = \true;
|
|
}
|
|
if (!$isModifiedNode) {
|
|
return null;
|
|
}
|
|
return $node;
|
|
}
|
|
public function provideMinPhpVersion() : int
|
|
{
|
|
return \Rector\Core\ValueObject\PhpVersionFeature::DATE_TIME_INTERFACE;
|
|
}
|
|
private function refactorParamTypeHint(\PhpParser\Node\Param $param) : void
|
|
{
|
|
$fullyQualified = new \PhpParser\Node\Name\FullyQualified('DateTimeInterface');
|
|
if ($this->paramAnalyzer->isNullable($param)) {
|
|
$param->type = new \PhpParser\Node\NullableType($fullyQualified);
|
|
return;
|
|
}
|
|
$param->type = $fullyQualified;
|
|
}
|
|
private function refactorParamDocBlock(\PhpParser\Node\Param $param, \PhpParser\Node\Stmt\ClassMethod $classMethod) : void
|
|
{
|
|
$types = [new \PHPStan\Type\ObjectType('DateTime'), new \PHPStan\Type\ObjectType('DateTimeImmutable')];
|
|
if ($this->paramAnalyzer->isNullable($param)) {
|
|
$types[] = new \PHPStan\Type\NullType();
|
|
}
|
|
$paramName = $this->getName($param->var);
|
|
if ($paramName === null) {
|
|
throw new \Rector\Core\Exception\ShouldNotHappenException();
|
|
}
|
|
$phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($classMethod);
|
|
$this->phpDocTypeChanger->changeParamType($phpDocInfo, new \PHPStan\Type\UnionType($types), $param, $paramName);
|
|
}
|
|
private function refactorMethodCalls(\PhpParser\Node\Param $param, \PhpParser\Node\Stmt\ClassMethod $classMethod) : void
|
|
{
|
|
if ($classMethod->stmts === null) {
|
|
return;
|
|
}
|
|
$this->traverseNodesWithCallable($classMethod->stmts, function (\PhpParser\Node $node) use($param) : void {
|
|
if (!$node instanceof \PhpParser\Node\Expr\MethodCall) {
|
|
return;
|
|
}
|
|
$this->refactorMethodCall($param, $node);
|
|
});
|
|
}
|
|
private function refactorMethodCall(\PhpParser\Node\Param $param, \PhpParser\Node\Expr\MethodCall $methodCall) : void
|
|
{
|
|
$paramName = $this->getName($param->var);
|
|
if ($paramName === null) {
|
|
return;
|
|
}
|
|
if ($this->shouldSkipMethodCallRefactor($paramName, $methodCall)) {
|
|
return;
|
|
}
|
|
$assign = new \PhpParser\Node\Expr\Assign(new \PhpParser\Node\Expr\Variable($paramName), $methodCall);
|
|
/** @var Node $parent */
|
|
$parent = $methodCall->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::PARENT_NODE);
|
|
if ($parent instanceof \PhpParser\Node\Arg) {
|
|
$parent->value = $assign;
|
|
return;
|
|
}
|
|
if (!$parent instanceof \PhpParser\Node\Stmt\Expression) {
|
|
return;
|
|
}
|
|
$parent->expr = $assign;
|
|
}
|
|
private function shouldSkipMethodCallRefactor(string $paramName, \PhpParser\Node\Expr\MethodCall $methodCall) : bool
|
|
{
|
|
if (!$this->isName($methodCall->var, $paramName)) {
|
|
return \true;
|
|
}
|
|
if (!$this->isNames($methodCall->name, self::METHODS_RETURNING_CLASS_INSTANCE_MAP)) {
|
|
return \true;
|
|
}
|
|
$parentNode = $methodCall->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::PARENT_NODE);
|
|
if (!$parentNode instanceof \PhpParser\Node) {
|
|
return \true;
|
|
}
|
|
return $parentNode instanceof \PhpParser\Node\Expr\Assign;
|
|
}
|
|
}
|