mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-04 02:10:51 +00:00
1127b0c4e2
bc9d2d48d5
[DX] Add MissedRectorDueVersionChecker (#465)
161 lines
6.4 KiB
PHP
161 lines
6.4 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\CodeQuality\Rector\Foreach_;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\ArrayDimFetch;
|
|
use PhpParser\Node\Expr\Assign;
|
|
use PhpParser\Node\Expr\BinaryOp\Coalesce;
|
|
use PhpParser\Node\Expr\BinaryOp\Identical;
|
|
use PhpParser\Node\Stmt\Expression;
|
|
use PhpParser\Node\Stmt\Foreach_;
|
|
use PhpParser\Node\Stmt\If_;
|
|
use PhpParser\Node\Stmt\Return_;
|
|
use Rector\Core\NodeManipulator\ForeachManipulator;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\Core\ValueObject\PhpVersionFeature;
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
|
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see https://3v4l.org/bfsdY
|
|
*
|
|
* @see \Rector\Tests\CodeQuality\Rector\Foreach_\SimplifyForeachToCoalescingRector\SimplifyForeachToCoalescingRectorTest
|
|
*/
|
|
final class SimplifyForeachToCoalescingRector extends \Rector\Core\Rector\AbstractRector implements \Rector\VersionBonding\Contract\MinPhpVersionInterface
|
|
{
|
|
/**
|
|
* @var \PhpParser\Node\Stmt\Return_|null
|
|
*/
|
|
private $return;
|
|
/**
|
|
* @var \Rector\Core\NodeManipulator\ForeachManipulator
|
|
*/
|
|
private $foreachManipulator;
|
|
public function __construct(\Rector\Core\NodeManipulator\ForeachManipulator $foreachManipulator)
|
|
{
|
|
$this->foreachManipulator = $foreachManipulator;
|
|
}
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Changes foreach that returns set value to ??', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
foreach ($this->oldToNewFunctions as $oldFunction => $newFunction) {
|
|
if ($currentFunction === $oldFunction) {
|
|
return $newFunction;
|
|
}
|
|
}
|
|
|
|
return null;
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
return $this->oldToNewFunctions[$currentFunction] ?? null;
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Stmt\Foreach_::class];
|
|
}
|
|
/**
|
|
* @param Foreach_ $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
$this->return = null;
|
|
if ($node->keyVar === null) {
|
|
return null;
|
|
}
|
|
/** @var Return_|Assign|null $returnOrAssignNode */
|
|
$returnOrAssignNode = $this->matchReturnOrAssignNode($node);
|
|
if ($returnOrAssignNode === null) {
|
|
return null;
|
|
}
|
|
// return $newValue;
|
|
// we don't return the node value
|
|
if (!$this->nodeComparator->areNodesEqual($node->valueVar, $returnOrAssignNode->expr)) {
|
|
return null;
|
|
}
|
|
if ($returnOrAssignNode instanceof \PhpParser\Node\Stmt\Return_) {
|
|
return $this->processForeachNodeWithReturnInside($node, $returnOrAssignNode);
|
|
}
|
|
return $this->processForeachNodeWithAssignInside($node, $returnOrAssignNode);
|
|
}
|
|
public function provideMinPhpVersion() : int
|
|
{
|
|
return \Rector\Core\ValueObject\PhpVersionFeature::NULL_COALESCE;
|
|
}
|
|
/**
|
|
* @return Assign|Return_|null
|
|
*/
|
|
private function matchReturnOrAssignNode(\PhpParser\Node\Stmt\Foreach_ $foreach) : ?\PhpParser\Node
|
|
{
|
|
return $this->foreachManipulator->matchOnlyStmt($foreach, function (\PhpParser\Node $node) : ?Node {
|
|
if (!$node instanceof \PhpParser\Node\Stmt\If_) {
|
|
return null;
|
|
}
|
|
if (!$node->cond instanceof \PhpParser\Node\Expr\BinaryOp\Identical) {
|
|
return null;
|
|
}
|
|
if (\count($node->stmts) !== 1) {
|
|
return null;
|
|
}
|
|
$innerNode = $node->stmts[0] instanceof \PhpParser\Node\Stmt\Expression ? $node->stmts[0]->expr : $node->stmts[0];
|
|
if ($innerNode instanceof \PhpParser\Node\Expr\Assign || $innerNode instanceof \PhpParser\Node\Stmt\Return_) {
|
|
return $innerNode;
|
|
}
|
|
return null;
|
|
});
|
|
}
|
|
private function processForeachNodeWithReturnInside(\PhpParser\Node\Stmt\Foreach_ $foreach, \PhpParser\Node\Stmt\Return_ $return) : ?\PhpParser\Node
|
|
{
|
|
if (!$this->nodeComparator->areNodesEqual($foreach->valueVar, $return->expr)) {
|
|
return null;
|
|
}
|
|
/** @var If_ $ifNode */
|
|
$ifNode = $foreach->stmts[0];
|
|
/** @var Identical $identicalNode */
|
|
$identicalNode = $ifNode->cond;
|
|
if ($this->nodeComparator->areNodesEqual($identicalNode->left, $foreach->keyVar)) {
|
|
$checkedNode = $identicalNode->right;
|
|
} elseif ($this->nodeComparator->areNodesEqual($identicalNode->right, $foreach->keyVar)) {
|
|
$checkedNode = $identicalNode->left;
|
|
} else {
|
|
return null;
|
|
}
|
|
$nextNode = $foreach->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::NEXT_NODE);
|
|
// is next node Return?
|
|
if ($nextNode instanceof \PhpParser\Node\Stmt\Return_) {
|
|
$this->return = $nextNode;
|
|
$this->removeNode($this->return);
|
|
}
|
|
$coalesce = new \PhpParser\Node\Expr\BinaryOp\Coalesce(new \PhpParser\Node\Expr\ArrayDimFetch($foreach->expr, $checkedNode), $this->return && $this->return->expr !== null ? $this->return->expr : $checkedNode);
|
|
if ($this->return !== null) {
|
|
return new \PhpParser\Node\Stmt\Return_($coalesce);
|
|
}
|
|
return null;
|
|
}
|
|
private function processForeachNodeWithAssignInside(\PhpParser\Node\Stmt\Foreach_ $foreach, \PhpParser\Node\Expr\Assign $assign) : ?\PhpParser\Node
|
|
{
|
|
/** @var If_ $ifNode */
|
|
$ifNode = $foreach->stmts[0];
|
|
/** @var Identical $identicalNode */
|
|
$identicalNode = $ifNode->cond;
|
|
if ($this->nodeComparator->areNodesEqual($identicalNode->left, $foreach->keyVar)) {
|
|
$checkedNode = $assign->var;
|
|
$keyNode = $identicalNode->right;
|
|
} elseif ($this->nodeComparator->areNodesEqual($identicalNode->right, $foreach->keyVar)) {
|
|
$checkedNode = $assign->var;
|
|
$keyNode = $identicalNode->left;
|
|
} else {
|
|
return null;
|
|
}
|
|
$arrayDimFetch = new \PhpParser\Node\Expr\ArrayDimFetch($foreach->expr, $keyNode);
|
|
return new \PhpParser\Node\Expr\Assign($checkedNode, new \PhpParser\Node\Expr\BinaryOp\Coalesce($arrayDimFetch, $checkedNode));
|
|
}
|
|
}
|