mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-03 18:00:50 +00:00
7d36c3b0b9
a80cf5292d
revert to working scoper 0.14
93 lines
3.1 KiB
PHP
93 lines
3.1 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\CodeQuality\Rector\Identical;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\BinaryOp\Identical;
|
|
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
|
|
use PhpParser\Node\Expr\BooleanNot;
|
|
use PHPStan\Type\BooleanType;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see https://3v4l.org/GoEPq
|
|
* @see \Rector\Tests\CodeQuality\Rector\Identical\BooleanNotIdenticalToNotIdenticalRector\BooleanNotIdenticalToNotIdenticalRectorTest
|
|
*/
|
|
final class BooleanNotIdenticalToNotIdenticalRector extends \Rector\Core\Rector\AbstractRector
|
|
{
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Negated identical boolean compare to not identical compare (does not apply to non-bool values)', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
$a = true;
|
|
$b = false;
|
|
|
|
var_dump(! $a === $b); // true
|
|
var_dump(! ($a === $b)); // true
|
|
var_dump($a !== $b); // true
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
$a = true;
|
|
$b = false;
|
|
|
|
var_dump($a !== $b); // true
|
|
var_dump($a !== $b); // true
|
|
var_dump($a !== $b); // true
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Expr\BinaryOp\Identical::class, \PhpParser\Node\Expr\BooleanNot::class];
|
|
}
|
|
/**
|
|
* @param Identical|BooleanNot $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
if ($node instanceof \PhpParser\Node\Expr\BinaryOp\Identical) {
|
|
return $this->processIdentical($node);
|
|
}
|
|
if ($node->expr instanceof \PhpParser\Node\Expr\BinaryOp\Identical) {
|
|
$identical = $node->expr;
|
|
if (!$this->nodeTypeResolver->isStaticType($identical->left, \PHPStan\Type\BooleanType::class)) {
|
|
return null;
|
|
}
|
|
if (!$this->nodeTypeResolver->isStaticType($identical->right, \PHPStan\Type\BooleanType::class)) {
|
|
return null;
|
|
}
|
|
return new \PhpParser\Node\Expr\BinaryOp\NotIdentical($identical->left, $identical->right);
|
|
}
|
|
return null;
|
|
}
|
|
private function processIdentical(\PhpParser\Node\Expr\BinaryOp\Identical $identical) : ?\PhpParser\Node\Expr\BinaryOp\NotIdentical
|
|
{
|
|
if (!$this->nodeTypeResolver->isStaticType($identical->left, \PHPStan\Type\BooleanType::class)) {
|
|
return null;
|
|
}
|
|
if (!$this->nodeTypeResolver->isStaticType($identical->right, \PHPStan\Type\BooleanType::class)) {
|
|
return null;
|
|
}
|
|
if ($identical->left instanceof \PhpParser\Node\Expr\BooleanNot) {
|
|
return new \PhpParser\Node\Expr\BinaryOp\NotIdentical($identical->left->expr, $identical->right);
|
|
}
|
|
return null;
|
|
}
|
|
}
|