mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-04 02:10:51 +00:00
bda9a60c30
5a863f6548
[CodeQuality] Handle Nested Ternary on SwitchNegatedTernaryRector to have parenthesis (#397)
78 lines
2.3 KiB
PHP
78 lines
2.3 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\CodeQuality\Rector\Ternary;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\BooleanNot;
|
|
use PhpParser\Node\Expr\Ternary;
|
|
use Rector\Core\PhpParser\Node\Value\TernaryBracketWrapper;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Tests\CodeQuality\Rector\Ternary\SwitchNegatedTernaryRector\SwitchNegatedTernaryRectorTest
|
|
*/
|
|
final class SwitchNegatedTernaryRector extends \Rector\Core\Rector\AbstractRector
|
|
{
|
|
/**
|
|
* @var \Rector\Core\PhpParser\Node\Value\TernaryBracketWrapper
|
|
*/
|
|
private $ternaryBracketWrapper;
|
|
public function __construct(\Rector\Core\PhpParser\Node\Value\TernaryBracketWrapper $ternaryBracketWrapper)
|
|
{
|
|
$this->ternaryBracketWrapper = $ternaryBracketWrapper;
|
|
}
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Switch negated ternary condition rector', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run(bool $upper, string $name)
|
|
{
|
|
return ! $upper
|
|
? $name
|
|
: strtoupper($name);
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run(bool $upper, string $name)
|
|
{
|
|
return $upper
|
|
? strtoupper($name)
|
|
: $name;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Expr\Ternary::class];
|
|
}
|
|
/**
|
|
* @param Ternary $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
if (!$node->cond instanceof \PhpParser\Node\Expr\BooleanNot) {
|
|
return null;
|
|
}
|
|
if ($node->if === null) {
|
|
return null;
|
|
}
|
|
$node->cond = $node->cond->expr;
|
|
[$node->if, $node->else] = [$node->else, $node->if];
|
|
if ($node->if instanceof \PhpParser\Node\Expr\Ternary) {
|
|
$this->ternaryBracketWrapper->wrapWithBracket($node->if);
|
|
}
|
|
return $node;
|
|
}
|
|
}
|