mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-04 02:10:51 +00:00
cdc3b7adef
f451b0b8e1
[PHP 8.0] Bump to promoted properties (#4)
114 lines
4.6 KiB
PHP
114 lines
4.6 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\CodeQuality\Rector\Ternary;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr;
|
|
use PhpParser\Node\Expr\BinaryOp;
|
|
use PhpParser\Node\Expr\BooleanNot;
|
|
use PhpParser\Node\Expr\Cast\Bool_;
|
|
use PhpParser\Node\Expr\Ternary;
|
|
use PHPStan\Type\BooleanType;
|
|
use Rector\Core\PhpParser\Node\AssignAndBinaryMap;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Tests\CodeQuality\Rector\Ternary\UnnecessaryTernaryExpressionRector\UnnecessaryTernaryExpressionRectorTest
|
|
*/
|
|
final class UnnecessaryTernaryExpressionRector extends \Rector\Core\Rector\AbstractRector
|
|
{
|
|
/**
|
|
* @var \Rector\Core\PhpParser\Node\AssignAndBinaryMap
|
|
*/
|
|
private $assignAndBinaryMap;
|
|
public function __construct(\Rector\Core\PhpParser\Node\AssignAndBinaryMap $assignAndBinaryMap)
|
|
{
|
|
$this->assignAndBinaryMap = $assignAndBinaryMap;
|
|
}
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Remove unnecessary ternary expressions.', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample('$foo === $bar ? true : false;', '$foo === $bar;')]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Expr\Ternary::class];
|
|
}
|
|
/**
|
|
* @param Ternary $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
/** @var Ternary $ternaryExpression */
|
|
$ternaryExpression = $node;
|
|
if (!$ternaryExpression->if instanceof \PhpParser\Node\Expr) {
|
|
return null;
|
|
}
|
|
$ifExpression = $ternaryExpression->if;
|
|
if (!$this->valueResolver->isTrueOrFalse($ifExpression)) {
|
|
return null;
|
|
}
|
|
$elseExpression = $ternaryExpression->else;
|
|
if (!$this->valueResolver->isTrueOrFalse($elseExpression)) {
|
|
return null;
|
|
}
|
|
$condition = $ternaryExpression->cond;
|
|
if (!$condition instanceof \PhpParser\Node\Expr\BinaryOp) {
|
|
return $this->processNonBinaryCondition($ifExpression, $elseExpression, $condition);
|
|
}
|
|
if ($this->valueResolver->isNull($ifExpression)) {
|
|
return null;
|
|
}
|
|
if ($this->valueResolver->isNull($elseExpression)) {
|
|
return null;
|
|
}
|
|
/** @var BinaryOp $binaryOperation */
|
|
$binaryOperation = $node->cond;
|
|
if ($this->valueResolver->isTrue($ifExpression) && $this->valueResolver->isFalse($elseExpression)) {
|
|
return $binaryOperation;
|
|
}
|
|
$inversedBinaryClass = $this->assignAndBinaryMap->getInversed($binaryOperation);
|
|
if ($inversedBinaryClass === null) {
|
|
return null;
|
|
}
|
|
return new $inversedBinaryClass($binaryOperation->left, $binaryOperation->right);
|
|
}
|
|
private function processNonBinaryCondition(\PhpParser\Node\Expr $ifExpression, \PhpParser\Node\Expr $elseExpression, \PhpParser\Node\Expr $condition) : ?\PhpParser\Node
|
|
{
|
|
if ($this->valueResolver->isTrue($ifExpression) && $this->valueResolver->isFalse($elseExpression)) {
|
|
return $this->processTrueIfExpressionWithFalseElseExpression($condition);
|
|
}
|
|
if (!$this->valueResolver->isFalse($ifExpression)) {
|
|
return null;
|
|
}
|
|
if (!$this->valueResolver->isTrue($elseExpression)) {
|
|
return null;
|
|
}
|
|
return $this->processFalseIfExpressionWithTrueElseExpression($condition);
|
|
}
|
|
private function processTrueIfExpressionWithFalseElseExpression(\PhpParser\Node\Expr $expr) : \PhpParser\Node\Expr
|
|
{
|
|
if ($this->nodeTypeResolver->isStaticType($expr, \PHPStan\Type\BooleanType::class)) {
|
|
return $expr;
|
|
}
|
|
return new \PhpParser\Node\Expr\Cast\Bool_($expr);
|
|
}
|
|
private function processFalseIfExpressionWithTrueElseExpression(\PhpParser\Node\Expr $expr) : \PhpParser\Node\Expr
|
|
{
|
|
if ($expr instanceof \PhpParser\Node\Expr\BooleanNot) {
|
|
if ($this->nodeTypeResolver->isStaticType($expr->expr, \PHPStan\Type\BooleanType::class)) {
|
|
return $expr->expr;
|
|
}
|
|
return new \PhpParser\Node\Expr\Cast\Bool_($expr->expr);
|
|
}
|
|
if ($this->nodeTypeResolver->isStaticType($expr, \PHPStan\Type\BooleanType::class)) {
|
|
return new \PhpParser\Node\Expr\BooleanNot($expr);
|
|
}
|
|
return new \PhpParser\Node\Expr\BooleanNot(new \PhpParser\Node\Expr\Cast\Bool_($expr));
|
|
}
|
|
}
|