mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-04 02:10:51 +00:00
1127b0c4e2
bc9d2d48d5
[DX] Add MissedRectorDueVersionChecker (#465)
163 lines
6.4 KiB
PHP
163 lines
6.4 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\CodingStyle\Rector\ClassMethod;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr;
|
|
use PhpParser\Node\Expr\Assign;
|
|
use PhpParser\Node\Expr\Closure;
|
|
use PhpParser\Node\Expr\FuncCall;
|
|
use PhpParser\Node\Expr\Variable;
|
|
use PhpParser\Node\FunctionLike;
|
|
use PhpParser\Node\Param;
|
|
use PhpParser\Node\Stmt;
|
|
use PhpParser\Node\Stmt\ClassMethod;
|
|
use PhpParser\Node\Stmt\Expression;
|
|
use PhpParser\Node\Stmt\Function_;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\Core\ValueObject\PhpVersionFeature;
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
|
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @changelog https://3v4l.org/d4tBd
|
|
*
|
|
* @see \Rector\Tests\CodingStyle\Rector\ClassMethod\FuncGetArgsToVariadicParamRector\FuncGetArgsToVariadicParamRectorTest
|
|
*/
|
|
final class FuncGetArgsToVariadicParamRector extends \Rector\Core\Rector\AbstractRector implements \Rector\VersionBonding\Contract\MinPhpVersionInterface
|
|
{
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Refactor func_get_args() in to a variadic param', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
function run()
|
|
{
|
|
$args = \func_get_args();
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
function run(...$args)
|
|
{
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Stmt\ClassMethod::class, \PhpParser\Node\Stmt\Function_::class, \PhpParser\Node\Expr\Closure::class];
|
|
}
|
|
/**
|
|
* @param ClassMethod|Function_|Closure $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
if ($node->params !== []) {
|
|
return null;
|
|
}
|
|
$assign = $this->matchFuncGetArgsVariableAssign($node);
|
|
if (!$assign instanceof \PhpParser\Node\Expr\Assign) {
|
|
return null;
|
|
}
|
|
if ($assign->var instanceof \PhpParser\Node\Expr\Variable) {
|
|
$variableName = $this->getName($assign->var);
|
|
if ($variableName === null) {
|
|
return null;
|
|
}
|
|
return $this->removeOrChangeAssignToVariable($node, $assign, $variableName);
|
|
}
|
|
$variableName = 'args';
|
|
$assign->expr = new \PhpParser\Node\Expr\Variable('args');
|
|
return $this->applyVariadicParams($node, $assign, $variableName);
|
|
}
|
|
public function provideMinPhpVersion() : int
|
|
{
|
|
return \Rector\Core\ValueObject\PhpVersionFeature::VARIADIC_PARAM;
|
|
}
|
|
/**
|
|
* @param \PhpParser\Node\Stmt\ClassMethod|\PhpParser\Node\Stmt\Function_|\PhpParser\Node\Expr\Closure $node
|
|
*/
|
|
private function applyVariadicParams($node, \PhpParser\Node\Expr\Assign $assign, string $variableName) : ?\PhpParser\Node
|
|
{
|
|
$param = $this->createVariadicParam($variableName);
|
|
$variableParam = $param->var;
|
|
if ($variableParam instanceof \PhpParser\Node\Expr\Variable && $this->hasFunctionOrClosureInside($node, $variableParam)) {
|
|
return null;
|
|
}
|
|
$node->params[] = $param;
|
|
return $node;
|
|
}
|
|
/**
|
|
* @param \PhpParser\Node\Stmt\ClassMethod|\PhpParser\Node\Stmt\Function_|\PhpParser\Node\Expr\Closure $node
|
|
*/
|
|
private function removeOrChangeAssignToVariable($node, \PhpParser\Node\Expr\Assign $assign, string $variableName) : ?\PhpParser\Node
|
|
{
|
|
$parent = $assign->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::PARENT_NODE);
|
|
if ($parent instanceof \PhpParser\Node\Stmt\Expression) {
|
|
$this->removeNode($assign);
|
|
return $this->applyVariadicParams($node, $assign, $variableName);
|
|
}
|
|
$variable = $assign->var;
|
|
/** @var ClassMethod|Function_|Closure $functionLike */
|
|
$functionLike = $this->betterNodeFinder->findParentType($parent, \PhpParser\Node\FunctionLike::class);
|
|
/** @var Stmt[] $stmts */
|
|
$stmts = $functionLike->getStmts();
|
|
$this->traverseNodesWithCallable($stmts, function (\PhpParser\Node $node) use($assign, $variable) : ?Expr {
|
|
if (!$this->nodeComparator->areNodesEqual($node, $assign)) {
|
|
return null;
|
|
}
|
|
return $variable;
|
|
});
|
|
$this->applyVariadicParams($functionLike, $assign, $variableName);
|
|
return $node;
|
|
}
|
|
/**
|
|
* @param \PhpParser\Node\Stmt\ClassMethod|\PhpParser\Node\Stmt\Function_|\PhpParser\Node\Expr\Closure $functionLike
|
|
*/
|
|
private function hasFunctionOrClosureInside($functionLike, \PhpParser\Node\Expr\Variable $variable) : bool
|
|
{
|
|
if ($functionLike->stmts === null) {
|
|
return \false;
|
|
}
|
|
return (bool) $this->betterNodeFinder->findFirst($functionLike->stmts, function (\PhpParser\Node $node) use($variable) : bool {
|
|
if (!$node instanceof \PhpParser\Node\Expr\Closure && !$node instanceof \PhpParser\Node\Stmt\Function_) {
|
|
return \false;
|
|
}
|
|
if ($node->params !== []) {
|
|
return \false;
|
|
}
|
|
$assign = $this->matchFuncGetArgsVariableAssign($node);
|
|
if (!$assign instanceof \PhpParser\Node\Expr\Assign) {
|
|
return \false;
|
|
}
|
|
return $this->nodeComparator->areNodesEqual($assign->var, $variable);
|
|
});
|
|
}
|
|
/**
|
|
* @param \PhpParser\Node\Stmt\ClassMethod|\PhpParser\Node\Stmt\Function_|\PhpParser\Node\Expr\Closure $functionLike
|
|
*/
|
|
private function matchFuncGetArgsVariableAssign($functionLike) : ?\PhpParser\Node\Expr\Assign
|
|
{
|
|
/** @var Assign[] $assigns */
|
|
$assigns = $this->betterNodeFinder->findInstanceOf((array) $functionLike->stmts, \PhpParser\Node\Expr\Assign::class);
|
|
foreach ($assigns as $assign) {
|
|
if (!$assign->expr instanceof \PhpParser\Node\Expr\FuncCall) {
|
|
continue;
|
|
}
|
|
if (!$this->isName($assign->expr, 'func_get_args')) {
|
|
continue;
|
|
}
|
|
return $assign;
|
|
}
|
|
return null;
|
|
}
|
|
private function createVariadicParam(string $variableName) : \PhpParser\Node\Param
|
|
{
|
|
$variable = new \PhpParser\Node\Expr\Variable($variableName);
|
|
return new \PhpParser\Node\Param($variable, null, null, \false, \true);
|
|
}
|
|
}
|