rector/rules/DeadCode/Rector/Assign/RemoveDoubleAssignRector.php
Tomas Votruba 96112cb1f0 Updated Rector to commit 2da49992cc
2da49992cc [Downgrade] [PHP 7.2] Make DowngradeParameterTypeWideningRector always downgrade to phpdoc type (#390)
2021-07-05 22:50:18 +00:00

102 lines
4.1 KiB
PHP

<?php
declare (strict_types=1);
namespace Rector\DeadCode\Rector\Assign;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Expr\StaticPropertyFetch;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Stmt\Expression;
use Rector\Core\Rector\AbstractRector;
use Rector\NodeNestingScope\ScopeNestingComparator;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\DeadCode\Rector\Assign\RemoveDoubleAssignRector\RemoveDoubleAssignRectorTest
*/
final class RemoveDoubleAssignRector extends \Rector\Core\Rector\AbstractRector
{
/**
* @var \Rector\NodeNestingScope\ScopeNestingComparator
*/
private $scopeNestingComparator;
public function __construct(\Rector\NodeNestingScope\ScopeNestingComparator $scopeNestingComparator)
{
$this->scopeNestingComparator = $scopeNestingComparator;
}
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
{
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Simplify useless double assigns', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
$value = 1;
$value = 1;
CODE_SAMPLE
, '$value = 1;')]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [\PhpParser\Node\Expr\Assign::class];
}
/**
* @param Assign $node
*/
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
{
if (!$node->var instanceof \PhpParser\Node\Expr\Variable && !$node->var instanceof \PhpParser\Node\Expr\PropertyFetch && !$node->var instanceof \PhpParser\Node\Expr\StaticPropertyFetch) {
return null;
}
$previousStatement = $node->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::PREVIOUS_STATEMENT);
if (!$previousStatement instanceof \PhpParser\Node\Stmt\Expression) {
return null;
}
if (!$previousStatement->expr instanceof \PhpParser\Node\Expr\Assign) {
return null;
}
if (!$this->nodeComparator->areNodesEqual($previousStatement->expr->var, $node->var)) {
return null;
}
if ($this->isCall($previousStatement->expr->expr)) {
return null;
}
if ($this->shouldSkipForDifferentScope($node, $previousStatement)) {
return null;
}
if ($this->isSelfReferencing($node)) {
return null;
}
// no calls on right, could hide e.g. array_pop()|array_shift()
$this->removeNode($previousStatement);
return $node;
}
private function isCall(\PhpParser\Node\Expr $expr) : bool
{
return $expr instanceof \PhpParser\Node\Expr\FuncCall || $expr instanceof \PhpParser\Node\Expr\StaticCall || $expr instanceof \PhpParser\Node\Expr\MethodCall;
}
private function shouldSkipForDifferentScope(\PhpParser\Node\Expr\Assign $assign, \PhpParser\Node\Stmt\Expression $expression) : bool
{
if (!$this->areInSameClassMethod($assign, $expression)) {
return \true;
}
return !$this->scopeNestingComparator->areScopeNestingEqual($assign, $expression);
}
private function isSelfReferencing(\PhpParser\Node\Expr\Assign $assign) : bool
{
return (bool) $this->betterNodeFinder->findFirst($assign->expr, function (\PhpParser\Node $subNode) use($assign) : bool {
return $this->nodeComparator->areNodesEqual($assign->var, $subNode);
});
}
private function areInSameClassMethod(\PhpParser\Node\Expr\Assign $assign, \PhpParser\Node\Stmt\Expression $previousExpression) : bool
{
return $this->nodeComparator->areNodesEqual($assign->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::METHOD_NODE), $previousExpression->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::METHOD_NODE));
}
}