rector/rules/DeadCode/Rector/BinaryOp/RemoveDuplicatedInstanceOfRector.php
Tomas Votruba 96112cb1f0 Updated Rector to commit 2da49992cc
2da49992cc [Downgrade] [PHP 7.2] Make DowngradeParameterTypeWideningRector always downgrade to phpdoc type (#390)
2021-07-05 22:50:18 +00:00

92 lines
3.0 KiB
PHP

<?php
declare (strict_types=1);
namespace Rector\DeadCode\Rector\BinaryOp;
use PhpParser\Node;
use PhpParser\Node\Expr\BinaryOp;
use PhpParser\Node\Expr\Instanceof_;
use Rector\Core\Rector\AbstractRector;
use Rector\DeadCode\NodeAnalyzer\InstanceOfUniqueKeyResolver;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\DeadCode\Rector\BinaryOp\RemoveDuplicatedInstanceOfRector\RemoveDuplicatedInstanceOfRectorTest
*/
final class RemoveDuplicatedInstanceOfRector extends \Rector\Core\Rector\AbstractRector
{
/**
* @var \Rector\DeadCode\NodeAnalyzer\InstanceOfUniqueKeyResolver
*/
private $instanceOfUniqueKeyResolver;
public function __construct(\Rector\DeadCode\NodeAnalyzer\InstanceOfUniqueKeyResolver $instanceOfUniqueKeyResolver)
{
$this->instanceOfUniqueKeyResolver = $instanceOfUniqueKeyResolver;
}
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
{
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Remove duplicated instanceof in one call', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function run($value)
{
$isIt = $value instanceof A || $value instanceof A;
$isIt = $value instanceof A && $value instanceof A;
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function run($value): void
{
$isIt = $value instanceof A;
$isIt = $value instanceof A;
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [\PhpParser\Node\Expr\BinaryOp::class];
}
/**
* @param BinaryOp $node
*/
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
{
$duplicatedInstanceOfs = $this->resolveDuplicatedInstancesOf($node);
if ($duplicatedInstanceOfs === []) {
return null;
}
$this->removeNodes($duplicatedInstanceOfs);
return $node;
}
/**
* @return Instanceof_[]
*/
private function resolveDuplicatedInstancesOf(\PhpParser\Node\Expr\BinaryOp $binaryOp) : array
{
$duplicatedInstanceOfs = [];
/** @var Instanceof_[] $instanceOfs */
$instanceOfs = $this->betterNodeFinder->findInstanceOf($binaryOp, \PhpParser\Node\Expr\Instanceof_::class);
$uniqueInstanceOfKeys = [];
foreach ($instanceOfs as $instanceOf) {
$uniqueKey = $this->instanceOfUniqueKeyResolver->resolve($instanceOf);
if ($uniqueKey === null) {
continue;
}
// already present before → duplicated
if (\in_array($uniqueKey, $uniqueInstanceOfKeys, \true)) {
$duplicatedInstanceOfs[] = $instanceOf;
}
$uniqueInstanceOfKeys[] = $uniqueKey;
}
return $duplicatedInstanceOfs;
}
}