mirror of
https://github.com/rectorphp/rector.git
synced 2024-05-28 23:10:51 +00:00
96112cb1f0
2da49992cc
[Downgrade] [PHP 7.2] Make DowngradeParameterTypeWideningRector always downgrade to phpdoc type (#390)
133 lines
3.6 KiB
PHP
133 lines
3.6 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\DeadCode\Rector\For_;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr;
|
|
use PhpParser\Node\Expr\Variable;
|
|
use PhpParser\Node\Scalar;
|
|
use PhpParser\Node\Stmt\For_;
|
|
use PhpParser\Node\Stmt\Foreach_;
|
|
use PhpParser\Node\Stmt\If_;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\EarlyReturn\NodeTransformer\ConditionInverter;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Tests\DeadCode\Rector\For_\RemoveDeadIfForeachForRector\RemoveDeadIfForeachForRectorTest
|
|
*/
|
|
final class RemoveDeadIfForeachForRector extends \Rector\Core\Rector\AbstractRector
|
|
{
|
|
/**
|
|
* @var \Rector\EarlyReturn\NodeTransformer\ConditionInverter
|
|
*/
|
|
private $conditionInverter;
|
|
public function __construct(\Rector\EarlyReturn\NodeTransformer\ConditionInverter $conditionInverter)
|
|
{
|
|
$this->conditionInverter = $conditionInverter;
|
|
}
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Remove if, foreach and for that does not do anything', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run($someObject)
|
|
{
|
|
$value = 5;
|
|
if ($value) {
|
|
}
|
|
|
|
if ($someObject->run()) {
|
|
}
|
|
|
|
foreach ($values as $value) {
|
|
}
|
|
|
|
return $value;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run($someObject)
|
|
{
|
|
$value = 5;
|
|
if ($someObject->run()) {
|
|
}
|
|
|
|
return $value;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Stmt\For_::class, \PhpParser\Node\Stmt\If_::class, \PhpParser\Node\Stmt\Foreach_::class];
|
|
}
|
|
/**
|
|
* @param For_|If_|Foreach_ $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
if ($node instanceof \PhpParser\Node\Stmt\If_) {
|
|
$this->processIf($node);
|
|
return null;
|
|
}
|
|
if ($node instanceof \PhpParser\Node\Stmt\Foreach_) {
|
|
$this->processForeach($node);
|
|
return null;
|
|
}
|
|
// For
|
|
if ($node->stmts !== []) {
|
|
return null;
|
|
}
|
|
$this->removeNode($node);
|
|
return null;
|
|
}
|
|
private function processIf(\PhpParser\Node\Stmt\If_ $if) : void
|
|
{
|
|
if ($if->stmts !== []) {
|
|
return;
|
|
}
|
|
if ($if->elseifs !== []) {
|
|
return;
|
|
}
|
|
if ($if->else !== null) {
|
|
$if->cond = $this->conditionInverter->createInvertedCondition($if->cond);
|
|
$if->stmts = $if->else->stmts;
|
|
$if->else = null;
|
|
return;
|
|
}
|
|
if ($this->isNodeWithSideEffect($if->cond)) {
|
|
return;
|
|
}
|
|
$this->removeNode($if);
|
|
}
|
|
private function processForeach(\PhpParser\Node\Stmt\Foreach_ $foreach) : void
|
|
{
|
|
if ($foreach->stmts !== []) {
|
|
return;
|
|
}
|
|
if ($this->isNodeWithSideEffect($foreach->expr)) {
|
|
return;
|
|
}
|
|
$this->removeNode($foreach);
|
|
}
|
|
private function isNodeWithSideEffect(\PhpParser\Node\Expr $expr) : bool
|
|
{
|
|
if ($expr instanceof \PhpParser\Node\Expr\Variable) {
|
|
return \false;
|
|
}
|
|
if ($expr instanceof \PhpParser\Node\Scalar) {
|
|
return \false;
|
|
}
|
|
return !$this->valueResolver->isTrueOrFalse($expr);
|
|
}
|
|
}
|