rector/rules/DependencyInjection/Rector/Class_/ActionInjectionToConstructorInjectionRector.php
Tomas Votruba c4c84e0db7 Updated Rector to commit 34fff11f80
34fff11f80 Remove deprecated addConstructorDependencyToClass() from AbstractRector class, use PropertyToAddCollector directly instaed (#506)
2021-07-25 11:42:11 +00:00

124 lines
4.6 KiB
PHP

<?php
declare (strict_types=1);
namespace Rector\DependencyInjection\Rector\Class_;
use PhpParser\Node;
use PhpParser\Node\Param;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PHPStan\Type\ObjectType;
use Rector\Core\Rector\AbstractRector;
use Rector\DependencyInjection\Collector\VariablesToPropertyFetchCollection;
use Rector\PostRector\Collector\PropertyToAddCollector;
use Rector\PostRector\ValueObject\PropertyMetadata;
use Rector\Symfony\DataProvider\ServiceMapProvider;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\DependencyInjection\Rector\Class_\ActionInjectionToConstructorInjectionRector\ActionInjectionToConstructorInjectionRectorTest
*/
final class ActionInjectionToConstructorInjectionRector extends \Rector\Core\Rector\AbstractRector
{
/**
* @var \Rector\Symfony\DataProvider\ServiceMapProvider
*/
private $applicationServiceMapProvider;
/**
* @var \Rector\DependencyInjection\Collector\VariablesToPropertyFetchCollection
*/
private $variablesToPropertyFetchCollection;
/**
* @var \Rector\PostRector\Collector\PropertyToAddCollector
*/
private $propertyToAddCollector;
public function __construct(\Rector\Symfony\DataProvider\ServiceMapProvider $applicationServiceMapProvider, \Rector\DependencyInjection\Collector\VariablesToPropertyFetchCollection $variablesToPropertyFetchCollection, \Rector\PostRector\Collector\PropertyToAddCollector $propertyToAddCollector)
{
$this->applicationServiceMapProvider = $applicationServiceMapProvider;
$this->variablesToPropertyFetchCollection = $variablesToPropertyFetchCollection;
$this->propertyToAddCollector = $propertyToAddCollector;
}
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
{
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Turns action injection in Controllers to constructor injection', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
final class SomeController
{
public function default(ProductRepository $productRepository)
{
$products = $productRepository->fetchAll();
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
final class SomeController
{
/**
* @var ProductRepository
*/
private $productRepository;
public function __construct(ProductRepository $productRepository)
{
$this->productRepository = $productRepository;
}
public function default()
{
$products = $this->productRepository->fetchAll();
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [\PhpParser\Node\Stmt\Class_::class];
}
/**
* @param Class_ $node
*/
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
{
if (!$this->isName($node, '*Controller')) {
return null;
}
foreach ($node->getMethods() as $classMethod) {
$this->processClassMethod($node, $classMethod);
}
return $node;
}
private function processClassMethod(\PhpParser\Node\Stmt\Class_ $class, \PhpParser\Node\Stmt\ClassMethod $classMethod) : void
{
foreach ($classMethod->params as $key => $paramNode) {
if (!$this->isActionInjectedParamNode($paramNode)) {
continue;
}
$paramType = $this->getObjectType($paramNode);
/** @var string $paramName */
$paramName = $this->getName($paramNode->var);
$propertyMetadata = new \Rector\PostRector\ValueObject\PropertyMetadata($paramName, $paramType, \PhpParser\Node\Stmt\Class_::MODIFIER_PRIVATE);
$this->propertyToAddCollector->addPropertyToClass($class, $propertyMetadata);
$this->nodeRemover->removeParam($classMethod, $key);
$this->variablesToPropertyFetchCollection->addVariableNameAndType($paramName, $paramType);
}
}
private function isActionInjectedParamNode(\PhpParser\Node\Param $param) : bool
{
if ($param->type === null) {
return \false;
}
$typehint = $this->getName($param->type);
if ($typehint === null) {
return \false;
}
$paramStaticType = $this->getObjectType($param);
if (!$paramStaticType instanceof \PHPStan\Type\ObjectType) {
return \false;
}
$serviceMap = $this->applicationServiceMapProvider->provide();
return $serviceMap->hasService($paramStaticType->getClassName());
}
}