mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-04 02:10:51 +00:00
96112cb1f0
2da49992cc
[Downgrade] [PHP 7.2] Make DowngradeParameterTypeWideningRector always downgrade to phpdoc type (#390)
163 lines
5.2 KiB
PHP
163 lines
5.2 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Order\Rector\Class_;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\MethodCall;
|
|
use PhpParser\Node\Expr\Variable;
|
|
use PhpParser\Node\Stmt\Class_;
|
|
use PhpParser\Node\Stmt\ClassLike;
|
|
use PhpParser\Node\Stmt\ClassMethod;
|
|
use PhpParser\Node\Stmt\Trait_;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\Order\StmtOrder;
|
|
use Rector\Order\ValueObject\SortedClassMethodsAndOriginalClassMethods;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Tests\Order\Rector\Class_\OrderPrivateMethodsByUseRector\OrderPrivateMethodsByUseRectorTest
|
|
*/
|
|
final class OrderPrivateMethodsByUseRector extends \Rector\Core\Rector\AbstractRector
|
|
{
|
|
/**
|
|
* @var int
|
|
*/
|
|
private const MAX_ATTEMPTS = 5;
|
|
/**
|
|
* @var \Rector\Order\StmtOrder
|
|
*/
|
|
private $stmtOrder;
|
|
public function __construct(\Rector\Order\StmtOrder $stmtOrder)
|
|
{
|
|
$this->stmtOrder = $stmtOrder;
|
|
}
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Order private methods in order of their use', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
$this->call1();
|
|
$this->call2();
|
|
}
|
|
|
|
private function call2()
|
|
{
|
|
}
|
|
|
|
private function call1()
|
|
{
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
$this->call1();
|
|
$this->call2();
|
|
}
|
|
|
|
private function call1()
|
|
{
|
|
}
|
|
|
|
private function call2()
|
|
{
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Stmt\Class_::class, \PhpParser\Node\Stmt\Trait_::class];
|
|
}
|
|
/**
|
|
* @param Class_|Trait_ $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
$sortedAndOriginalClassMethods = $this->getSortedAndOriginalClassMethods($node);
|
|
// order is correct, nothing to change
|
|
if (!$sortedAndOriginalClassMethods->hasOrderChanged()) {
|
|
return null;
|
|
}
|
|
// different private method count, one of them is dead probably
|
|
$attempt = 0;
|
|
while (!$sortedAndOriginalClassMethods->hasOrderSame()) {
|
|
++$attempt;
|
|
if ($attempt >= self::MAX_ATTEMPTS) {
|
|
break;
|
|
}
|
|
$oldToNewKeys = $this->stmtOrder->createOldToNewKeys($sortedAndOriginalClassMethods->getSortedClassMethods(), $sortedAndOriginalClassMethods->getOriginalClassMethods());
|
|
$this->stmtOrder->reorderClassStmtsByOldToNewKeys($node, $oldToNewKeys);
|
|
$sortedAndOriginalClassMethods = $this->getSortedAndOriginalClassMethods($node);
|
|
}
|
|
return $node;
|
|
}
|
|
/**
|
|
* @param \PhpParser\Node\Stmt\Class_|\PhpParser\Node\Stmt\Trait_ $classLike
|
|
*/
|
|
private function getSortedAndOriginalClassMethods($classLike) : \Rector\Order\ValueObject\SortedClassMethodsAndOriginalClassMethods
|
|
{
|
|
return new \Rector\Order\ValueObject\SortedClassMethodsAndOriginalClassMethods($this->getLocalPrivateMethodCallOrder($classLike), $this->resolvePrivateClassMethods($classLike));
|
|
}
|
|
/**
|
|
* @return array<int, string>
|
|
*/
|
|
private function getLocalPrivateMethodCallOrder(\PhpParser\Node\Stmt\ClassLike $classLike) : array
|
|
{
|
|
$localPrivateMethodCallInOrder = [];
|
|
$this->traverseNodesWithCallable($classLike->getMethods(), function (\PhpParser\Node $node) use(&$localPrivateMethodCallInOrder, $classLike) {
|
|
if (!$node instanceof \PhpParser\Node\Expr\MethodCall) {
|
|
return null;
|
|
}
|
|
if (!$node->var instanceof \PhpParser\Node\Expr\Variable) {
|
|
return null;
|
|
}
|
|
if (!$this->nodeNameResolver->isName($node->var, 'this')) {
|
|
return null;
|
|
}
|
|
$methodName = $this->getName($node->name);
|
|
if ($methodName === null) {
|
|
return null;
|
|
}
|
|
$classMethod = $classLike->getMethod($methodName);
|
|
if (!$classMethod instanceof \PhpParser\Node\Stmt\ClassMethod) {
|
|
return null;
|
|
}
|
|
if ($classMethod->isPrivate()) {
|
|
$localPrivateMethodCallInOrder[] = $methodName;
|
|
}
|
|
return null;
|
|
});
|
|
return \array_unique($localPrivateMethodCallInOrder);
|
|
}
|
|
/**
|
|
* @return array<int, string>
|
|
*/
|
|
private function resolvePrivateClassMethods(\PhpParser\Node\Stmt\ClassLike $classLike) : array
|
|
{
|
|
$privateClassMethods = [];
|
|
foreach ($classLike->stmts as $key => $classStmt) {
|
|
if (!$classStmt instanceof \PhpParser\Node\Stmt\ClassMethod) {
|
|
continue;
|
|
}
|
|
if (!$classStmt->isPrivate()) {
|
|
continue;
|
|
}
|
|
/** @var string $classMethodName */
|
|
$classMethodName = $this->getName($classStmt);
|
|
$privateClassMethods[$key] = $classMethodName;
|
|
}
|
|
return $privateClassMethods;
|
|
}
|
|
}
|