mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-04 02:10:51 +00:00
1127b0c4e2
bc9d2d48d5
[DX] Add MissedRectorDueVersionChecker (#465)
139 lines
5.8 KiB
PHP
139 lines
5.8 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Php71\Rector\FuncCall;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Arg;
|
|
use PhpParser\Node\Expr;
|
|
use PhpParser\Node\Expr\BinaryOp\BooleanOr;
|
|
use PhpParser\Node\Expr\BinaryOp\Identical;
|
|
use PhpParser\Node\Expr\Cast\Array_;
|
|
use PhpParser\Node\Expr\FuncCall;
|
|
use PhpParser\Node\Expr\Instanceof_;
|
|
use PhpParser\Node\Expr\Ternary;
|
|
use PhpParser\Node\Name;
|
|
use PhpParser\Node\Name\FullyQualified;
|
|
use PhpParser\Node\Scalar\LNumber;
|
|
use PhpParser\Node\Stmt\Trait_;
|
|
use PHPStan\Type\ArrayType;
|
|
use PHPStan\Type\NullType;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\Core\ValueObject\PhpVersionFeature;
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
|
use Rector\NodeTypeResolver\TypeAnalyzer\CountableTypeAnalyzer;
|
|
use Rector\Php71\NodeAnalyzer\CountableAnalyzer;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see https://3v4l.org/Bndc9
|
|
*
|
|
* @see \Rector\Tests\Php71\Rector\FuncCall\CountOnNullRector\CountOnNullRectorTest
|
|
*/
|
|
final class CountOnNullRector extends \Rector\Core\Rector\AbstractRector
|
|
{
|
|
/**
|
|
* @var string
|
|
*/
|
|
private const ALREADY_CHANGED_ON_COUNT = 'already_changed_on_count';
|
|
/**
|
|
* @var \Rector\NodeTypeResolver\TypeAnalyzer\CountableTypeAnalyzer
|
|
*/
|
|
private $countableTypeAnalyzer;
|
|
/**
|
|
* @var \Rector\Php71\NodeAnalyzer\CountableAnalyzer
|
|
*/
|
|
private $countableAnalyzer;
|
|
public function __construct(\Rector\NodeTypeResolver\TypeAnalyzer\CountableTypeAnalyzer $countableTypeAnalyzer, \Rector\Php71\NodeAnalyzer\CountableAnalyzer $countableAnalyzer)
|
|
{
|
|
$this->countableTypeAnalyzer = $countableTypeAnalyzer;
|
|
$this->countableAnalyzer = $countableAnalyzer;
|
|
}
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Changes count() on null to safe ternary check', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
$values = null;
|
|
$count = count($values);
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
$values = null;
|
|
$count = count((array) $values);
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Expr\FuncCall::class];
|
|
}
|
|
/**
|
|
* @param FuncCall $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
if ($this->shouldSkip($node)) {
|
|
return null;
|
|
}
|
|
$countedNode = $node->args[0]->value;
|
|
if ($this->countableTypeAnalyzer->isCountableType($countedNode)) {
|
|
return null;
|
|
}
|
|
// this can lead to false positive by phpstan, but that's best we can do
|
|
$onlyValueType = $this->getStaticType($countedNode);
|
|
if ($onlyValueType instanceof \PHPStan\Type\ArrayType) {
|
|
if (!$this->countableAnalyzer->isCastableArrayType($countedNode)) {
|
|
return null;
|
|
}
|
|
return $this->castToArray($countedNode, $node);
|
|
}
|
|
if ($this->nodeTypeResolver->isNullableTypeOfSpecificType($countedNode, \PHPStan\Type\ArrayType::class)) {
|
|
return $this->castToArray($countedNode, $node);
|
|
}
|
|
if ($this->nodeTypeResolver->isNullableType($countedNode) || $this->nodeTypeResolver->isStaticType($countedNode, \PHPStan\Type\NullType::class)) {
|
|
$identical = new \PhpParser\Node\Expr\BinaryOp\Identical($countedNode, $this->nodeFactory->createNull());
|
|
$ternary = new \PhpParser\Node\Expr\Ternary($identical, new \PhpParser\Node\Scalar\LNumber(0), $node);
|
|
// prevent infinity loop re-resolution
|
|
$node->setAttribute(self::ALREADY_CHANGED_ON_COUNT, \true);
|
|
return $ternary;
|
|
}
|
|
if ($this->phpVersionProvider->isAtLeastPhpVersion(\Rector\Core\ValueObject\PhpVersionFeature::IS_COUNTABLE)) {
|
|
$conditionNode = new \PhpParser\Node\Expr\FuncCall(new \PhpParser\Node\Name('is_countable'), [new \PhpParser\Node\Arg($countedNode)]);
|
|
} else {
|
|
$instanceof = new \PhpParser\Node\Expr\Instanceof_($countedNode, new \PhpParser\Node\Name\FullyQualified('Countable'));
|
|
$conditionNode = new \PhpParser\Node\Expr\BinaryOp\BooleanOr($this->nodeFactory->createFuncCall('is_array', [new \PhpParser\Node\Arg($countedNode)]), $instanceof);
|
|
}
|
|
// prevent infinity loop re-resolution
|
|
$node->setAttribute(self::ALREADY_CHANGED_ON_COUNT, \true);
|
|
return new \PhpParser\Node\Expr\Ternary($conditionNode, $node, new \PhpParser\Node\Scalar\LNumber(0));
|
|
}
|
|
private function shouldSkip(\PhpParser\Node\Expr\FuncCall $funcCall) : bool
|
|
{
|
|
if (!$this->isName($funcCall, 'count')) {
|
|
return \true;
|
|
}
|
|
$alreadyChangedOnCount = $funcCall->getAttribute(self::ALREADY_CHANGED_ON_COUNT);
|
|
// check if it has some condition before already, if so, probably it's already handled
|
|
if ($alreadyChangedOnCount) {
|
|
return \true;
|
|
}
|
|
$parentNode = $funcCall->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::PARENT_NODE);
|
|
if ($parentNode instanceof \PhpParser\Node\Expr\Ternary) {
|
|
return \true;
|
|
}
|
|
if (!isset($funcCall->args[0])) {
|
|
return \true;
|
|
}
|
|
// skip node in trait, as impossible to analyse
|
|
$classLike = $funcCall->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::CLASS_NODE);
|
|
return $classLike instanceof \PhpParser\Node\Stmt\Trait_;
|
|
}
|
|
private function castToArray(\PhpParser\Node\Expr $countedExpr, \PhpParser\Node\Expr\FuncCall $funcCall) : \PhpParser\Node\Expr\FuncCall
|
|
{
|
|
$castArray = new \PhpParser\Node\Expr\Cast\Array_($countedExpr);
|
|
$funcCall->args = [new \PhpParser\Node\Arg($castArray)];
|
|
return $funcCall;
|
|
}
|
|
}
|