mirror of
https://github.com/rectorphp/rector.git
synced 2024-05-28 23:10:51 +00:00
cad500c817
0d3e54357f
extract VendorLocationDetector (#462)
172 lines
6.9 KiB
PHP
172 lines
6.9 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Php80\Rector\ClassMethod;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\MethodCall;
|
|
use PhpParser\Node\Expr\New_;
|
|
use PhpParser\Node\Stmt\ClassMethod;
|
|
use PHPStan\Reflection\MethodReflection;
|
|
use PHPStan\Reflection\ParametersAcceptorSelector;
|
|
use Rector\CodingStyle\Reflection\VendorLocationDetector;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\Core\Reflection\ReflectionResolver;
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
|
use Rector\Php80\NodeResolver\ArgumentSorter;
|
|
use Rector\Php80\NodeResolver\RequireOptionalParamResolver;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @changelog https://php.watch/versions/8.0#deprecate-required-param-after-optional
|
|
*
|
|
* @see \Rector\Tests\Php80\Rector\ClassMethod\OptionalParametersAfterRequiredRector\OptionalParametersAfterRequiredRectorTest
|
|
*/
|
|
final class OptionalParametersAfterRequiredRector extends \Rector\Core\Rector\AbstractRector
|
|
{
|
|
/**
|
|
* @var string
|
|
*/
|
|
private const ALREADY_SORTED = 'already_sorted';
|
|
/**
|
|
* @var \Rector\Php80\NodeResolver\RequireOptionalParamResolver
|
|
*/
|
|
private $requireOptionalParamResolver;
|
|
/**
|
|
* @var \Rector\Php80\NodeResolver\ArgumentSorter
|
|
*/
|
|
private $argumentSorter;
|
|
/**
|
|
* @var \Rector\Core\Reflection\ReflectionResolver
|
|
*/
|
|
private $reflectionResolver;
|
|
/**
|
|
* @var \Rector\CodingStyle\Reflection\VendorLocationDetector
|
|
*/
|
|
private $vendorLocationDetector;
|
|
public function __construct(\Rector\Php80\NodeResolver\RequireOptionalParamResolver $requireOptionalParamResolver, \Rector\Php80\NodeResolver\ArgumentSorter $argumentSorter, \Rector\Core\Reflection\ReflectionResolver $reflectionResolver, \Rector\CodingStyle\Reflection\VendorLocationDetector $vendorLocationDetector)
|
|
{
|
|
$this->requireOptionalParamResolver = $requireOptionalParamResolver;
|
|
$this->argumentSorter = $argumentSorter;
|
|
$this->reflectionResolver = $reflectionResolver;
|
|
$this->vendorLocationDetector = $vendorLocationDetector;
|
|
}
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Move required parameters after optional ones', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeObject
|
|
{
|
|
public function run($optional = 1, $required)
|
|
{
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeObject
|
|
{
|
|
public function run($required, $optional = 1)
|
|
{
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Stmt\ClassMethod::class, \PhpParser\Node\Expr\New_::class, \PhpParser\Node\Expr\MethodCall::class];
|
|
}
|
|
/**
|
|
* @param ClassMethod|New_|MethodCall $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
$isAlreadySorted = $node->getAttribute(self::ALREADY_SORTED);
|
|
if ($isAlreadySorted) {
|
|
return null;
|
|
}
|
|
if ($node instanceof \PhpParser\Node\Stmt\ClassMethod) {
|
|
return $this->refactorClassMethod($node);
|
|
}
|
|
if ($node instanceof \PhpParser\Node\Expr\New_) {
|
|
return $this->refactorNew($node);
|
|
}
|
|
return $this->refactorMethodCall($node);
|
|
}
|
|
private function refactorClassMethod(\PhpParser\Node\Stmt\ClassMethod $classMethod) : ?\PhpParser\Node\Stmt\ClassMethod
|
|
{
|
|
if ($classMethod->params === []) {
|
|
return null;
|
|
}
|
|
$classMethod->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::CLASS_NAME);
|
|
$classMethodReflection = $this->reflectionResolver->resolveMethodReflectionFromClassMethod($classMethod);
|
|
if (!$classMethodReflection instanceof \PHPStan\Reflection\MethodReflection) {
|
|
return null;
|
|
}
|
|
$expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($classMethodReflection, $classMethod->params);
|
|
if ($expectedArgOrParamOrder === null) {
|
|
return null;
|
|
}
|
|
$newParams = $this->argumentSorter->sortArgsByExpectedParamOrder($classMethod->params, $expectedArgOrParamOrder);
|
|
$classMethod->params = $newParams;
|
|
$classMethod->setAttribute(self::ALREADY_SORTED, \true);
|
|
return $classMethod;
|
|
}
|
|
private function refactorNew(\PhpParser\Node\Expr\New_ $new) : ?\PhpParser\Node\Expr\New_
|
|
{
|
|
if ($new->args === []) {
|
|
return null;
|
|
}
|
|
$methodReflection = $this->reflectionResolver->resolveMethodReflectionFromNew($new);
|
|
if (!$methodReflection instanceof \PHPStan\Reflection\MethodReflection) {
|
|
return null;
|
|
}
|
|
$expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($methodReflection, $new->args);
|
|
if ($expectedArgOrParamOrder === null) {
|
|
return null;
|
|
}
|
|
$new->args = $this->argumentSorter->sortArgsByExpectedParamOrder($new->args, $expectedArgOrParamOrder);
|
|
$new->setAttribute(self::ALREADY_SORTED, \true);
|
|
return $new;
|
|
}
|
|
private function refactorMethodCall(\PhpParser\Node\Expr\MethodCall $methodCall) : ?\PhpParser\Node\Expr\MethodCall
|
|
{
|
|
$methodReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($methodCall);
|
|
if (!$methodReflection instanceof \PHPStan\Reflection\MethodReflection) {
|
|
return null;
|
|
}
|
|
$expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($methodReflection, $methodCall->args);
|
|
if ($expectedArgOrParamOrder === null) {
|
|
return null;
|
|
}
|
|
$newArgs = $this->argumentSorter->sortArgsByExpectedParamOrder($methodCall->args, $expectedArgOrParamOrder);
|
|
if ($methodCall->args === $newArgs) {
|
|
return null;
|
|
}
|
|
$methodCall->args = $newArgs;
|
|
$methodCall->setAttribute(self::ALREADY_SORTED, \true);
|
|
return $methodCall;
|
|
}
|
|
/**
|
|
* @param array<Node\Arg|Node\Param> $argsOrParams
|
|
* @return int[]|null
|
|
*/
|
|
private function resolveExpectedArgParamOrderIfDifferent(\PHPStan\Reflection\MethodReflection $methodReflection, array $argsOrParams) : ?array
|
|
{
|
|
if ($this->vendorLocationDetector->detectFunctionLikeReflection($methodReflection)) {
|
|
return null;
|
|
}
|
|
$parametersAcceptor = \PHPStan\Reflection\ParametersAcceptorSelector::selectSingle($methodReflection->getVariants());
|
|
$expectedParameterReflections = $this->requireOptionalParamResolver->resolveFromReflection($methodReflection);
|
|
if (\count($argsOrParams) !== \count($parametersAcceptor->getParameters())) {
|
|
return null;
|
|
}
|
|
if ($expectedParameterReflections === $parametersAcceptor->getParameters()) {
|
|
return null;
|
|
}
|
|
return \array_keys($expectedParameterReflections);
|
|
}
|
|
}
|