mirror of
https://github.com/rectorphp/rector.git
synced 2024-05-28 23:10:51 +00:00
74fd096ad7
46a6ab042e
[PHP 8.0] Fix strinable interface detection (#542)
88 lines
2.9 KiB
PHP
88 lines
2.9 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Php80\Rector\Class_;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Name;
|
|
use PhpParser\Node\Name\FullyQualified;
|
|
use PhpParser\Node\Stmt\Class_;
|
|
use PhpParser\Node\Stmt\ClassMethod;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\Core\ValueObject\MethodName;
|
|
use Rector\FamilyTree\Reflection\FamilyRelationsAnalyzer;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @changelog https://wiki.php.net/rfc/stringable
|
|
*
|
|
* @see \Rector\Tests\Php80\Rector\Class_\StringableForToStringRector\StringableForToStringRectorTest
|
|
*/
|
|
final class StringableForToStringRector extends \Rector\Core\Rector\AbstractRector
|
|
{
|
|
/**
|
|
* @var string
|
|
*/
|
|
private const STRINGABLE = 'Stringable';
|
|
/**
|
|
* @var \Rector\FamilyTree\Reflection\FamilyRelationsAnalyzer
|
|
*/
|
|
private $familyRelationsAnalyzer;
|
|
public function __construct(\Rector\FamilyTree\Reflection\FamilyRelationsAnalyzer $familyRelationsAnalyzer)
|
|
{
|
|
$this->familyRelationsAnalyzer = $familyRelationsAnalyzer;
|
|
}
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Add `Stringable` interface to classes with `__toString()` method', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function __toString()
|
|
{
|
|
return 'I can stringz';
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass implements Stringable
|
|
{
|
|
public function __toString(): string
|
|
{
|
|
return 'I can stringz';
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Stmt\Class_::class];
|
|
}
|
|
/**
|
|
* @param Class_ $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
$toStringClassMethod = $node->getMethod(\Rector\Core\ValueObject\MethodName::TO_STRING);
|
|
if (!$toStringClassMethod instanceof \PhpParser\Node\Stmt\ClassMethod) {
|
|
return null;
|
|
}
|
|
// warning, classes that implements __toString() will return Stringable interface even if they don't implemen it
|
|
// reflection cannot be used for real detection
|
|
$classLikeAncestorNames = $this->familyRelationsAnalyzer->getClassLikeAncestorNames($node);
|
|
if (\in_array(self::STRINGABLE, $classLikeAncestorNames, \true)) {
|
|
return null;
|
|
}
|
|
// add interface
|
|
$node->implements[] = new \PhpParser\Node\Name\FullyQualified(self::STRINGABLE);
|
|
// add return type
|
|
if ($toStringClassMethod->returnType === null) {
|
|
$toStringClassMethod->returnType = new \PhpParser\Node\Name('string');
|
|
}
|
|
return $node;
|
|
}
|
|
}
|