mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-03 18:00:50 +00:00
96112cb1f0
2da49992cc
[Downgrade] [PHP 7.2] Make DowngradeParameterTypeWideningRector always downgrade to phpdoc type (#390)
107 lines
3.1 KiB
PHP
107 lines
3.1 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Privatization\Rector\MethodCall;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\MethodCall;
|
|
use PhpParser\Node\Expr\PropertyFetch;
|
|
use PhpParser\Node\Expr\Variable;
|
|
use PhpParser\Node\Stmt\Class_;
|
|
use PhpParser\Node\Stmt\ClassMethod;
|
|
use PhpParser\Node\Stmt\Return_;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Tests\Privatization\Rector\MethodCall\PrivatizeLocalGetterToPropertyRector\PrivatizeLocalGetterToPropertyRectorTest
|
|
*/
|
|
final class PrivatizeLocalGetterToPropertyRector extends \Rector\Core\Rector\AbstractRector
|
|
{
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Privatize getter of local property to property', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
private $some;
|
|
|
|
public function run()
|
|
{
|
|
return $this->getSome() + 5;
|
|
}
|
|
|
|
private function getSome()
|
|
{
|
|
return $this->some;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
private $some;
|
|
|
|
public function run()
|
|
{
|
|
return $this->some + 5;
|
|
}
|
|
|
|
private function getSome()
|
|
{
|
|
return $this->some;
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Expr\MethodCall::class];
|
|
}
|
|
/**
|
|
* @param MethodCall $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
if (!$node->var instanceof \PhpParser\Node\Expr\Variable) {
|
|
return null;
|
|
}
|
|
if (!$this->nodeNameResolver->isName($node->var, 'this')) {
|
|
return null;
|
|
}
|
|
$classLike = $node->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::CLASS_NODE);
|
|
if (!$classLike instanceof \PhpParser\Node\Stmt\Class_) {
|
|
return null;
|
|
}
|
|
$methodName = $this->getName($node->name);
|
|
if ($methodName === null) {
|
|
return null;
|
|
}
|
|
$classMethod = $classLike->getMethod($methodName);
|
|
if (!$classMethod instanceof \PhpParser\Node\Stmt\ClassMethod) {
|
|
return null;
|
|
}
|
|
return $this->matchLocalPropertyFetchInGetterMethod($classMethod);
|
|
}
|
|
private function matchLocalPropertyFetchInGetterMethod(\PhpParser\Node\Stmt\ClassMethod $classMethod) : ?\PhpParser\Node\Expr\PropertyFetch
|
|
{
|
|
$stmts = (array) $classMethod->stmts;
|
|
if (\count($stmts) !== 1) {
|
|
return null;
|
|
}
|
|
$onlyStmt = $stmts[0] ?? null;
|
|
if (!$onlyStmt instanceof \PhpParser\Node\Stmt\Return_) {
|
|
return null;
|
|
}
|
|
$returnedExpr = $onlyStmt->expr;
|
|
if (!$returnedExpr instanceof \PhpParser\Node\Expr\PropertyFetch) {
|
|
return null;
|
|
}
|
|
return $returnedExpr;
|
|
}
|
|
}
|