mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-03 18:00:50 +00:00
96112cb1f0
2da49992cc
[Downgrade] [PHP 7.2] Make DowngradeParameterTypeWideningRector always downgrade to phpdoc type (#390)
93 lines
3.0 KiB
PHP
93 lines
3.0 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Privatization\Rector\Property;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Stmt\Class_;
|
|
use PhpParser\Node\Stmt\Property;
|
|
use PHPStan\Analyser\Scope;
|
|
use PHPStan\Reflection\ClassReflection;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Tests\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector\PrivatizeFinalClassPropertyRectorTest
|
|
*/
|
|
final class PrivatizeFinalClassPropertyRector extends \Rector\Core\Rector\AbstractRector
|
|
{
|
|
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
|
|
{
|
|
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Change property to private if possible', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
|
|
final class SomeClass
|
|
{
|
|
protected $value;
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
final class SomeClass
|
|
{
|
|
private $value;
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [\PhpParser\Node\Stmt\Property::class];
|
|
}
|
|
/**
|
|
* @param Property $node
|
|
*/
|
|
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
|
|
{
|
|
$classLike = $node->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::CLASS_NODE);
|
|
if (!$classLike instanceof \PhpParser\Node\Stmt\Class_) {
|
|
return null;
|
|
}
|
|
if (!$classLike->isFinal()) {
|
|
return null;
|
|
}
|
|
if ($this->shouldSkipProperty($node)) {
|
|
return null;
|
|
}
|
|
if ($classLike->extends === null) {
|
|
$this->visibilityManipulator->makePrivate($node);
|
|
return $node;
|
|
}
|
|
if ($this->isPropertyVisibilityGuardedByParent($node, $classLike)) {
|
|
return null;
|
|
}
|
|
$this->visibilityManipulator->makePrivate($node);
|
|
return $node;
|
|
}
|
|
private function shouldSkipProperty(\PhpParser\Node\Stmt\Property $property) : bool
|
|
{
|
|
if (\count($property->props) !== 1) {
|
|
return \true;
|
|
}
|
|
return !$property->isProtected();
|
|
}
|
|
private function isPropertyVisibilityGuardedByParent(\PhpParser\Node\Stmt\Property $property, \PhpParser\Node\Stmt\Class_ $class) : bool
|
|
{
|
|
if ($class->extends === null) {
|
|
return \false;
|
|
}
|
|
/** @var Scope $scope */
|
|
$scope = $property->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::SCOPE);
|
|
/** @var ClassReflection $classReflection */
|
|
$classReflection = $scope->getClassReflection();
|
|
$propertyName = $this->getName($property);
|
|
foreach ($classReflection->getParents() as $parentClassReflection) {
|
|
if ($parentClassReflection->hasProperty($propertyName)) {
|
|
return \true;
|
|
}
|
|
}
|
|
return \false;
|
|
}
|
|
}
|