mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-08 20:22:24 +00:00
f7bb838601
f0425bc3cb
Improve scope, PHPStan extension types (#2747)
186 lines
6.7 KiB
PHP
186 lines
6.7 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\CodingStyle\Rector\Catch_;
|
|
|
|
use RectorPrefix202208\Nette\Utils\Strings;
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr\Assign;
|
|
use PhpParser\Node\Expr\Variable;
|
|
use PhpParser\Node\FunctionLike;
|
|
use PhpParser\Node\Stmt\Catch_;
|
|
use PhpParser\Node\Stmt\TryCatch;
|
|
use PHPStan\Type\ObjectType;
|
|
use Rector\Core\Rector\AbstractRector;
|
|
use Rector\Naming\Naming\AliasNameResolver;
|
|
use Rector\Naming\Naming\PropertyNaming;
|
|
use Rector\NodeTypeResolver\Node\AttributeKey;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Tests\CodingStyle\Rector\Catch_\CatchExceptionNameMatchingTypeRector\CatchExceptionNameMatchingTypeRectorTest
|
|
*/
|
|
final class CatchExceptionNameMatchingTypeRector extends AbstractRector
|
|
{
|
|
/**
|
|
* @var string
|
|
* @see https://regex101.com/r/xmfMAX/1
|
|
*/
|
|
private const STARTS_WITH_ABBREVIATION_REGEX = '#^([A-Za-z]+?)([A-Z]{1}[a-z]{1})([A-Za-z]*)#';
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\Naming\Naming\PropertyNaming
|
|
*/
|
|
private $propertyNaming;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\Naming\Naming\AliasNameResolver
|
|
*/
|
|
private $aliasNameResolver;
|
|
public function __construct(PropertyNaming $propertyNaming, AliasNameResolver $aliasNameResolver)
|
|
{
|
|
$this->propertyNaming = $propertyNaming;
|
|
$this->aliasNameResolver = $aliasNameResolver;
|
|
}
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Type and name of catch exception should match', [new CodeSample(<<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
try {
|
|
// ...
|
|
} catch (SomeException $typoException) {
|
|
$typoException->getMessage();
|
|
}
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
class SomeClass
|
|
{
|
|
public function run()
|
|
{
|
|
try {
|
|
// ...
|
|
} catch (SomeException $someException) {
|
|
$someException->getMessage();
|
|
}
|
|
}
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [Catch_::class];
|
|
}
|
|
/**
|
|
* @param Catch_ $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
if (\count($node->types) !== 1) {
|
|
return null;
|
|
}
|
|
if ($node->var === null) {
|
|
return null;
|
|
}
|
|
$oldVariableName = $this->getName($node->var);
|
|
if (!\is_string($oldVariableName)) {
|
|
return null;
|
|
}
|
|
$type = $node->types[0];
|
|
$typeShortName = $this->nodeNameResolver->getShortName($type);
|
|
$aliasName = $this->aliasNameResolver->resolveByName($type);
|
|
if (\is_string($aliasName)) {
|
|
$typeShortName = $aliasName;
|
|
}
|
|
$newVariableName = Strings::replace(\lcfirst($typeShortName), self::STARTS_WITH_ABBREVIATION_REGEX, static function (array $matches) : string {
|
|
$output = '';
|
|
$output .= isset($matches[1]) ? \strtolower((string) $matches[1]) : '';
|
|
$output .= $matches[2] ?? '';
|
|
return $output . ($matches[3] ?? '');
|
|
});
|
|
$objectType = new ObjectType($newVariableName);
|
|
$newVariableName = $this->propertyNaming->fqnToVariableName($objectType);
|
|
if ($oldVariableName === $newVariableName) {
|
|
return null;
|
|
}
|
|
$newVariable = new Variable($newVariableName);
|
|
$isFoundInPrevious = (bool) $this->betterNodeFinder->findFirstPrevious($node, function (Node $subNode) use($newVariable) : bool {
|
|
return $this->nodeComparator->areNodesEqual($subNode, $newVariable);
|
|
});
|
|
if ($isFoundInPrevious) {
|
|
return null;
|
|
}
|
|
$node->var->name = $newVariableName;
|
|
$this->renameVariableInStmts($node, $oldVariableName, $newVariableName);
|
|
return $node;
|
|
}
|
|
private function renameVariableInStmts(Catch_ $catch, string $oldVariableName, string $newVariableName) : void
|
|
{
|
|
$this->traverseNodesWithCallable($catch->stmts, function (Node $node) use($oldVariableName, $newVariableName) {
|
|
if (!$node instanceof Variable) {
|
|
return null;
|
|
}
|
|
if (!$this->nodeNameResolver->isName($node, $oldVariableName)) {
|
|
return null;
|
|
}
|
|
$node->name = $newVariableName;
|
|
return null;
|
|
});
|
|
/** @var TryCatch $tryCatch */
|
|
$tryCatch = $catch->getAttribute(AttributeKey::PARENT_NODE);
|
|
$nextNode = $tryCatch->getAttribute(AttributeKey::NEXT_NODE);
|
|
$this->replaceNextUsageVariable($tryCatch, $nextNode, $oldVariableName, $newVariableName);
|
|
}
|
|
private function replaceNextUsageVariable(Node $currentNode, ?Node $nextNode, string $oldVariableName, string $newVariableName) : void
|
|
{
|
|
if (!$nextNode instanceof Node) {
|
|
$parentNode = $currentNode->getAttribute(AttributeKey::PARENT_NODE);
|
|
if (!$parentNode instanceof Node) {
|
|
return;
|
|
}
|
|
if ($parentNode instanceof FunctionLike) {
|
|
return;
|
|
}
|
|
$nextNode = $parentNode->getAttribute(AttributeKey::NEXT_NODE);
|
|
$this->replaceNextUsageVariable($parentNode, $nextNode, $oldVariableName, $newVariableName);
|
|
return;
|
|
}
|
|
/** @var Variable[] $variables */
|
|
$variables = $this->betterNodeFinder->find($nextNode, function (Node $node) use($oldVariableName) : bool {
|
|
if (!$node instanceof Variable) {
|
|
return \false;
|
|
}
|
|
return $this->nodeNameResolver->isName($node, $oldVariableName);
|
|
});
|
|
$processRenameVariables = $this->processRenameVariable($variables, $oldVariableName, $newVariableName);
|
|
if (!$processRenameVariables) {
|
|
return;
|
|
}
|
|
$currentNode = $nextNode;
|
|
$nextNode = $nextNode->getAttribute(AttributeKey::NEXT_NODE);
|
|
$this->replaceNextUsageVariable($currentNode, $nextNode, $oldVariableName, $newVariableName);
|
|
}
|
|
/**
|
|
* @param Variable[] $variables
|
|
*/
|
|
private function processRenameVariable(array $variables, string $oldVariableName, string $newVariableName) : bool
|
|
{
|
|
foreach ($variables as $variable) {
|
|
$parentNode = $variable->getAttribute(AttributeKey::PARENT_NODE);
|
|
if ($parentNode instanceof Assign && $this->nodeComparator->areNodesEqual($parentNode->var, $variable) && $this->nodeNameResolver->isName($parentNode->var, $oldVariableName) && !$this->nodeComparator->areNodesEqual($parentNode->expr, $variable)) {
|
|
return \false;
|
|
}
|
|
$variable->name = $newVariableName;
|
|
}
|
|
return \true;
|
|
}
|
|
}
|