octoleo/restic
2
2
Fork 0
mirror of https://github.com/octoleo/restic.git synced 2024-12-21 18:39:04 +00:00
Code Issues Releases Wiki Activity
1ba0af6993
restic/changelog/0.15.2_2023-04-24/issue-4253

19 lines
925 B
Plaintext
Raw Normal View History

doc: Polish changelogs
2023-04-23 20:09:52 +00:00
Bugfix: Minimize risk of spurious filesystem loops with `mount`
fuse: Mix inode hashes in a non-symmetric way Since 0.15 (#4020), inodes are generated as hashes of names, xor'd with the parent inode. That means that the inode of a/b/b is h(a/b/b) = h(a) ^ h(b) ^ h(b) = h(a). I.e., the grandchild has the same inode as the grandparent. GNU find trips over this because it thinks it has encountered a loop in the filesystem, and fails to search a/b/b. This happens more generally when the same name occurs an even number of times. Fix this by multiplying the parent by a large prime, so the combining operation is not longer symmetric in its arguments. This is what the FNV hash does, which we used prior to 0.15. The hash is now h(a/b/b) = h(b) ^ p*(h(b) ^ p*h(a)) Note that we already ensure that h(x) is never zero. Collisions can still occur, but they should be much less likely to occur within a single path. Fixes #4253.
2023-03-21 16:33:18 +00:00
tweak changelogs
2023-04-23 10:40:29 +00:00
When a backup contains a directory that has the same name as its parent, say
doc: Polish changelogs
2023-04-23 20:09:52 +00:00
`a/b/b`, and the GNU `find` command was run on this backup in a restic mount,
tweak changelogs
2023-04-23 10:40:29 +00:00
`find` would refuse to traverse the lowest `b` directory, instead printing
doc: Polish changelogs
2023-04-23 20:09:52 +00:00
`File system loop detected`. This was due to the way the restic mount command
tweak changelogs
2023-04-23 10:40:29 +00:00
generates inode numbers for directories in the mount point.
fuse: Mix inode hashes in a non-symmetric way Since 0.15 (#4020), inodes are generated as hashes of names, xor'd with the parent inode. That means that the inode of a/b/b is h(a/b/b) = h(a) ^ h(b) ^ h(b) = h(a). I.e., the grandchild has the same inode as the grandparent. GNU find trips over this because it thinks it has encountered a loop in the filesystem, and fails to search a/b/b. This happens more generally when the same name occurs an even number of times. Fix this by multiplying the parent by a large prime, so the combining operation is not longer symmetric in its arguments. This is what the FNV hash does, which we used prior to 0.15. The hash is now h(a/b/b) = h(b) ^ p*(h(b) ^ p*h(a)) Note that we already ensure that h(x) is never zero. Collisions can still occur, but they should be much less likely to occur within a single path. Fixes #4253.
2023-03-21 16:33:18 +00:00
The rule for generating these inode numbers was changed in 0.15.0. It has
now been changed again to avoid this issue. A perfect rule does not exist,
but the probability of this behavior occurring is now extremely small.
doc: Polish changelogs
2023-04-23 20:09:52 +00:00
fuse: Mix inode hashes in a non-symmetric way Since 0.15 (#4020), inodes are generated as hashes of names, xor'd with the parent inode. That means that the inode of a/b/b is h(a/b/b) = h(a) ^ h(b) ^ h(b) = h(a). I.e., the grandchild has the same inode as the grandparent. GNU find trips over this because it thinks it has encountered a loop in the filesystem, and fails to search a/b/b. This happens more generally when the same name occurs an even number of times. Fix this by multiplying the parent by a large prime, so the combining operation is not longer symmetric in its arguments. This is what the FNV hash does, which we used prior to 0.15. The hash is now h(a/b/b) = h(b) ^ p*(h(b) ^ p*h(a)) Note that we already ensure that h(x) is never zero. Collisions can still occur, but they should be much less likely to occur within a single path. Fixes #4253.
2023-03-21 16:33:18 +00:00
When it does occur, the mount point is not broken, and scripts that traverse
the mount point should work as long as they don't rely on inode numbers for
detecting filesystem loops.
https://github.com/restic/restic/issues/4253
https://github.com/restic/restic/pull/4255
Copy Permalink