mirror of
https://github.com/octoleo/restic.git
synced 2024-12-22 19:08:55 +00:00
Return s3.fileInfos by pointer
Since the fileInfos are returned in a []interface, they're already allocated on the heap. Making them pointers explicitly means the compiler doesn't need to generate fileInfo and *fileInfo versions of the methods on this type. The binary becomes about 7KiB smaller on Linux/amd64.
This commit is contained in:
parent
d7322a5f36
commit
0d4f16b6ba
@ -186,12 +186,12 @@ type fileInfo struct {
|
||||
isDir bool
|
||||
}
|
||||
|
||||
func (fi fileInfo) Name() string { return fi.name } // base name of the file
|
||||
func (fi fileInfo) Size() int64 { return fi.size } // length in bytes for regular files; system-dependent for others
|
||||
func (fi fileInfo) Mode() os.FileMode { return fi.mode } // file mode bits
|
||||
func (fi fileInfo) ModTime() time.Time { return fi.modTime } // modification time
|
||||
func (fi fileInfo) IsDir() bool { return fi.isDir } // abbreviation for Mode().IsDir()
|
||||
func (fi fileInfo) Sys() interface{} { return nil } // underlying data source (can return nil)
|
||||
func (fi *fileInfo) Name() string { return fi.name } // base name of the file
|
||||
func (fi *fileInfo) Size() int64 { return fi.size } // length in bytes for regular files; system-dependent for others
|
||||
func (fi *fileInfo) Mode() os.FileMode { return fi.mode } // file mode bits
|
||||
func (fi *fileInfo) ModTime() time.Time { return fi.modTime } // modification time
|
||||
func (fi *fileInfo) IsDir() bool { return fi.isDir } // abbreviation for Mode().IsDir()
|
||||
func (fi *fileInfo) Sys() interface{} { return nil } // underlying data source (can return nil)
|
||||
|
||||
// ReadDir returns the entries for a directory.
|
||||
func (be *Backend) ReadDir(ctx context.Context, dir string) (list []os.FileInfo, err error) {
|
||||
@ -225,7 +225,7 @@ func (be *Backend) ReadDir(ctx context.Context, dir string) (list []os.FileInfo,
|
||||
if name == "" {
|
||||
continue
|
||||
}
|
||||
entry := fileInfo{
|
||||
entry := &fileInfo{
|
||||
name: name,
|
||||
size: obj.Size,
|
||||
modTime: obj.LastModified,
|
||||
|
Loading…
Reference in New Issue
Block a user