From 4c47c2b2c9fda4d8ec59d6131aefa3723b335390 Mon Sep 17 00:00:00 2001 From: Alexander Neumann Date: Wed, 26 Aug 2015 20:03:16 +0200 Subject: [PATCH] Address code review comments --- build.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/build.go b/build.go index d14566fc2..fe943d9e2 100644 --- a/build.go +++ b/build.go @@ -229,8 +229,8 @@ func gitVersion() string { return version } -// Constants represents a set constants set in the final binary to the given -// value. +// Constants represents a set of constants that are set in the final binary to +// the given value via compiler flags. type Constants map[string]string // LDFlags returns the string that can be passed to go build's `-ldflags`. @@ -318,7 +318,7 @@ func main() { die("remove GOPATH at %s failed: %v\n", err) } } else { - fmt.Printf("leaving temporary GOPATH at %v\n", gopath) + verbosePrintf("leaving temporary GOPATH at %v\n", gopath) } }() @@ -333,7 +333,7 @@ func main() { constants["main.version"] = version } ldflags := "-s " + constants.LDFlags() - fmt.Printf("ldflags: %s\n", ldflags) + verbosePrintf("ldflags: %s\n", ldflags) args := []string{ "-tags", strings.Join(buildTags, " "),