octoleo
/
restic
mirror of https://github.com/octoleo/restic.git
2
2
Fork 0
Code Issues Releases Wiki Activity

list: Never lock the repository when listing lock files 

There's no point in locking the repository just to list the currently
existing lock files. This won't work for an exclusively locked
repository and is also confusing to users.
This commit is contained in:
Michael Eischer 2022-03-05 10:29:13 +01:00
parent 44d543ede3
commit 7af69fd7b9
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
changelog/unreleased/issue-1106 Normal file
View File

@ -0,0 +1,10 @@
Bugfix: Never lock repository for `list locks`
The `list locks` command previously locked to the repository by default. This
has the problem that it won't work for an exclusively locked repository and
that the command will also display its own lock file which can be confusing.
Now, the `list locks` command cnever locks the repository.
https://github.com/restic/restic/issues/1106
https://github.com/restic/restic/pull/3665

2
cmd/restic/cmd_list.go
View File

@ -39,7 +39,7 @@ func runList(cmd *cobra.Command, opts GlobalOptions, args []string) error {
return err
}
if !opts.NoLock {
if !opts.NoLock && args[0] != "locks" {
lock, err := lockRepo(opts.ctx, repo)
defer unlockRepo(lock)
if err != nil {