From 513be4b8abcd95fe1041584272e6fae9ce053210 Mon Sep 17 00:00:00 2001 From: Chapuis Bertil Date: Tue, 18 Aug 2015 15:10:13 +0200 Subject: [PATCH 1/2] test the GetReader() function --- backend/backend_test.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/backend/backend_test.go b/backend/backend_test.go index 862d85657..8d9c8e18e 100644 --- a/backend/backend_test.go +++ b/backend/backend_test.go @@ -31,6 +31,10 @@ func testBackend(b backend.Backend, t *testing.T) { _, err = b.Get(tpe, id.String()) Assert(t, err != nil, "blob data could be extracted before creation") + // try to read not existing blob + _, err = b.GetReader(tpe, id.String(), 0, 1) + Assert(t, err != nil, "blob reader could be obtained before creation") + // try to get string out, should fail ret, err = b.Test(tpe, id.String()) OK(t, err) @@ -52,6 +56,11 @@ func testBackend(b backend.Backend, t *testing.T) { OK(t, err) Assert(t, rd != nil, "Get() returned nil") + // try to read it out again + r, err := b.GetReader(tpe, test.id, 0, uint(len(test.data))) + OK(t, err) + Assert(t, r != nil, "GetReader() returned nil") + buf, err := ioutil.ReadAll(rd) OK(t, err) Equals(t, test.data, string(buf)) From bc5e0fa68f0aa4d73e3a8c82636816af92dca001 Mon Sep 17 00:00:00 2001 From: Chapuis Bertil Date: Tue, 18 Aug 2015 17:57:06 +0200 Subject: [PATCH 2/2] test the reader obtained with GetReader() --- backend/backend_test.go | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/backend/backend_test.go b/backend/backend_test.go index 8d9c8e18e..0ff5f01b4 100644 --- a/backend/backend_test.go +++ b/backend/backend_test.go @@ -57,9 +57,20 @@ func testBackend(b backend.Backend, t *testing.T) { Assert(t, rd != nil, "Get() returned nil") // try to read it out again - r, err := b.GetReader(tpe, test.id, 0, uint(len(test.data))) + reader, err := b.GetReader(tpe, test.id, 0, uint(len(test.data))) OK(t, err) - Assert(t, r != nil, "GetReader() returned nil") + Assert(t, reader != nil, "GetReader() returned nil") + bytes := make([]byte, len(test.data)) + reader.Read(bytes) + Assert(t, test.data == string(bytes), "Read() returned different content") + + // try to read it out with an offset and a length + readerOffLen, err := b.GetReader(tpe, test.id, 1, uint(len(test.data)-2)) + OK(t, err) + Assert(t, readerOffLen != nil, "GetReader() returned nil") + bytesOffLen := make([]byte, len(test.data)-2) + readerOffLen.Read(bytesOffLen) + Assert(t, test.data[1:len(test.data)-1] == string(bytesOffLen), "Read() with offset and length returned different content") buf, err := ioutil.ReadAll(rd) OK(t, err)