octoleo/restic
2
2
Fork 0
mirror of https://github.com/octoleo/restic.git synced 2024-11-29 08:14:03 +00:00
Code Issues Releases Wiki Activity

Reduce overhead of debug calls if no log is enabled

Browse Source 
In case no debug log is configured, then calls to debug.Log only incur
the costs to check a single boolean flag making the call really cheap.
This commit is contained in:
Michael Eischer 2020-07-26 18:54:41 +02:00
parent 1823b8195c
commit 9ad8250a78
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
internal/debug/debug.go
View File

@ -17,9 +17,10 @@ import (
) )
var opts struct { var opts struct {
logger *log.Logger isEnabled bool
funcs map[string]bool logger *log.Logger
files map[string]bool funcs map[string]bool
files map[string]bool
} }
// make sure that all the initialization happens before the init() functions // make sure that all the initialization happens before the init() functions
@ -30,6 +31,12 @@ func initDebug() bool {
initDebugLogger() initDebugLogger()
initDebugTags() initDebugTags()
if opts.logger == nil && len(opts.funcs) == 0 && len(opts.files) == 0 {
opts.isEnabled = false
return false
}
opts.isEnabled = true
fmt.Fprintf(os.Stderr, "debug enabled\n") fmt.Fprintf(os.Stderr, "debug enabled\n")
return true return true
@ -173,6 +180,10 @@ func checkFilter(filter map[string]bool, key string) bool {
// Log prints a message to the debug log (if debug is enabled). // Log prints a message to the debug log (if debug is enabled).
func Log(f string, args ...interface{}) { func Log(f string, args ...interface{}) {
if !opts.isEnabled {
return
}
fn, dir, file, line := getPosition() fn, dir, file, line := getPosition()
goroutine := goroutineNum() goroutine := goroutineNum()