From b335cb628581ca42e9c21b76f238344a38cc3014 Mon Sep 17 00:00:00 2001
From: Michael Eischer <michael.eischer@fau.de>
Date: Mon, 16 Aug 2021 16:00:36 +0200
Subject: [PATCH] repository: Refactor index IDs collection

---
 internal/repository/master_index.go | 22 ++++++++++++++++++++++
 internal/repository/repository.go   | 26 +++++---------------------
 2 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/internal/repository/master_index.go b/internal/repository/master_index.go
index 96462d4a4..20aa26d38 100644
--- a/internal/repository/master_index.go
+++ b/internal/repository/master_index.go
@@ -116,6 +116,28 @@ func (mi *MasterIndex) IsMixedPack(packID restic.ID) bool {
 	return false
 }
 
+// IDs returns the IDs of all indexes contained in the index.
+func (mi *MasterIndex) IDs() restic.IDSet {
+	mi.idxMutex.RLock()
+	defer mi.idxMutex.RUnlock()
+
+	ids := restic.NewIDSet()
+	for _, idx := range mi.idx {
+		if !idx.Final() {
+			continue
+		}
+		indexIDs, err := idx.IDs()
+		if err != nil {
+			debug.Log("not using index, ID() returned error %v", err)
+			continue
+		}
+		for _, id := range indexIDs {
+			ids.Insert(id)
+		}
+	}
+	return ids
+}
+
 // Packs returns all packs that are covered by the index.
 // If packBlacklist is given, those packs are only contained in the
 // resulting IDSet if they are contained in a non-final (newly written) index.
diff --git a/internal/repository/repository.go b/internal/repository/repository.go
index d58406c7c..e97274a16 100644
--- a/internal/repository/repository.go
+++ b/internal/repository/repository.go
@@ -569,20 +569,7 @@ func (r *Repository) Index() restic.MasterIndex {
 // SetIndex instructs the repository to use the given index.
 func (r *Repository) SetIndex(i restic.MasterIndex) error {
 	r.idx = i.(*MasterIndex)
-
-	ids := restic.NewIDSet()
-	for _, idx := range r.idx.All() {
-		indexIDs, err := idx.IDs()
-		if err != nil {
-			debug.Log("not using index, ID() returned error %v", err)
-			continue
-		}
-		for _, id := range indexIDs {
-			ids.Insert(id)
-		}
-	}
-
-	return r.PrepareCache(ids)
+	return r.PrepareCache()
 }
 
 // SaveIndex saves an index in the repository.
@@ -628,20 +615,16 @@ func (r *Repository) SaveFullIndex(ctx context.Context) error {
 func (r *Repository) LoadIndex(ctx context.Context) error {
 	debug.Log("Loading index")
 
-	validIndex := restic.NewIDSet()
 	err := ForAllIndexes(ctx, r, func(id restic.ID, idx *Index, oldFormat bool, err error) error {
 		if err != nil {
 			return err
 		}
 
-		ids, err := idx.IDs()
+		_, err = idx.IDs()
 		if err != nil {
 			return err
 		}
 
-		for _, id := range ids {
-			validIndex.Insert(id)
-		}
 		r.idx.Insert(idx)
 		return nil
 	})
@@ -667,7 +650,7 @@ func (r *Repository) LoadIndex(ctx context.Context) error {
 	}
 
 	// remove index files from the cache which have been removed in the repo
-	return r.PrepareCache(validIndex)
+	return r.PrepareCache()
 }
 
 const listPackParallelism = 10
@@ -739,11 +722,12 @@ func (r *Repository) CreateIndexFromPacks(ctx context.Context, packsize map[rest
 
 // PrepareCache initializes the local cache. indexIDs is the list of IDs of
 // index files still present in the repo.
-func (r *Repository) PrepareCache(indexIDs restic.IDSet) error {
+func (r *Repository) PrepareCache() error {
 	if r.Cache == nil {
 		return nil
 	}
 
+	indexIDs := r.idx.IDs()
 	debug.Log("prepare cache with %d index files", len(indexIDs))
 
 	// clear old index files