From b7260cafac2175fc59969942b3f61c47f3abebf4 Mon Sep 17 00:00:00 2001 From: Alexander Neumann Date: Sun, 14 Feb 2016 11:48:53 +0100 Subject: [PATCH] CONTRIBUTING: Add paragraph about PRs and tests --- CONTRIBUTING.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2cfd1113d..0fdbc84b7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -138,6 +138,14 @@ in the project root directory before committing. Installing the script pre-commit hook checks formatting before committing automatically, just copy this script to `.git/hooks/pre-commit`. +For each pull request, several different systems run the integration tests on +Linux, OS X and Windows. We won't merge any code that does not pass all tests +for all systems, so when a tests fails, try to find out what's wrong and fix +it. If you need help on this, please leave a comment in the pull request, and +we'll be glad to assist. Having a PR with failing integration tests is nothing +to be ashamed of. In contrast, that happens regularly for all of us. That's +what the tests are there for. + Git Commits -----------