From d0f1060df74d3c88ebc26c83924ae5e13ab6408b Mon Sep 17 00:00:00 2001 From: DRON-666 <64691982+DRON-666@users.noreply.github.com> Date: Tue, 30 Aug 2022 04:38:17 +0300 Subject: [PATCH] Fix quadratic time complexity of Snapshot.HasPaths --- internal/restic/snapshot.go | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/internal/restic/snapshot.go b/internal/restic/snapshot.go index 10c4f218e..9eb7ab3ab 100644 --- a/internal/restic/snapshot.go +++ b/internal/restic/snapshot.go @@ -237,19 +237,14 @@ func (sn *Snapshot) HasTagList(l []TagList) bool { return false } -func (sn *Snapshot) hasPath(path string) bool { - for _, snPath := range sn.Paths { - if path == snPath { - return true - } - } - return false -} - // HasPaths returns true if the snapshot has all of the paths. func (sn *Snapshot) HasPaths(paths []string) bool { + m := make(map[string]struct{}, len(sn.Paths)) + for _, snPath := range sn.Paths { + m[snPath] = struct{}{} + } for _, path := range paths { - if !sn.hasPath(path) { + if _, ok := m[path]; !ok { return false } }