From 76e1ba6fd07381f6bcea66a12e89a0a29c1ef695 Mon Sep 17 00:00:00 2001 From: TJ Rana Date: Tue, 16 Feb 2021 22:03:33 -0500 Subject: [PATCH 1/4] Clean up pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 36 +++++++++++++++++--------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a9151cf9b..193e68814 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,23 +1,17 @@ - - -What does this PR change? What problem does it solve? ------------------------------------------------------ +What changes are made in this PR? What problem does it solve? +------------------------------------------------------------- -Was the change discussed in an issue or in the forum before? +Was the change discussed in an issue or on the forum before? ------------------------------------------------------------ + +- [ ] I have read the [contribution guidelines](https://github.com/restic/restic/blob/master/CONTRIBUTING.md#providing-patches). +- [ ] I have [enabled maintainer edits](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork) for this PR. +- [ ] I have added tests for all changes in this PR. +- [ ] I have added documentation for the changes (in the manual). +- [ ] There's a new file in `changelog/unreleased/` that describes the changes for our users (see [template](https://github.com/restic/restic/blob/master/changelog/TEMPLATE)). +- [ ] I have run `gofmt` on the code in all commits. +- [ ] All commit messages are formatted in the same style as [the other commits in the repo](https://github.com/restic/restic/blob/master/CONTRIBUTING.md#git-commits). +- [ ] I'm done! This pull request is ready for review. From d7d562b28776d72880043f83e317f5d8351a63fe Mon Sep 17 00:00:00 2001 From: TJ Rana Date: Tue, 16 Feb 2021 22:11:22 -0500 Subject: [PATCH 2/4] Clarify checklist items --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 193e68814..379d15764 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -34,8 +34,8 @@ check the last box. - [ ] I have read the [contribution guidelines](https://github.com/restic/restic/blob/master/CONTRIBUTING.md#providing-patches). - [ ] I have [enabled maintainer edits](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork) for this PR. -- [ ] I have added tests for all changes in this PR. -- [ ] I have added documentation for the changes (in the manual). +- [ ] I have added tests for all code changes in this PR. +- [ ] I have added documentation for the those changes (in the manual). - [ ] There's a new file in `changelog/unreleased/` that describes the changes for our users (see [template](https://github.com/restic/restic/blob/master/changelog/TEMPLATE)). - [ ] I have run `gofmt` on the code in all commits. - [ ] All commit messages are formatted in the same style as [the other commits in the repo](https://github.com/restic/restic/blob/master/CONTRIBUTING.md#git-commits). From 91e8f0e486717a8fa282728b6ef608a890ad3c59 Mon Sep 17 00:00:00 2001 From: TJ Rana Date: Tue, 16 Feb 2021 22:19:11 -0500 Subject: [PATCH 3/4] Clean up writing style --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 379d15764..8064670cf 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -11,8 +11,8 @@ What changes are made in this PR? What problem does it solve? Describe the changes and their purpose here, as detailed as needed. --> -Was the change discussed in an issue or on the forum before? ------------------------------------------------------------- +Was the change previously discussed in an issue or on the forum? +---------------------------------------------------------------- -What changes are made in this PR? What problem does it solve? -------------------------------------------------------------- +What does this PR change? What problem does it solve? +----------------------------------------------------- - [ ] I have read the [contribution guidelines](https://github.com/restic/restic/blob/master/CONTRIBUTING.md#providing-patches). -- [ ] I have [enabled maintainer edits](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork) for this PR. -- [ ] I have added tests for all code changes in this PR. -- [ ] I have added documentation for the those changes (in the manual). +- [ ] I have [enabled maintainer edits](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork). +- [ ] I have added tests for all code changes. +- [ ] I have added documentation for relevant changes (in the manual). - [ ] There's a new file in `changelog/unreleased/` that describes the changes for our users (see [template](https://github.com/restic/restic/blob/master/changelog/TEMPLATE)). - [ ] I have run `gofmt` on the code in all commits. - [ ] All commit messages are formatted in the same style as [the other commits in the repo](https://github.com/restic/restic/blob/master/CONTRIBUTING.md#git-commits).