octoleo/restic
2
2
Fork 0
mirror of https://github.com/octoleo/restic.git synced 2024-11-15 17:47:21 +00:00
Code Issues Releases Wiki Activity

local: mark repository files as read-only

Browse Source 
This is intended to prevent accidental modifications of data files.
Marking the files as read-only was accidentally removed in #1258.
This commit is contained in:
Michael Eischer 2020-10-06 18:46:19 +02:00
parent 40ee17167e
commit f4282aa6fd
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/backend/local/local.go
View File

@ -130,9 +130,10 @@ func (b *Local) Save(ctx context.Context, h restic.Handle, rd restic.RewindReade
return errors.Wrap(err, "Close") return errors.Wrap(err, "Close")
} }
// try to mark file as read-only to avoid accidential modifications
// ignore if the operation fails as some filesystems don't allow the chmod call // ignore if the operation fails as some filesystems don't allow the chmod call
// e.g. exfat and network file systems with certain mount options // e.g. exfat and network file systems with certain mount options
err = setNewFileMode(filename, backend.Modes.File) err = setFileReadonly(filename, backend.Modes.File)
if err != nil && !os.IsPermission(err) { if err != nil && !os.IsPermission(err) {
return errors.Wrap(err, "Chmod") return errors.Wrap(err, "Chmod")
} }

4
internal/backend/local/local_unix.go
View File

@ -9,6 +9,6 @@ import (
) )
// set file to readonly // set file to readonly
func setNewFileMode(f string, mode os.FileMode) error { func setFileReadonly(f string, mode os.FileMode) error {
return fs.Chmod(f, mode) return fs.Chmod(f, mode&^0222)
} }

2
internal/backend/local/local_windows.go
View File

@ -7,6 +7,6 @@ import (
// We don't modify read-only on windows, // We don't modify read-only on windows,
// since it will make us unable to delete the file, // since it will make us unable to delete the file,
// and this isn't common practice on this platform. // and this isn't common practice on this platform.
func setNewFileMode(f string, mode os.FileMode) error { func setFileReadonly(f string, mode os.FileMode) error {
return nil return nil
} }