5403 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Alexander Neumann	8b84c96d9d	Merge pull request #3204 from MichaelEischer/archiver-tomb-race ... archiver: fix race condition during worker startup	2020-12-30 20:04:20 +01:00
Michael Eischer	debc4a3a99	archiver: fix race condition during worker startup ... When the tomb is created with a canceled context, then the workers started via `t.Go` exist nearly immediately. Once for the first time all started goroutines have been stopped, it is not allowed to issue further calls to `t.Go`. This is a problem when the started goroutines exit immediately, as for example the first goroutine might already have stopped before starting the second one, which is not allowed as once the first goroutines has stopped no goroutines were running. To fix this race condition the startup and main task of the archiver now also run within a `t.Go` function. This also allows unifying the error handling as it is no longer necessary to distinguish between errors returned by the workers or the saveTree processing. The tomb now just returns the first error encountered, which should also be the most descriptive one.	2020-12-30 17:31:22 +01:00
MichaelEischer	e1efc193e1	Merge pull request #3139 from aawsome/prune-healing ... prune: Add healing of repository in some situations	2020-12-29 22:17:27 +01:00
Alexander Weiss	f0113139ea	prune: Correct error message	2020-12-29 20:20:05 +01:00
Alexander Weiss	f6df94a50e	prune: Add self-healing ... Allow prune to heal situations where blobs in the index are missing or the corresponding packfiles are damaged if those blobs are not needed.	2020-12-29 20:20:05 +01:00
MichaelEischer	31e56f1ad5	Merge pull request #3197 from SkYNewZ/fix/3183 ... Fix tag handling for multiple tag lists	2020-12-29 18:44:38 +01:00
MichaelEischer	7fda2f2ad8	Merge pull request #3134 from greatroar/unlock-warn ... Warn when unlock fails instead of returning an error	2020-12-29 18:30:08 +01:00
greatroar	dec5008369	Warn when unlock fails instead of returning an error ... Only one caller was checking the error.	2020-12-29 17:48:20 +01:00
Quentin Lemaire	873505ed3b	Update related changelog	2020-12-29 17:12:46 +01:00
Quentin Lemaire	25ecf9eafb	fix(cmd_tag): Use restic.TagLists	2020-12-29 17:12:46 +01:00
Quentin Lemaire	e88f3fb80c	fix(cmd_backup): Use restic.TagLists	2020-12-29 17:12:46 +01:00
Alexander Neumann	b2efa0af39	Merge pull request #3164 from MichaelEischer/improve-context-cancel ... Improve context cancel handling in archiver and backends	2020-12-29 17:03:42 +01:00
Michael Eischer	25f4acdaa8	Add changelog entry	2020-12-29 16:32:18 +01:00
Michael Eischer	cff4955a48	ui: remove dead struct member	2020-12-29 16:32:18 +01:00
Michael Eischer	05a987b07c	Support values less than 1 for RESTIC_PROGRESS_FPS ... For example set the variable to 0.016666 to print the progress once per minute.	2020-12-29 16:32:18 +01:00
Michael Eischer	92da5168e1	ui: force backup progress update on signal	2020-12-29 16:32:18 +01:00
Michael Eischer	34afc93ddc	ui/progress: extract signal handling into own package	2020-12-29 16:32:18 +01:00
Michael Eischer	023eea6463	ui: don't shorten non-interactive progress output	2020-12-29 16:32:18 +01:00
Michael Eischer	684600cf42	ui: update status for the backup command on non-interactive terminals ... Allow the backup command to print status on non-interactive terminals. The output is disabled by setting a MinUpdatePause == 0.	2020-12-29 16:03:43 +01:00
Michael Eischer	85fe5feadb	Unify progress report frequency calculation	2020-12-29 16:03:43 +01:00
Michael Eischer	969141b5e9	Honor RESTIC_PROGRESS_FPS env variable on non-interactive terminals ... This makes it possible to use the environment variable to also get regular progress updates on non-interactive terminals.	2020-12-29 16:03:43 +01:00
Michael Eischer	13ce981794	ui: cleanup backup status shutdown	2020-12-29 16:03:43 +01:00
Michael Eischer	c2ef049f1b	ui/progress: don't print progress on non-interactive terminals ... This reverts to the old behavior of not printing progress updates on non-interactive terminals. It was accidentally changed in #3058.	2020-12-29 16:03:43 +01:00
MichaelEischer	a488d4c847	Merge pull request #2833 from greatroar/aix ... AIX port	2020-12-29 12:32:50 +01:00
Alexander Neumann	4133b1ea65	Synchronize OS and architectures for testing	2020-12-29 11:11:50 +01:00
Alexander Neumann	46d2ca5095	Remove old test script	2020-12-29 11:02:48 +01:00
Quentin Lemaire	334d8ce724	feat(tags): Create Flatten() method	2020-12-29 10:59:46 +01:00
Alexander Neumann	c661518df9	Merge pull request #2793 from greatroar/rclone-doc ... Clarify rclone-over-SSH docs	2020-12-29 10:46:34 +01:00
Michael Eischer	0d81f16343	Add AIX as cross-compile target to CI	2020-12-29 01:35:01 +01:00
greatroar	3b09ae9074	AIX port	2020-12-29 01:35:01 +01:00
greatroar	18531e3d6f	Portability fixes to internal/restic ... syscall.Mknod is not available on AIX.	2020-12-29 01:35:01 +01:00
Michael Eischer	ca07317815	add changelog	2020-12-28 21:06:47 +01:00
Michael Eischer	d0ca8fb0b8	backend: test that a canceled context prevents RetryBackend operations	2020-12-28 21:06:47 +01:00
Michael Eischer	08b7f2b58d	archiver: test that context canceled error is not dropped	2020-12-28 21:06:47 +01:00
Michael Eischer	e483b63c40	retrybackend: Fail operations when context is already canceled ... Depending on the used backend, operations started with a canceled context may fail or not. For example the local backend still works in large parts when called with a canceled context. Backends transfering data via http don't work. It is also not possible to retry failed operations in that state as the RetryBackend will abort with a 'context canceled' error. Ensure uniform behavior of all backends by checking for a canceled context by checking for a canceled context as a first step in the RetryBackend. This ensures uniform behavior across all backends, as backends are always wrapped in a RetryBackend.	2020-12-28 21:06:47 +01:00
Michael Eischer	fc60b560ba	archiver: Let saveTree report a canceled context as an error ... If the context was canceled then saveTree might receive a treeID or not depending on the timing. This could cause saveTree to incorrectly return a nil treeID as valid. Fix this always returning an error when the context was canceled in the meantime.	2020-12-28 21:06:47 +01:00
Michael Eischer	736e964317	archiver: Don't loose error if background context is canceled ... A canceled background context lets the blob/tree/fileSavers exit without reporting an error. The error handling previously replaced a 'context canceled' error received by the main backup method with the error reported by the savers. However, in case of a canceled background context that error is nil, causing restic to loose the error and save a snapshot with a nil tree.	2020-12-28 21:06:47 +01:00
MichaelEischer	9c41e4a343	Merge pull request #3192 from DRON-666/fix-options ... Fix formatting of `restic options` command	2020-12-23 22:53:40 +01:00
DRON-666	332b1896d1	Some options fixes ... Add tests for bool type. Fix subtle bug in TestOptionsApplyInvalid. Fix options list formatting.	2020-12-23 23:26:04 +03:00
MichaelEischer	cb6b0f6255	Merge pull request #3181 from tWido/feature-no-retry-permission ... Don't retry when "Permission denied" occurs in local backend	2020-12-23 20:24:29 +01:00
MichaelEischer	1e73aac610	Merge pull request #3179 from aawsome/check-filesize ... check: Remove filesize counter	2020-12-23 20:22:02 +01:00
Alexander Weiss	2a1add7538	check: remove file size counter	2020-12-23 02:34:31 +01:00
tWido	7dab113035	Don't retry when "Permission denied" occurs in local backend	2020-12-22 23:41:12 +01:00
MichaelEischer	8efb874f48	Merge pull request #3148 from aawsome/simplify-index-rebuild ... rebuild-index: code simplification	2020-12-22 23:27:53 +01:00
Michael Eischer	de99207046	repository: tweak comment for packs method	2020-12-22 23:01:58 +01:00
Alexander Weiss	d8d2cc6dd9	Simplify rebuild-index code	2020-12-22 23:01:58 +01:00
Alexander Weiss	68b74e359e	Count packs directly in RebuildIndexFiles	2020-12-22 23:01:58 +01:00
Michael Eischer	b9f5d3fe13	repository: Add test for ForAllIndexes	2020-12-22 22:36:18 +01:00
Michael Eischer	a12c5f1d37	repository: move otherwise unused LoadIndex to tests	2020-12-22 22:36:18 +01:00
Michael Eischer	24474a36f4	repository: deduplicate index loading implementation	2020-12-22 22:36:18 +01:00